From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26838 invoked by alias); 10 Oct 2002 06:59:42 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 26578 invoked from network); 10 Oct 2002 06:59:40 -0000 Received: from unknown (HELO ngate.noida.hcltech.com) (202.54.110.230) by sources.redhat.com with SMTP; 10 Oct 2002 06:59:40 -0000 Received: from exch-01.noida.hcltech.com (exch-01 [204.160.254.29]) by ngate.noida.hcltech.com (8.9.3/8.9.3) with ESMTP id MAA09900; Thu, 10 Oct 2002 12:26:19 +0530 Received: by exch-01.noida.hcltech.com with Internet Mail Service (5.5.2653.19) id <4NKJHBLF>; Thu, 10 Oct 2002 12:25:54 +0530 Message-ID: From: "D.Venkatasubramanian, Noida" To: Richard Henderson Cc: "'gcc@gcc.gnu.org'" , "'gcc-patches@gcc.gnu.org'" Subject: RE: [PATCH] for gcc/testsuite/gcc.dg/20020219-1.c Date: Thu, 10 Oct 2002 08:47:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" X-SW-Source: 2002-10/txt/msg00541.txt.bz2 > -----Original Message----- > From: Richard Henderson [mailto:rth@redhat.com] > Sent: Thursday, October 10, 2002 3:13 AM > To: D.Venkatasubramanian, Noida > Cc: 'gcc@gcc.gnu.org'; 'gcc-patches@gcc.gnu.org' > Subject: Re: [PATCH] for gcc/testsuite/gcc.dg/20020219-1.c > > > On Wed, Oct 09, 2002 at 02:06:46PM +0530, > D.Venkatasubramanian, Noida wrote: > > On investigation, I found an array a being declared > > the size of which is too large for the 16 bit target. > > When I supply -mh -mint32, it works fine. By this patch, > > I preclude H8300 16 bit targets. > > So why does your patch mention H8 at all, instead of > disabling this test for all 16 bit targets? > > > r~ > In the patch, I have tried to identify the 16-bit target through the INT_MAX macro. If I had done #if INT_MAX < 32767, then I could have precluded all targets with 16 bit integers. I didn't do it as, atleast theoretically, some target may have 16 bit integers, while having say, a 32-bit address sizes (though, I do really think this is higly impossible). So,this test case shouldn't be disabled for such targets. On the other side of the coin, again, a 32 bit integer and 16 bit address size is possible. I precluded H8 only, as these weren't the case here. The problem lies in an array of 200 / 400 MB being created in the test case. Please tell me #if INT_MAX < 32767 is OK. I will resubmit the changed patch. Thanks and Regards, Venky