From: Paul Koning <paulkoning@comcast.net>
To: GCC Development <gcc@gcc.gnu.org>
Subject: struct vs. class in GCC source
Date: Tue, 10 Jan 2023 09:50:24 -0500 [thread overview]
Message-ID: <E6DD6543-1FC6-48B3-A70B-CDDB96EFAB2F@comcast.net> (raw)
Building on Mac with Clang I get warnings like this:
../../../gcc/gcc/cgraph.h:2629:28: warning: struct 'cgraph_edge' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
It seems to be talking about a MS bug (since C++ says struct and class mean the same thing other than the default access). Still, I wonder if it would be worth changing the code to use just one of "struct" or "class" for any given type. (And then the convention would presumably be that a POD type is called "struct" and other types are "class".)
paul
next reply other threads:[~2023-01-10 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 14:50 Paul Koning [this message]
2023-01-10 19:29 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E6DD6543-1FC6-48B3-A70B-CDDB96EFAB2F@comcast.net \
--to=paulkoning@comcast.net \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).