From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3648 invoked by alias); 22 Jan 2004 08:49:56 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 2988 invoked from network); 22 Jan 2004 08:49:44 -0000 Received: from unknown (HELO mtagate5.de.ibm.com) (195.212.29.154) by sources.redhat.com with SMTP; 22 Jan 2004 08:49:44 -0000 Received: from d12relay01.megacenter.de.ibm.com (d12relay01.megacenter.de.ibm.com [9.149.165.180]) by mtagate5.de.ibm.com (8.12.10/8.12.10) with ESMTP id i0M8nhe2031234; Thu, 22 Jan 2004 08:49:43 GMT Received: from d12ml045.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12relay01.megacenter.de.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id i0M8nfdW268066; Thu, 22 Jan 2004 09:49:42 +0100 Received: from [9.152.222.71] ([9.152.222.71]) by d12ml045.de.ibm.com (Lotus Domino Release 5.0.9a) with ESMTP id 2004012209550502:423 ; Thu, 22 Jan 2004 09:55:05 +0100 In-Reply-To: References: <71F1890A-49EF-11D8-9D69-000393A6D2F2@physics.uc.edu> Mime-Version: 1.0 (Apple Message framework v609) Message-Id: Cc: Gcc Patch List , "Timothy J. Wood" , gcc mailing list From: Segher Boessenkool Subject: Re: [PATCH] [COMMITTED] Fix Re: not happy with 3.4 on powerpc-apple-darwin7.2.0 Date: Thu, 22 Jan 2004 08:50:00 -0000 To: Andrew Pinski Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed X-SW-Source: 2004-01/txt/msg01733.txt.bz2 > I never heard about extern "C++" -- what is it, where is it documented? Wow, it turns out, I don't know C++ at all. >> +}//extern "C++" > > This is wrong; please use a /* */ comment (yes I use std=gnu99 for all > my > own code, but not everyone does) (and coding conventions require some > more spaces, too ;-) ) Never mind, this was in #ifdef __cplusplus protected code, as Andrew pointed out to me privately. Which leaves only the spaces issue ;-) Segher