From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay-out1.synopsys.com (smtprelay-out1.synopsys.com [149.117.87.133]) by sourceware.org (Postfix) with ESMTPS id 9B64F3894430 for ; Wed, 7 Jul 2021 10:06:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B64F3894430 Received: from mailhost.synopsys.com (sv1-mailhost1.synopsys.com [10.205.2.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mailhost.synopsys.com", Issuer "SNPSica2" (verified OK)) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 16117C0B5D; Wed, 7 Jul 2021 10:06:39 +0000 (UTC) Received: from o365relay-in.synopsys.com (sv2-o365relay1.synopsys.com [10.202.1.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "o365relay-in.synopsys.com", Issuer "Entrust Certification Authority - L1K" (verified OK)) by mailhost.synopsys.com (Postfix) with ESMTPS id 04118A0268; Wed, 7 Jul 2021 10:06:38 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by o365relay-in.synopsys.com (Postfix) with ESMTPS id CC44E40031; Wed, 7 Jul 2021 10:06:37 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBrgZ7QOt+xXuvllnjZByXWB8Ea2Dvt+TXn9mK6Ol0RPRvD9iGRWisxWndyKQLlrdLSU5J09AAUfALe3cdU6e3a5A7hAR8qdICFybM6iXj8jrdZV9UqDw2hPUhZz4cB0REoL4JiTSxFRjteohpJYQPuvTihhaG6FLYiK1sv38RVK3b5QxL6FJy6SA4/QMlj9AsFpbr802Z2wKFes6ZEEBSNTouvvdAVQ0qw0/psMt92AXqR/4r715bQe98tdvj++BU2oszvArU0PLPEDM1QjhEYVWxXCd4conerBGzgILyu74b5i3hsbm+/qMgJ0crwFaWHEjRqyE0Xlq6TCrsJCVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PbFoA1Sd9Vde1vkIUQ7R7+B9nT9jM3D+6OdY4sr/59o=; b=mbuRmuLRkyq1RCrXqSvNOCCNpyA3eIUZxlnRLim1x7KLeL/CrTNtNbr/uWKFQmOWVxoj/BTFNOgat6fMgSO0BOkiEQOe0U1BhEslrwH7RRuG78FDQoiGOQMPmODL5DnkCPlv/9xZ+FJ/LekV0iqM8DoIgTbFqBZGTlrz6qT6stRt2IkuRabWQY4+nEPj7hAT/TFNOtHbJ4V0VJ2qaB7tF1p197C4p0y3RJxcpYgnnqkKHA4pAb2y7Ikpi93N88VntxrwGH63jDEsUQ98tsmqD7xKaUEEeSZ0X+VOaRTIB759uguJa1OvpMR9fDEMWJn+/pZ80RdwK9k1erVvqZOvIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none Received: from MW2PR12MB2346.namprd12.prod.outlook.com (2603:10b6:907:4::12) by MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.32; Wed, 7 Jul 2021 10:06:35 +0000 Received: from MW2PR12MB2346.namprd12.prod.outlook.com ([fe80::c030:d154:fe02:bbc1]) by MW2PR12MB2346.namprd12.prod.outlook.com ([fe80::c030:d154:fe02:bbc1%6]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 10:06:35 +0000 X-SNPS-Relay: synopsys.com From: Claudiu Zissulescu To: Richard Biener , Florian Weimer CC: GCC Development , Joern Wolfgang Rennecke Subject: Re: GCC arc port defaults to -fcommon Thread-Topic: GCC arc port defaults to -fcommon Thread-Index: AQHXcw5k6ygwaP5GikSxsGThKrXNMqs3RoUAgAAAk4CAAAGlEw== Date: Wed, 7 Jul 2021 10:06:35 +0000 Message-ID: References: <875yxmbiu3.fsf@oldenburg.str.redhat.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d60fbf62-e50b-4901-8de0-08d9412ee74c x-ms-traffictypediagnostic: MWHPR12MB1501: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kkk5t+zM7Q2jDhOXpclVEWlvL6u31iv6JK23ro21Pez7Fc8o/zq0goJdl2L8+fJ3Q8Xnc+vO2jlprT0V6ughvIC8hgvBxU2+VVH20i0XypS24+kvKOhgfgEV+zfF1rjEUaixGtwZtZ2HocXS4+ixJH23wfFjRYqOnw7C6dhySTb+Z1c5Xh1OPIvvfiVAlHUIWPhB9zXeFYjPocSIXcxdfcGLeg8OVtDot+mEkcqfBwEhCXtjFIg4BcwDDm0esFSy8v7bc8ngxWVpkzis5RNppDvkYzba48dS5T21U0zGsK1IJISSLVYqReFPGm+ZE5zZInl+1qoCUu4sFvYNx+HtfC8Q9Wo7E1bBbfMUP9avnhby6pBuVxtUkfgieHZ+tpjj5/5mCov9FsDy8QwsjlDcCNSey49/zGN744ZZNx6i7HY4yg4Hx1V25I27P8uwnuMUz6oyDmHG7ClgZuxLm3p2sEVJ/rjpiZ5bOREIWt42rat5LscbA9EcP3GR1+1oEw5GEAYLZXHThGt1fb5eleZsY46OJWhf84YGjo6eECCB8KY9+rBUTD5ybyCQEz+PYJxtPE7yMm+qxaWLA0bWoHwA+KYhZvJ/Zd5QJnioekIapzvW13Cm4ehqLg5wSu+fXloRzh9vFaUmBJRC0MXKUl0C8Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2346.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(396003)(346002)(136003)(376002)(66476007)(5660300002)(478600001)(8676002)(83380400001)(9686003)(71200400001)(19627405001)(86362001)(66946007)(8936002)(55016002)(66556008)(2906002)(7696005)(55236004)(26005)(4326008)(186003)(122000001)(33656002)(76116006)(38100700002)(110136005)(316002)(66446008)(54906003)(91956017)(64756008)(6506007)(53546011)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gp5HugmVL/Jf4cHtYCxnH5pF2NF8VeIWcBg9sVUMybXF7+3p79GoOurG2Sui?= =?us-ascii?Q?Ddx0zCtgz+S/hsVZL7OK1Enkc2aL8Zg1fFJTP2UBm5MOIIxov/p0mCMZxHT3?= =?us-ascii?Q?xMOTjpsiFTXq4wa16il2jtuY5zg7rrNVHy/aVd6fmOUWyZrny4aKIqjoJkIb?= =?us-ascii?Q?WSAO3v4Z9C8YLRfoE8HbUurPb4pc5tzb0j50hCIl3icpuMPH8nMT7pBemJZm?= =?us-ascii?Q?UzzSaVyO3Ao2yIgCYWrmsu3C7QFfnyTw7IYow1ZS66iNNkAiMs1LTQ4foyJI?= =?us-ascii?Q?hGHRQuFiLsJ1dbLmkE82g5sAAzO9lkNBCQFXiGcwGI2/xlBLrA1LwJoYwKu4?= =?us-ascii?Q?sQzZLlkb9xrBE62ktYUyD/k6T/LTdAQe4uVs8tqwddRVL1LZvDy4h+Y50c+f?= =?us-ascii?Q?GBMHvBu3V/k+dIsvPn8Km8QbQM08f2lD3rVkT/ks9Wu0beXt1AXgT0u8897i?= =?us-ascii?Q?7ERfdo5+0h8myAbz9rGN0IFA5z5D1nDpRwWCOjqj9+t9rzbS+wrfNjfBYIM7?= =?us-ascii?Q?ehmvb8yvwXCw1N4Aso7+MhwGbEpZgjZb3zprRjXZhvEeEZTuKQham8s5H1RV?= =?us-ascii?Q?+YN0bM1lNB8410QwYB80X/3NTBzB7yTmyB4xmKjQt386UEkeUWK6YVeNH/zg?= =?us-ascii?Q?iQQQaRmF8aETMrdajFuNignmi9+m0gBSZ7hI/ftJTX98tI89jtKHWXL1pYQO?= =?us-ascii?Q?fSjm4GvC+ZBEB7u57wpgqJGsk7KhpN4HrXYhkF7Kapu4FUuWe+4h0z/7vBzh?= =?us-ascii?Q?VI2/dKRLk0GUPV3vpIstLTtdUKJIh3XMWRZQngmYsDOqpWaQ0vcpKFsX93fA?= =?us-ascii?Q?/lu8/OSy8SRIinp1vFfYx20eW+HlQZbphdSugyrG2ysWveadJU2jJ1TvRkVJ?= =?us-ascii?Q?i2J+a//HDk+e1j10v5gkzQ5FKdZRFAaiFSZckBIwob3AngRQtsRsphUO1dFR?= =?us-ascii?Q?iH8bqwpehdg4CTuW6BVwKi7zW6mKFKksvQ9g4KJ/mRVmEBaFtQkXEEuj+Hgs?= =?us-ascii?Q?TUD0AY3pp14oHmgX8uB+TAWalMg9uMNAweUjk6e1xtYUv81z48xJ8GN0Q/Zy?= =?us-ascii?Q?maF1STnJi6cV/1htLxMLMML/awA5myFW7+rjL0PaxFRMDMQLK8g3XxZ+Ssdi?= =?us-ascii?Q?URJL87608xChIfdfZ7EXf9T2c/S3ktvcnzhqMCb7b4jYsM/0Gpc7W49s+Avu?= =?us-ascii?Q?X3ICw5PbVE5T25typICOTJFNBtBQlFAuN4fllUZznpiIigBbadXZNYaqUGl0?= =?us-ascii?Q?7g6ojYes571N+o2tHUNUglvZdZFsUW6OnCiCeRXK7C6PubtJE6IdOI8GjV7W?= =?us-ascii?Q?i+0=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: synopsys.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2346.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d60fbf62-e50b-4901-8de0-08d9412ee74c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2021 10:06:35.3531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SCMqQrzRYLuc3TG/l2gO1hpuiQ6QM3wMtXRwspzQtad5jo51RpBXqttZehDeqg/cIn6uFqIYJXwpVmqEzlIuDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1501 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 10:06:44 -0000 The fno-common option is indeed related to the use of small-data. However, = the small data is only used for baremetal applications, and it shouldn't be= used for linux toolchain. To me Richard's patch looks alright. Thanks, Claudiu ________________________________ From: Richard Biener Sent: Wednesday, July 7, 2021 12:58 PM To: Florian Weimer Cc: GCC Development ; Joern Wolfgang Rennecke ; Claudiu Zissulescu Subject: Re: GCC arc port defaults to -fcommon On Wed, Jul 7, 2021 at 11:56 AM Richard Biener wrote: > > On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc = wrote: > > > > It seems to me that the arc port still defaults to -fcommon, presumably > > due to this in gcc/common/config/arc/arc-common.c: > > > > static void > > arc_option_init_struct (struct gcc_options *opts) > > { > > opts->x_flag_no_common =3D 255; /* Mark as not user-initialized. */ > > > > /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). */ > > arc_cpu =3D PROCESSOR_NONE; > > } > > > > Is that really necessary? Is -fno-common broken on arc? > > It seems arc has -fcommon dependent on !TARGET_NO_SDATA_SET > but it should use global_options_set.x_flag_no_common instead of > such magic value. So sth like this (untested): diff --git a/gcc/common/config/arc/arc-common.c b/gcc/common/config/arc/arc-common.c index 6a119029616..c8ac7471744 100644 --- a/gcc/common/config/arc/arc-common.c +++ b/gcc/common/config/arc/arc-common.c @@ -32,8 +32,6 @@ along with GCC; see the file COPYING3. If not see static void arc_option_init_struct (struct gcc_options *opts) { - opts->x_flag_no_common =3D 255; /* Mark as not user-initialized. */ - /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). */ arc_cpu =3D PROCESSOR_NONE; } diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 69f6ae464e1..b9097b11835 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -1440,7 +1440,7 @@ arc_override_options (void) if (flag_pic) target_flags |=3D MASK_NO_SDATA_SET; - if (flag_no_common =3D=3D 255) + if (!global_options_set.x_flag_no_common) flag_no_common =3D !TARGET_NO_SDATA_SET; /* Check for small data option */ > > I plan to switch glibc to build with -fno-common unconditionally, for > > all GCC versions and architectures, and I wonder if that would be a > > blocker. > > > > Thanks, > > Florian > >