From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay-out1.synopsys.com (smtprelay-out1.synopsys.com [149.117.87.133]) by sourceware.org (Postfix) with ESMTPS id B2A4A3850437 for ; Wed, 7 Jul 2021 12:19:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2A4A3850437 Received: from mailhost.synopsys.com (sv2-mailhost2.synopsys.com [10.205.2.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mailhost.synopsys.com", Issuer "SNPSica2" (verified OK)) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id AE073C0B64; Wed, 7 Jul 2021 12:18:59 +0000 (UTC) Received: from o365relay-in.synopsys.com (us03-o365relay3.synopsys.com [10.4.161.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "o365relay-in.synopsys.com", Issuer "Entrust Certification Authority - L1K" (verified OK)) by mailhost.synopsys.com (Postfix) with ESMTPS id 81F70A0273; Wed, 7 Jul 2021 12:18:58 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by o365relay-in.synopsys.com (Postfix) with ESMTPS id 24A938012F; Wed, 7 Jul 2021 12:18:57 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGN8xPpn4kjSK+NaokJAwD1Wpw4Y8JuuD3eO9saZktNCSwftVrRATV/i8C5sdAbo0kO9lcw9D7MkV+xEIoV90evuh9mRFpy3NRViHIJ6PuiXCBh9x7tjOkC5XGxZeHKH1LQZ0vGS5fDWdtVLkIJvH9zJZ/F2Rm8/2sSNq5C9i4msPKhgbXFzn+9pyEHjvG8CvHxDnxXTR6EnTdMq1FzIDK83pj5z1xlPHv/wubWqBNLPAmd6jcm85CwqaPlJ9/AVpHzOUrkJuu8WGTqiYBE8SmYnft+Qq6Ye0zK0ZMDOV3iBoRMtXUhw0IleZ7G39GPJc6QeHRBT3DGl0fvfsFITEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hn5/SkDbRsh4plhBbvRXTJE0jOFOJMx2OusfeoW/k7M=; b=XBnoz4g+1BXrvMX7/yCA4prGW5HWacjQf6k/1aMrGrXc7yvzD0WXKAxY3MJDa4Xsz1rAhDohKGZIBizjuGlXvpyD0szf40lJ4KEp0KThc/kFEEcdZBJTY1oGauzKDg9bkDqXh4RGz/36nKdL6UgE85UwMO+/IPjy4L+U2NIbReboaAjpgtfLMQL+YlgxC+miAebmJpAgXkGsVqMLnyRufgDBh7N6abYBSKQ6ATu5Jxf35vfR/8ljTBE6NwtNilrIjOe/S2urvdlbDTfeMY547UIWHQAo469NJ8wkxKmaC09x8LUSMqbyB7FiKxUfPCZSD2KorzvYLdzB0bONz4AHNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none Received: from MW2PR12MB2346.namprd12.prod.outlook.com (2603:10b6:907:4::12) by MWHPR12MB1360.namprd12.prod.outlook.com (2603:10b6:300:12::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Wed, 7 Jul 2021 12:18:55 +0000 Received: from MW2PR12MB2346.namprd12.prod.outlook.com ([fe80::c030:d154:fe02:bbc1]) by MW2PR12MB2346.namprd12.prod.outlook.com ([fe80::c030:d154:fe02:bbc1%6]) with mapi id 15.20.4308.021; Wed, 7 Jul 2021 12:18:55 +0000 X-SNPS-Relay: synopsys.com From: Claudiu Zissulescu To: Florian Weimer , Richard Biener CC: GCC Development , Joern Wolfgang Rennecke Subject: Re: GCC arc port defaults to -fcommon Thread-Topic: GCC arc port defaults to -fcommon Thread-Index: AQHXcw5k6ygwaP5GikSxsGThKrXNMqs3RoUAgAAAk4CAAAJc2IAAIkGz Date: Wed, 7 Jul 2021 12:18:55 +0000 Message-ID: References: <875yxmbiu3.fsf@oldenburg.str.redhat.com> , <87o8bea15l.fsf@oldenburg.str.redhat.com> In-Reply-To: <87o8bea15l.fsf@oldenburg.str.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0c675d8-4b36-4a93-e1c2-08d9414163b2 x-ms-traffictypediagnostic: MWHPR12MB1360: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BYHsToORNbYfBj7Z0jCPe+syNwd2Gzmnw/Avmdwzj3Y2UrmOjFiRWdAZmrc6pbo8dR8VVw0NRalZOt/+E16PWqTEnYP6xvApS1ejrpKYe13QBzRl66jZZzmpg4eNzGuMCdZF1RnBvTSbWqXMV6obTDIthDr8uwtOVlsw47E8W8WXDQRfg4J7cGESVdAaUPvoGGfmNGM4Odo0rfFL7UhSkP0Y7cIDP70QIksUMvgoMH3CXxC0ldgnwYeObqzskHsc30J+gDsr6TAzoCulq8MzdhofOG4nBGVjvYt1Swhulc7pzcEuY+26l6eajONR4oH9vDffHotNFd5hvSTFLlVz2rzfitGFd43OXC8L8uZU61ituq35cE9l8jWUS1hXFphpQOp5FI8Bmhu7ktdx4eYGjezxnI/iSPh0/fQtOnmUij1gQ8gNCEDW2qSpQUj8y2xkTAchGhY6gSDcqjD4zSTkl0RE8bPpx3Lo25IFVxUK+wIBT3Xk8BRoNEZ3E/qMurA/ods1rj3cFMfbjSS2A4A1/jRSZFT01TKtDz7411ATl5yVTyMmYtRBhgfCO9RARURQS5BeBJUUnsIpLC2mo/jqw1YwRQYLwEyZyuyjyuYXEcLz7ui39fFFK+TYpIoFHZMDlqqmd7zeuyXFeGKWGPdIIg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2346.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(396003)(366004)(136003)(346002)(33656002)(71200400001)(66946007)(64756008)(122000001)(478600001)(6506007)(8676002)(5660300002)(7696005)(66476007)(110136005)(54906003)(76116006)(4326008)(52536014)(91956017)(66556008)(66446008)(38100700002)(2906002)(8936002)(26005)(53546011)(86362001)(19627405001)(55016002)(316002)(9686003)(186003)(55236004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RUi8Pb1Spf8ygaBogyq6X7Ad0wlOGeL4XxhBRE63AV0j3frMtP7+PjF29i9t?= =?us-ascii?Q?GhGwVIa2mrongPvzDnveNC4bddrpsFe66TzE1SzLBwxMUOU7o/3Y3ppDJ3ut?= =?us-ascii?Q?b/GmPb6QUjgBn+B3t37Vi4H2/a3bG9LsKTe7RffP8oBi4CSHb/ttkuywCLlD?= =?us-ascii?Q?NG/4pStZAAu6H1IbqFstCpBBsFqGMGLtRgFeJw7DSI5AGD5d/xmAViQ6g23U?= =?us-ascii?Q?BIU8FPMVFfZMer0ZrjmPmN9IkmsurqJppC2B5N1tC4SLpBvEfJGxfbiIV9Ic?= =?us-ascii?Q?GPi9WjhCGf+c1qoDGwFSKWWhhQPfNM7yDYx7oypnEReejkhYf5wrCpD4CTcL?= =?us-ascii?Q?IJINXXTqTwJbmxuTtehyLQOlquxcNRtxUPtTeNzSVdZeD1n3PuMmQSrnLjiK?= =?us-ascii?Q?vmEG+JCaEvQSWr1vxAb5Lb10BpwHeht6BQ9yUdK6zF7AQJKTOiSX6BkRrHH/?= =?us-ascii?Q?3Z79oGBvk9ZA776w3PU7ZLeCzrcfa6g0ExkxynPDXtklED3yLjqJpNyO4bl0?= =?us-ascii?Q?XNZk1pTRW6VG/hxB7e+k4GzX6tlh1kAxCx1/7+iw3RHtO1PZ2U1hgb/we9rS?= =?us-ascii?Q?gqSjiq2F09ZEL99nU9SguPrY06PpV0kiRtlSspftktIJ796JdOFJG+Kl6uGE?= =?us-ascii?Q?UlcAR+8dlr9Z5ZutosRko26NlkknhuGmK1B0DtWzAw9gGaLgtInVngTKxis3?= =?us-ascii?Q?EjJZSZfBGzOIuIuiq+dwWnZUUBmexP9dwRtMv1hwg/1+4VmfaG0GtCVWLgx/?= =?us-ascii?Q?/nMSAa9Zrtq1iKUvsvQj0lNNJgbfPE6naxWbk1mGJB7R+GTZzp52OocgYdFz?= =?us-ascii?Q?ASnLGs84/2mNezNI8RyT1FHeapyFaCsW8Kzf5EF1eDI8ZIfCDAD+9faRMYaP?= =?us-ascii?Q?YgnX3MSj1iQ+YSBQSS0vKNPK56NW9ea4hhfgeSrODJk3vcUs3IpInf5H+iq8?= =?us-ascii?Q?nAqpye6twXYt38hW1DaqO7EmSf8ByidB+RKiwP5oApEc7ihbLUW/Qui+D514?= =?us-ascii?Q?PL8sdlbJSaZx9Lz2znlZhMeU07fAqXW6zQCqrRXfszqqIUGC/IEoJXGe1E/p?= =?us-ascii?Q?a0NGRuMo0cFwlpM337J7Vf/LhhnrLs1qwoKsSYqdk1CYKVy0nDzKlYMWeWdi?= =?us-ascii?Q?4qap1nMHA7XzjhTTXZqMCei2xDhIfWY1K4SRvXApMhAogg6kJrz5D1SeFMHO?= =?us-ascii?Q?5jd9n41WwxxdKMq+94qg6k2oaxDlScLX+UtuxP1PKpgg0Tim29pahCxY5fKv?= =?us-ascii?Q?epddIxaOVKVP8aTkRxZ5f7rhMUV10+P9mFdP8MLZ/EUzBt7RdUFxumK/bRYY?= =?us-ascii?Q?x4Y=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: synopsys.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2346.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0c675d8-4b36-4a93-e1c2-08d9414163b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2021 12:18:55.0443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2Pi9PY/Fgc14pnLnTB4NOpfEDkfYWcmw6nq01U6rTT5x5+L/XCF9ckzLQUbyD2K1Ffsf3Na0EOrLjrE4xZUGaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1360 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 12:19:03 -0000 Hi, I have quickly tested the next patch, and it looks like everything is alrig= ht. In the end we don't really need to temper with fcommon. diff --git a/gcc/common/config/arc/arc-common.c b/gcc/common/config/arc/arc= -common.c index 6a1190296167..3b36d09997c7 100644 --- a/gcc/common/config/arc/arc-common.c +++ b/gcc/common/config/arc/arc-common.c @@ -30,10 +30,8 @@ along with GCC; see the file COPYING3. If not see #include "flags.h" static void -arc_option_init_struct (struct gcc_options *opts) +arc_option_init_struct (struct gcc_options *opts ATTRIBUTE_UNUSED) { - opts->x_flag_no_common =3D 255; /* Mark as not user-initialized. */ - /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). */ arc_cpu =3D PROCESSOR_NONE; } diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 584783f2fb88..5f1d2ffd3995 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -1449,9 +1449,6 @@ arc_override_options (void) target_flags |=3D MASK_NO_SDATA_SET; } - if (flag_no_common =3D=3D 255) - flag_no_common =3D !TARGET_NO_SDATA_SET; - /* Check for small data option */ if (!global_options_set.x_g_switch_value && !TARGET_NO_SDATA_SET) g_switch_value =3D TARGET_LL64 ? 8 : 4; ________________________________ From: Florian Weimer Sent: Wednesday, July 7, 2021 1:06 PM To: Richard Biener Cc: GCC Development ; Joern Wolfgang Rennecke ; Claudiu Zissulescu Subject: Re: GCC arc port defaults to -fcommon * Richard Biener: > On Wed, Jul 7, 2021 at 11:56 AM Richard Biener > wrote: >> >> On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc = wrote: >> > >> > It seems to me that the arc port still defaults to -fcommon, presumabl= y >> > due to this in gcc/common/config/arc/arc-common.c: >> > >> > static void >> > arc_option_init_struct (struct gcc_options *opts) >> > { >> > opts->x_flag_no_common =3D 255; /* Mark as not user-initialized. */ >> > >> > /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). *= / >> > arc_cpu =3D PROCESSOR_NONE; >> > } >> > >> > Is that really necessary? Is -fno-common broken on arc? >> >> It seems arc has -fcommon dependent on !TARGET_NO_SDATA_SET >> but it should use global_options_set.x_flag_no_common instead of >> such magic value. > > So sth like this (untested): > > diff --git a/gcc/common/config/arc/arc-common.c > b/gcc/common/config/arc/arc-common.c > index 6a119029616..c8ac7471744 100644 > --- a/gcc/common/config/arc/arc-common.c > +++ b/gcc/common/config/arc/arc-common.c > @@ -32,8 +32,6 @@ along with GCC; see the file COPYING3. If not see > static void > arc_option_init_struct (struct gcc_options *opts) > { > - opts->x_flag_no_common =3D 255; /* Mark as not user-initialized. */ > - > /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). */ > arc_cpu =3D PROCESSOR_NONE; > } > diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c > index 69f6ae464e1..b9097b11835 100644 > --- a/gcc/config/arc/arc.c > +++ b/gcc/config/arc/arc.c > @@ -1440,7 +1440,7 @@ arc_override_options (void) > if (flag_pic) > target_flags |=3D MASK_NO_SDATA_SET; > > - if (flag_no_common =3D=3D 255) > + if (!global_options_set.x_flag_no_common) > flag_no_common =3D !TARGET_NO_SDATA_SET; > > /* Check for small data option */ But this means that arc still defaults to -fcommon with this change, right? Thanks, Florian