From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07olkn2086.outbound.protection.outlook.com [40.92.15.86]) by sourceware.org (Postfix) with ESMTPS id F30A03857348 for ; Sun, 3 Jul 2022 02:46:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F30A03857348 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRN1/46nXVvqGVpqrpwOLHlco0III8sBm115P3BQb2BQYGCtjPfrkujwsk3kpbtRUiiK0750CeC9lOEg/JPW0JXEV/J5d+MzqgFV+iOdtRMKnv81mw30kxYdSiPDEi2joTfFcTrMOWBcKO10EbQprU2vpDvSNb3lg+7B63gk7VmKiIKuacCxeOL3k2VBkI2PZTi71x+AWlRYf5RjYxA0yZn6MV7XNYavBhTQ0QUMsZ5rg3C1j/Asv4ZbgxU0iCO61xa28WWBZq5LcHMUPjheggEVh+iEx8TBnpdk2abeNCb571NJKypnG/eqiqf+prwwMBIZLuq3D2sxzEqUyGn9+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8MXnZftGTYOsaVQSMf+/2//IraUVphqx06i9zD2qorQ=; b=eSTPfcfIm1yNwPeGOhkDWCt4qMP6kRCNOaca1mEMrFzjQbg2WJyTYxbCDfDzheujsN0yT46c1tozkfZwM9qT1qSNOsppXl4ACh0hqKYK3OBiUiaRCXaZRiElE8VFWeIDFf+c69bulcJpMSiSGaXvJlkEt6VC8zvuogVHpuNv2uA6miVoV8KKVsLES3AxgX+bW5NPN2u6k3lfaFBP5UG+yVpXjRlNyEHkLTNjfQwlIHE3PYjTEt0vsoCXxihRfK+BhVhrXSL65+v1QJRMvVL//CmFsbgx8YSBzfLtPKHsreK04Qx7WWmc+vuIVHu69+IImu7SfEjhxzHzxydD6YPx0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MWHPR1401MB1951.namprd14.prod.outlook.com (2603:10b6:301:51::14) by DM4PR14MB5695.namprd14.prod.outlook.com (2603:10b6:8:8e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Sun, 3 Jul 2022 02:46:38 +0000 Received: from MWHPR1401MB1951.namprd14.prod.outlook.com ([fe80::d1c0:3f7b:f7e0:59c7]) by MWHPR1401MB1951.namprd14.prod.outlook.com ([fe80::d1c0:3f7b:f7e0:59c7%3]) with mapi id 15.20.5395.016; Sun, 3 Jul 2022 02:46:38 +0000 From: Jay K To: gcc , "dmalcolm@redhat.com" , "mirimmad17@gmail.com" Subject: Re: analyzer: implement five new warnings for misuse of POSIX Thread-Topic: analyzer: implement five new warnings for misuse of POSIX Thread-Index: AQHYjocePqMf9gr3q0WhbQ732sDzaw== Date: Sun, 3 Jul 2022 02:46:38 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 97b2fb92-a39b-6a3f-4773-685e9136e932 x-tmn: [86eZwWT6BWuaf8kHgx01k2i/p9Gc9lsLlDsliNCPki1NiA0ZzKLjDNnGqqT5L9nJ] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89d1fd09-8779-4b1a-94fc-08da5c9e40a5 x-ms-traffictypediagnostic: DM4PR14MB5695:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: piGaaR2i+4H9kQdxB1lqDXHmpCp/i/xsfvaEQIWSBE5CaZexjqzF/17qJJtSw+oEKadSPtvkjAuDmPqzbVJRJAjybFGmWxtf3scNSMXE9yk4n3yyvptowDKclrX6CILzNrVLID8qv+sPYKlCXKd/g2ryxNC5ClFPPOFW1nvfte15SuneqAtPPCEcJa/9y8Qz57/iY3krPUJr3+HhAs8SDYBYJXq2I2vxgK6d++5yZgbxLd/eZatN4pes+6PmAOFNlIIfd/6UgFyTYngA5gj/p2YJ5Kg04sf9fLKVQbkqlUHnBGhvHd979PvAm92wzw0XwBz+NSNHPu58CjzF5W8S0TFqGPZ1w6Y/fK8oNYB1nIYpWaXCn44YPblyePZL7OHqaYueD5FiwFawhkCpBSEKwmFAxNkD5t2irIElbHwM0vTiG8bujPyWT3ceILqM22wFs5Fl35jpXxaWKkTUbZ1mcaLVnFrdEnQuG2PdRXWZGOcRCs4Hv9fgmjMVMmkDUIt7cBGc+nzAzKUszoN3Gc4i8lr8IymUM8/VoWjxcDEJFFHTENM2Rv5z1EZVyVaAdTZq+LsciAz1tqSEun+ETTtbBKlZ2pxqu8vD+bimTA8otgRjCK1QVoS4t8syfsYENrZhO6imgRx43Q+noVjmT3ncJA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Wr5q6oqLf1zoQYkWB3t3+2rg7C6XAgA87AbLvmABPfsrwM97E06Hp7u/je?= =?iso-8859-1?Q?KR2/LE5KPi2sPbYTKKtg39ecqjyezp7mlzQkh1/DE2PJzd7wF3V3GJ4TZx?= =?iso-8859-1?Q?B9iPuE8JMyNpMcS+cGQWmo0nMSJtQU+wztNta1gZCmAczKyLCipQ4V8Gkf?= =?iso-8859-1?Q?AAfAWib+t59yHcjgXe8XPF0eFsTv2kusvmj3CB/wq/OyulOHqujWmqOPwU?= =?iso-8859-1?Q?L0sYWnr1nhMS2M6O2Y0QeUXUqbg4o00bMtth//canUV3y0VFx6cjubnLRB?= =?iso-8859-1?Q?dfvUy7cjVOfUDoplFnKMLno3yz8FfYzRVI4ewyzNrKWtTmy6LirPGXS336?= =?iso-8859-1?Q?s/hCAWB3AqIUmQuUobSNHdPVmSBGoiAqdQxEomR3IHHTHDKGK/ywqfqIaH?= =?iso-8859-1?Q?hxq60WpgfIf3wapbmnwNbM0r6fbRI1JqRRTnkCYFLNtbyf7YIstuXrivYt?= =?iso-8859-1?Q?/XNsBPVHybZwieKo3rwnvOFqj7NzHoU8jguz2FewjL5nlrNnMOIngdymxj?= =?iso-8859-1?Q?x+N29P1aeePLHTi/b0oUIExqpLh51lSiERwfgWcmNRuUv9u40WZklhvT5O?= =?iso-8859-1?Q?7ryT4waWCRWx0nLJKT0663wzuHiOCthp0g8ebR2p8FMXrttpo8gFsAES0I?= =?iso-8859-1?Q?lWBJjIjGQg0eI7weKqJ/Qw7Fn49/YI85jPsEb07Jc2gOe2cZuPlkQRYzeB?= =?iso-8859-1?Q?SQQA35veJ0KWAdPxQlBVM6bp+ILqe5Z8zhLZF+divFOl1SZVb5wfDr/g2V?= =?iso-8859-1?Q?9/Cd+OSgqj9zuA9FSlkMUAsWqkZv+aBQf5S1TIEyP5S4AcAtgvsMWfQD3s?= =?iso-8859-1?Q?k0Sbhq96rjbE4JciOAEZlSBLugf8wttjkkYaN2wICEOh2f/I6yhLT4qCAN?= =?iso-8859-1?Q?vKHVZj/8laHtmnVcPunqPgkJjchno9ah6+GZuUEFvu75swA7Mlqs/Gk+GE?= =?iso-8859-1?Q?X3gQ/+Iq/Ox8WOE2fc0njp6p+ujgrBwLIpPRs5ZsHTK8+LCsxtITZAtzic?= =?iso-8859-1?Q?TiR4f6ckcZpYm0NQ7OoOPjVvRIPQ1doxaL4mF74Xf87fo8UnBxo8jvd75O?= =?iso-8859-1?Q?OMzCNmTxk5kWM0I2Y97Eiowt2g7RC6fAw9P9en1Y5rUTdZ6Z1YmlXCbNUn?= =?iso-8859-1?Q?8vyAZv7OV2wkbvRhcq5kFwjpxU1VfFtOlihXTkBPYnQI7MMIeIIoxrm0/6?= =?iso-8859-1?Q?h6nZI7XPsgdTDnnsGb6Dz9dPLePQLVwy4KHjt35WBuJ7l4aYWyHAUwBtJc?= =?iso-8859-1?Q?NFwwCdGeOPSA9slB1NKIimrcRXhk0g0inydf2oPC6GNWZ+vc6pyIkiz6TY?= =?iso-8859-1?Q?Aq1FWxyNliNlRMcC09Fcc/yHTt2JuUn0uyo1oOOoNLIvDgBsCEmgZVXSIU?= =?iso-8859-1?Q?ZAMCstCBpn?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-cd57b.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR1401MB1951.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 89d1fd09-8779-4b1a-94fc-08da5c9e40a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2022 02:46:38.5278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR14MB5695 X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2022 02:46:41 -0000 =A0> check for double "close" of a FD (CWE-1341).=0A= =A0> check for read/write of a closed file descriptor =0A= =A0=0A= =A0These sound good but kinda non general or incomplete to me. =0A= =A0I mean, isn't the "right" thing, to disallow passing =0A= =A0a closed fd to "almost any" function? =A0=0A= =0A= =A0But I realize "almost any" is difficult to pin down. =0A= =A0 fd =3D open(); =0A= =A0 close(fd); =0A= =A0 printf("%d", fd); =A0=0A= =0A= is often ok (assuming nobody reads the output, string to int,=0A= back to close/read/write). It is any path leading to,=0A= a long list, like close, read, write, ioctl, send, recv, etc.=0A= and I don't know if "path leading to" is possible to model here, haven't lo= oked, sorry.=0A= =0A= =A0- Jay=