From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2133.outbound.protection.outlook.com [40.107.95.133]) by sourceware.org (Postfix) with ESMTPS id 15DB43857401 for ; Tue, 25 May 2021 20:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 15DB43857401 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acN6MLrvBZX6J5A05hBMOoI7Nic+3hPVtkjQdjmcHGgBYzPBssho7412bhKrsPikmnQ4ZvuZcMJpLvvEceBq7mas5Gf8J7mJdPzsXyJeOArKmtjXFdz1aAjhC32VRqZbHR11VS66JSe1VMh5g5A1XU2Es6+ICKoNUDnwSoFJskFm6LeeC42lISvTfaVCgpdKQyEBsDHxVGuGkHmNOQQcu686PlpRz6QyUAbWDCVVXR+wuINRubRRmQGlHbK9gKQNAKn0QK3N64X3E1waF0pD9vRm2qIwc6rUvwVdOvadAlnxhqAQSoopk36hoydJLV8QBADFlEnGJI8dWSv4En7shQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2NO6HLLtAZcMUHAstSKYzOnzBG7d3qweA+tv5sAIAY=; b=cM3gCHsgMHp0tji0U9xo4pqI6bpT3Ffa7WS/n8dmus4Bps82emmdyQC3jl9coryNYU689ioKHmQTYTDqKrbe2YfWRH81tfUh/jOsnxaHevRXMR6p5QsLJXeHdIbDT3WtEzr6gt9YaTP7pyi1ywz+P3nz7TXltM+oldCI3fAUi7Qzcy2h/NAN7zwiO3v9QDk+tWz/Ppxj1/wn2Ddes3hnRUj+U+6ayfltpvfHzKxss+Ih/BXUty+rShjAbIew6LRFmx4gCLvmHSvZtV9+4Kzmi+YxN31q2osO6dic+2c00hlIYGNcAqeFRDBeVikMAqkw1BcPTL+7P/T22VJhZRLyGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MWHPR21MB0798.namprd21.prod.outlook.com (2603:10b6:300:128::18) by MW4PR21MB1892.namprd21.prod.outlook.com (2603:10b6:303:78::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.2; Tue, 25 May 2021 20:49:51 +0000 Received: from MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946]) by MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946%14]) with mapi id 15.20.4195.007; Tue, 25 May 2021 20:49:51 +0000 From: Eugene Rozenfeld To: Wei Mi CC: Andi Kleen , Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHXOsu5yff2ykdMyE6mPDeCIIGFBarK/raAgBJ5I4CAEWTx0IAA/viAgAO7iWCAABqKAIAABYKggAAGX4CAADNtcIAAnAYAgABLI5A= Date: Tue, 25 May 2021 20:49:51 +0000 Message-ID: References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=25d22d89-722b-44db-b3df-1d720803b607; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-25T20:45:49Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-originating-ip: [2601:600:9700:56f0:5075:557c:152c:8592] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 417f6076-c9b9-4e5d-60fd-08d91fbea4d0 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eyUKdY1v7gAMERUBHpBhZuOsXaiw6b2nTZb33AxZ8g7Bc0lNvShvR9WTHEZFZXQ9OI4qysvI6Mf2GXze+F4XDVLcDR3abPNqQYvMNRA63BEnQFPYtHFf/VMfUO+0Rnse/2xKzhrdAaU1A5P+ZU0vfwoKIcV0uikPi/o33Jhth7CZsQ9CHLKWevGKs27rYBCCKBDhFMpcfbxLomBvG1OePfFcEIhtEcTlIwNcVGraoheY5DO1w+OJmiBiDOYgQ2Fiaz17oAyHubK/NR0EqLGkQT6LDcfy/iIN78rKWKQapSKfjP9xBdIki5toQ5XVniAn2qPAJWaHZKh7vHI9uJ0Nu8UtBFUvIShJamsfIgCYHGvgFrJ6NBpsh0O3tm9yhyMrSWCGiPRW61AA5fjnbCDDMrXAK0ZWtML2vb75RswzUdEPlEIFFQRhPoOEZdeE9y+8APNjFM8gMvufdOwlTdRTCN5cV67eea/von1j17aVN9TrPIWTGRGU+Lzof1egvJTm74GrWthQTc5ZUoBxvsljtNFGNJFC+yMo3qSBd7zLthqPe227YyZV3ys6UlNkrzPA3MEdRFXYmrA8fYOd3QtjrOMJd3u6AIs2Nvge2hc/VFl22hMJzetJ7z34krhRYlrTNoAG4KHJHQ2k5DeMOsFBEqZgowQPVY65viD21l9FZVvEvzZlPh3F+L7U+C9XXGIg6WATxvXuJxVoSX0i6Jz0boBRQ6Tm9gXTA1SzJv49Hrl6t5oEEqqXrmWvPMzx1KM+ZNpfWVymRb3TkijZcjMSxg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB0798.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8990500004)(966005)(76116006)(122000001)(66946007)(4326008)(38100700002)(6916009)(10290500003)(55016002)(7696005)(52536014)(2906002)(54906003)(478600001)(5660300002)(30864003)(53546011)(6506007)(71200400001)(186003)(86362001)(316002)(8676002)(33656002)(82950400001)(82960400001)(66556008)(64756008)(8936002)(66476007)(66446008)(83380400001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dE/pcuR7CrFKcyLqZ7DmVkYA4SLsx6zPJMPm6i08DqTLhhIkFj947da+OHT/?= =?us-ascii?Q?Mq70xNq7G14gLuWYh0ee8/lC2+//Z6OSLM9MYqc1dnGQf9iG3HwOAWVTXD8m?= =?us-ascii?Q?mbjp9JCLoeRoOYVg++Jo6HQ8WaY9bDXH9vyhS3OUZq2IauaFz+hProjVfQWS?= =?us-ascii?Q?qFt/2waQ8noUE6Q40r+S/AVwqkM7kSR1UmsF4JyRhXznj2V1fb5OKqHNRVp2?= =?us-ascii?Q?/b/iTcWd6OoUDtdUrI3cYl2D6Opiu++uKQMV0Xk2jpFI/EMmcLLUHLQTAKKu?= =?us-ascii?Q?kwrO3P3Oqe0Y6QAy/R3U5x3oBaJTtT5wE/TS+ZZ1JTm3+brxL+kWT7bK8fRr?= =?us-ascii?Q?dN5GGwEJPhjyyTydXJhh7reAYQfHR4oe7Ye/31gfA9C0jzUsJT+nv5woCH6l?= =?us-ascii?Q?ujSx4Hy/FJN/ROsHb8za5EFIGnAJ5UgmUqIVS+kHdJI3TCtbqcbM7EXZ/+L7?= =?us-ascii?Q?8CwpLc/AtOYa/RWvGWxsJOlLAhbKSxUC4exLgiqSl5x0RMfCzofGrhiTNUqt?= =?us-ascii?Q?pygu1/jDeEkzOuJYa6FJ/EfnyoaEvVBngZ+K61WsyQJF4SZ3NVL2u8VQn8Nf?= =?us-ascii?Q?GemE30KYQluICtGbaWOMH1h7jtG0/5E5Pt4YAbH9kagMqzcSZJBdorCMUj6J?= =?us-ascii?Q?Xn12Ex5we0VHuRi2jHA7Tvq1cziS5SGXPcPRse2O9U3Sr1hGCkVi/U6o4kFz?= =?us-ascii?Q?ugcw9abu8p1woACh6olgzvqcbzR4HvTkbURJUkJbZzjdpce0hS3ZEjlWnGPm?= =?us-ascii?Q?lyslsTfKssMfGO2bBwf3DMhsI6DRhJZPKAdXnMseP53f6zM1U1fOpS2VWp9Q?= =?us-ascii?Q?OqHvd55N1fKrEBnyaoZUXxcpmW7nb6A6EY9oDFF0aS9T0j+rirYauVNQT4Zg?= =?us-ascii?Q?beNnlL8FvUA3Emb9aNMqCA1+7wFFe09zDwQmQQcEUBPUVUKfLs+EFb83H/8r?= =?us-ascii?Q?EKBIm2Cv0Q/32zjTSDxtpsSbe4EbpyNM+dXyVRn1?= x-ms-exchange-antispam-messagedata-1: w73/YLHI/kDsCz03ADC49ZKpJHttvE9VmPIhWxMc2otceuuzqZ0yrKEbRDdXyVjJYtQ52P9lpM1CXYabFAOxREMbi/vCorJ3aYw5hWy6GyTfjZ8RrNPSb7Efqqd9tGHyOef3qdroZBk6/aswOIVJCMwK3zTAgBb1NdCJCZMgLRLebHyOuuNnVP8dTyjUphNxHGD644bCZfOA8lWc0BIx+KK49PebGWmbIeRm8VXWhl0Xxh9R2/eEeCqYJCsZ1P+OdD1bbDGUpxQOBLVgzzfPq63n2KF/Y2DmYxAr/EtwPaLNueC+5JczXv/LhUx5h6v/9rY0WhkxWfWYx6JOncVmsNRjqqd/TVyukzZ8eGfv1iWaXOPzR6us4Ya7I8E6AvAL87rOGQLpz+Q4UNj5rUPsQR2P x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB0798.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 417f6076-c9b9-4e5d-60fd-08d91fbea4d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 20:49:51.7913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oqnBtIc1mmQQ025goumrJeGJf1rJQTFPWkD/YQ8qbP1GjycVzu/Vua6vscMGDhCmXTczovzK/wff0e/fsgp09A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1892 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2021 20:49:57 -0000 Both are 3.0.0-9.1ubuntu1: eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list protobuf-compiler Listing... Done protobuf-compiler/bionic,now 3.0.0-9.1ubuntu1 amd64 [installed] eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list libprotobuf-dev Listing... Done libprotobuf-dev/bionic,now 3.0.0-9.1ubuntu1 amd64 [installed] -----Original Message----- From: Wei Mi =20 Sent: Tuesday, May 25, 2021 9:17 AM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang Davi= d Li ; Jan Hubicka ; gcc@gcc.gnu.org; W= enlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC It looks like some version problem about protobuf-compiler and libprotobuf-= dev. Could you check what is the installed version on your end for those tw= o packages and see if they are consistent? On my platform, they are both 3.12.4. On Tue, May 25, 2021 at 12:01 AM Eugene Rozenfeld wrote: > > That eliminates the previous error but there is a new one: > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [3/199] Building=20 > CXX object=20 > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quippe > r/perf_reader.cc.o > FAILED: CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/q= uipper/perf_reader.cc.o > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_party/= perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../third_= party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMakeF= iles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/perf_read= er.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src= /quipper/perf_reader.cc.o.d -o CMakeFiles/quipper_perf.dir/third_party/perf= _data_converter/src/quipper/perf_reader.cc.o -c ../third_party/perf_data_co= nverter/src/quipper/perf_reader.cc > ../third_party/perf_data_converter/src/quipper/perf_reader.cc: In member = function 'bool quipper::PerfReader::ReadCPUTopologyMetadata(quipper::DataRe= ader*, size_t)': > ../third_party/perf_data_converter/src/quipper/perf_reader.cc:1518:46: er= ror: no match for 'operator[]' (operand types are 'const google::protobuf::= RepeatedField' and 'int') > nrcpus =3D proto_uint32_metadata.data()[0]; > > -----Original Message----- > From: Wei Mi > Sent: Monday, May 24, 2021 8:54 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang=20 > David Li ; Jan Hubicka ;=20 > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > It isn't exposed on my platform either. Looks like a bug in perf_data_con= verter (i.e., quipper). Could you try adding #include in th= ird_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see if i= t fixes the problem? If it works, I will need to file a bug against perf_da= ta_converter. > > Thanks, > Wei. > > On Mon, May 24, 2021 at 8:33 PM Eugene Rozenfeld wrote: > > > > That fixed the error I saw before but the build still fails. The=20 > > errors start with > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja > > > > [2/217] Building CXX object > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quip > > pe > > r/huge_page_deducer.cc.o > > > > FAILED: > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quip > > pe > > r/huge_page_deducer.cc.o > > > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_part= y/perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../thir= d_party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMak= eFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/huge_pa= ge_deducer.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_conve= rter/src/quipper/huge_page_deducer.cc.o.d -o CMakeFiles/quipper_perf.dir/th= ird_party/perf_data_converter/src/quipper/huge_page_deducer.cc.o -c ../thir= d_party/perf_data_converter/src/quipper/huge_page_deducer.cc > > > > ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc: > > 14 > > 4:26: error: 'unordered_map' in namespace 'std' does not name a=20 > > template type > > > > using container =3D std::unordered_map; > > > > ^~~~~~~~~~~~~ > > > > > > > > > > > > > > > > From: Wei Mi > > Sent: Monday, May 24, 2021 8:12 PM > > To: Eugene Rozenfeld > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > Xinliang David Li ; Jan Hubicka=20 > > ; gcc@gcc.gnu.org; Wenlei He > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > Sorry, I added dependency for create_gcov but missed it for dump_gcov. = Fixed it at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%= 2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F6ca36cdc30986f13583a3aef3e277= 46ca4fc5bf6&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7C0cd9170= 8868547a3f63608d91f988b90%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6375= 75562315397315%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi= LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D9G9uGhG%2BmK35bdV4QL9BOTV= g6bFFQrVP46YdLOi3Ak4%3D&reserved=3D0. > > > > > > > > Thanks, > > > > Wei. > > > > > > > > On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld wrote: > > > > Thank you Wei. Looks like something is still missing. This time perf_da= ta.pb.h is not found. I'm getting the error below (on Ubuntu 18.04 with cma= ke 3.12.1): > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/241]=20 > > Building CXX object CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > FAILED: CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/abseil = -I../third_party/perf_data_converter/src -I../third_party/perf_data_convert= er/src/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMak= eFiles/dump_gcov_lib.dir/profile.cc.o -MF CMakeFiles/dump_gcov_lib.dir/prof= ile.cc.o.d -o CMakeFiles/dump_gcov_lib.dir/profile.cc.o -c ../profile.cc > > In file included from ../third_party/perf_data_converter/src/quipper/pe= rf_parser.h:18:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > In file included from ../profile.h:14:0, > > from ../profile.cc:5: > > ../base/macros.h:114:0: note: this is the location of the previous=20 > > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > In file included from ../third_party/perf_data_converter/src/quipper/pe= rf_parser.h:18:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > sizeof(*x)) > > > > In file included from ../profile.h:14:0, > > from ../profile.cc:5: > > ../base/macros.h:162:0: note: this is the location of the previous=20 > > definition #define arraysize(array)=20 > > (sizeof(ArraySizeHelper(array))) > > > > In file included from ../third_party/perf_data_converter/src/quipper/pe= rf_parser.h:21:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:14:10: > > fatal error: perf_data.pb.h: No such file or directory #include "perf_= data.pb.h" > > ^~~~~~~~~~~~~~~~ > > compilation terminated. > > [6/241] Building CXX object > > CMakeFiles/dump_gcov_lib.dir/symbol_map.cc.o > > ninja: build stopped: subcommand failed. > > > > Thanks, > > > > Eugene > > > > From: Wei Mi > > Sent: Saturday, May 22, 2021 9:37 AM > > To: Eugene Rozenfeld > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > Xinliang David Li ; Jan Hubicka=20 > > ; gcc@gcc.gnu.org; Wenlei He > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > It is a proto library build dependency issue which didn't expose on my = platform. I fix it at https://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F98269aee9674cc885= cc5eb1bd917eb2d12731710&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.c= om%7C0cd91708868547a3f63608d91f988b90%7C72f988bf86f141af91ab2d7cd011db47%7C= 1%7C0%7C637575562315407308%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ= IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DSL5mLhelrkeB2= 6Mg7tNaml0qjZ2OklYPwQR9btVhsqk%3D&reserved=3D0. Please try again. > > > > Thanks, > > Wei. > > > > On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld wrote: > > I tried following the instructions in "2.2 Build autofdo tool for gcc" = in https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith= ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfeld%40= microsoft.com%7C0cd91708868547a3f63608d91f988b90%7C72f988bf86f141af91ab2d7c= d011db47%7C1%7C0%7C637575562315407308%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL= jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DPY= Vm%2BHsRk%2Bfw7%2BaNgYNWn8zMnBsqcqqVSpyXQktd7sA%3D&reserved=3D0 got bui= ld failures: > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228]=20 > > Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o > > FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o > > /usr/bin/c++ -I../ -I../third_party/glog/src=20 > > -I../third_party/abseil -I../third_party/perf_data_converter/src -I../t= hird_party/perf_data_converter/src/quipper -I../util -I. -Ithird_party/glog= -std=3Dgnu++1z -MD -MT CMakeFiles/create_gcov_lib.dir/profile.cc.o -MF CMa= keFiles/create_gcov_lib.dir/profile.cc.o.d -o CMakeFiles/create_gcov_lib.di= r/profile.cc.o -c ../profile.cc In file included from ../third_party/perf_d= ata_converter/src/quipper/perf_parser.h:18:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../profile.h= :14:0, > > from ../profile.cc:5: > > ../base/macros.h:114:0: note: this is the location of the previous=20 > > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file=20 > > included from ../third_party/perf_data_converter/src/quipper/perf_parse= r.h:18:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > sizeof(*x)) In file included from ../profile.h:14:0, > > from ../profile.cc:5: > > ../base/macros.h:162:0: note: this is the location of the previous=20 > > definition #define arraysize(array) (sizeof(ArraySizeHelper(array)))=20 > > In file included from ../third_party/perf_data_converter/src/quipper/pe= rf_parser.h:21:0, > > from ../sample_reader.h:18, > > from ../profile.h:15, > > from ../profile.cc:5: > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10: > > fatal error: perf_stat.pb.h: No such file or directory #include "perf_s= tat.pb.h" > > ^~~~~~~~~~~~~~~~ > > compilation terminated. > > > > What is supposed to generate perf_stat.pb.h? > > > > Thanks, > > > > Eugene > > > > From: Wei Mi > > Sent: Monday, May 10, 2021 4:47 PM > > To: Andi Kleen > > Cc: Hongtao Yu ; Xinliang David Li=20 > > ; Jan Hubicka ;=20 > > mailto:gcc@gcc.gnu.org; Eugene Rozenfeld=20 > > ; Wenlei He=20 > > > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= hub.com%2Fgoogle%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%40microsof= t.com%7C0cd91708868547a3f63608d91f988b90%7C72f988bf86f141af91ab2d7cd011db47= %7C1%7C0%7C637575562315407308%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL= CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DuwQwWdjE%2= FL%2F2r0P%2Bdn7r5ulE8kRmPPw8A2XOQuZnUhM%3D&reserved=3D0 has been update= d. Now create_gcov/dump_gcov are added back and can be built separately. > > > > Please look at "2.2 Build autofdo tool for gcc" in=20 > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi > > th=20 > > ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfe > > ld=20 > > %40microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141 > > af > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3 > > d8 > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > C1=20 > > 000&sdata=3DEwHtN1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D&r > > es > > erved=3D0 On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen=20 > > wrote: > > > > > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > > > Andi, thanks for pointing out the perf script issues. Can you pl= ease > > > > elaborate a bit on the exact issue you have seen? We've been usi= ng > > > > specific output of perf script such as mmap, LBR and callstack e= vents > > > > filtered by process id. It works fine so far but may certainly h= it issues > > > > in the future with extended uses. > > > > > > Okay I took a look at the latest autofdo now. It seems to be=20 > > > basically a LLVM project now that depends on LLVM to even build=20 > > > with all kinds of dependency hell on some old LLVM version and other = packages. > > > > > > I guess gcc will really need a replacement that doesn't pull in=20 > > > all of LLVM if it wants to continue supporting autofdo. > > > > > > I'm myself unable to build now. > > > > > > I'm using the old version I had a git fork of and that was before=20 > > > all of this. I added a patch to make it work with the latest perf=20 > > > by ignoring increased perf_attr and unknown perf events. > > > > > > Honza please use > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F > > > gi > > > thub.com%2Fandikleen%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld > > > %4=20 > > > 0microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141 > > > af > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZs > > > b3=20 > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > > 3D=20 > > > %7C1000&sdata=3DDilu5PUjpAbA6e6d6GBd5idoKLAMMr7H5eCve%2FGdC8g%3D > > > &a > > > mp;reserved=3D0 -b perf-future > > > > > > for testing. > > > > > > -Andi > > >