From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2117.outbound.protection.outlook.com [40.107.223.117]) by sourceware.org (Postfix) with ESMTPS id 05FE43857026 for ; Tue, 25 May 2021 07:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 05FE43857026 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LgUOvTtU7jUYW7C/CEAUXEPwclE8H5pcDKj9XpXUTCBvGES14Auj4MD7+Sbv24YeZ0Tu3ToGpXj+a7Oq+xP8/vO0s7n6HB6AQFo7tOSQp1yqh73UrOi5a+Imza1D1FdQaagwGH6WpJNzb8jDbyw+jXb0giuVjMt3Fgfk9InJAiHJEvaqisPzQJDxBhpOWxkWsx5zqNTxiYGNuczX2erGiRqz4eLwz76fYjojncHyKdTAAFEUy3pTJUmd97srdp+SG+vqTxDwejBWTaI6IcTRFHYKZipzm9oZNZuh8tV+EE2/bflrMquPLuvK6YJ9JRb0fVh0s8yjDRE/JxLH7JoxUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zyokOrty+ZMDw8wMl0nfwTLe8WpwD/ppBnlmkc8ZwQk=; b=dc0hQGY9tFxRXYGG6Gwo515MGbAPEhRuOhVnmu2JofCTmnwa5cc3w6cdWAOrR51JlghIG2Ezsn2DBqA3wuuJLEXuIRhEsCPOEEwq8rbPQk7k4brWfY0JANGN3Pl/7LHylSXLnUOhzLojA8iZeQ0c65m1uwTxHObNsrzPRJn0KtZYbDBS0OUou4PJtEKyXitA1pSAyvFM7mCZ8V/jHtd9M72nwGVQF/QNEhRi8mYMcCdwS3voPnbqH6QTchlKi/uDR4miolT8YqG76+cgCVtObOg27enMn2p4v8AuiDKtIHMNZRjxiYwbplLYzEbSu7lsFdqgd4psCIDg7/ch1+Rx5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MWHPR21MB0798.namprd21.prod.outlook.com (2603:10b6:300:128::18) by MW4PR21MB2004.namprd21.prod.outlook.com (2603:10b6:303:68::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.2; Tue, 25 May 2021 07:01:07 +0000 Received: from MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946]) by MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946%14]) with mapi id 15.20.4195.006; Tue, 25 May 2021 07:01:06 +0000 From: Eugene Rozenfeld To: Wei Mi CC: Andi Kleen , Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHXOsu5yff2ykdMyE6mPDeCIIGFBarK/raAgBJ5I4CAEWTx0IAA/viAgAO7iWCAABqKAIAABYKggAAGX4CAADNtcA== Date: Tue, 25 May 2021 07:01:06 +0000 Message-ID: References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=ae3f2a3c-4d3b-44df-b18b-af9219712034; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-25T06:58:28Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-originating-ip: [2601:600:9700:56f0:5075:557c:152c:8592] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87edc997-9555-4b42-38a2-08d91f4ade74 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hAyHSw9ONBhOHRl+bE2fhVEhhczqmnxlR3pj43AGswPgR6hqys1GCh9am9AgA1UoBeWOEwA6oPXf4TTb+hPvMomcNp2M2EFyTerjiiserY3MyalU94ieLwmOlw69VgxjllX5ArddL5jK99GLg+NR/CayCG8w7UeUxtJki4vhpT9LXm8Og80rI0dNdHplAYzTTZqeqZia941kVi5wuUkAxB88tMrnbEoGrm8K07sOiQuAN369/JNoDJcPssKUuKS8TkUb0rqWZ3FKUb3KCGykZv0K6W99nj6EMr5DeLUDWPvlQdkZoe+cRHhw8povWtszqAvVdQGCKZgfkCP0ceIJ3pbw5XG9oRkwfRHLkCdr5p7AnGmBgjvT7z4JHwEpmvt72htN6ObNW4v87mC2RdvA35l6vNlw2OmF+GFNRNuW0hYY01278X8qiw8YRNmitwJmntE1yQ/iz1b4OmIRGslXzZrVi/r4wRjubqKuzn8P3ubkSc+B7Tpo0qx0sLeyM1FsWLnsvh1hF2fJK8kbCQgPF1NqumIVkAmwR/Uima8nIoGrrPuXE/xuN1S/L5AjLYbiU2o9kSCAu0xorBj3g1A2ZbhaMh/XFxWkUnk5OI/H5uHvwx7pz/pS1qNwr8HQBaF2wR1B4JVpBod/YkCOS+9F3FdH1PBTic3N79u9RPPj7eEA4BNFx9p+mfWv7FPoEl2/ns188ZvqOQxFIOsgiEtHVP7xXHdo/L3eRFvt5twFq7g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB0798.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(966005)(38100700002)(30864003)(52536014)(5660300002)(122000001)(86362001)(66556008)(2906002)(33656002)(64756008)(55016002)(66446008)(66946007)(66476007)(76116006)(83380400001)(82950400001)(8990500004)(8936002)(71200400001)(7696005)(6916009)(9686003)(8676002)(4326008)(53546011)(6506007)(10290500003)(478600001)(186003)(316002)(54906003)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9AJRfD9wgw5N9HUWD6w+Y/XZJ7kvNZ9bIv9TJwO4rP9TUOgYc4yQE3NviasO?= =?us-ascii?Q?KxAp+ilJ7OIrXg2gcbJVQt6AdpUI32gDcmqA0lNzCUMW8O7ZeGgBnWd04DwC?= =?us-ascii?Q?ZQhsuc7CRhle008d7F6/YUhmNxl+pjygNG6SKlFe/pJNM2fOCua7I0A9eIlk?= =?us-ascii?Q?wSMaHAibrX2UXNe9aVHCbbqFuQ1krFFgU7Mot5lE6XNFGFQ1BgviBUL2kvmc?= =?us-ascii?Q?a/1lg3KwdKEDYiWIAljOo2szHfmZ9AhQ4ul+g0RnM1V9SO28bJ4wolTYDam7?= =?us-ascii?Q?6S4G//uexWSezG+AkvGSAx7XTrcUDvZP+Ky89RhfSv9YkLXaSI1X15u4eMWk?= =?us-ascii?Q?mTE+0WnsMZGqd9CMyVzdXb/WGHL/gRjafY2Q4+FTO7Yt6LWeiTDqJEIT+AsV?= =?us-ascii?Q?fWWHrBgnzYGXe41s0Vp77gdm5odFqUvxz7u2ciOUBcRsCv4lePkCiCdXTHh8?= =?us-ascii?Q?P+3sMExNNrkeWntnUk4JNEkJ33QrJTIef3Z6oGWF2iFANSS1S/Sa3jW5JEe2?= =?us-ascii?Q?7X2fQMQEtMDUU8B/XB0zQEb4k/lJkbORYTDlmvqflRt+yxhT8lT3JASP7uzh?= =?us-ascii?Q?42I2y3IS30f2s8Yqh7zudsLtPNG5mcO0Q2fRE02FGvuRtQZLZsmsA0QSI+w0?= =?us-ascii?Q?11S3lGdy8ox0sLG5hjWXHBWY5PXA7gxPjca7Lg/s1XLVvX/ZORfIHiXK+BR/?= =?us-ascii?Q?txM7xYkK5ZdpRiabvPtIJPdZX5BDpa7M5fBqkNf79IubXIRAEO48sJxRy9oB?= =?us-ascii?Q?hwEH7d3nsDU1T6c7UtOfKgY2Zhi/YvmWcAGtu3UrlpYhu61ZgckjFNQ1eWSU?= =?us-ascii?Q?pHYL1yoXxoy2cNkQ+yX1oSM8PQrVvUSvaY5vybz4N/lQzdySAT8OzMhlBKuj?= =?us-ascii?Q?Pm66RFd9QyPKfncbf5M3utKob9W/euBMtdP3IaTBVGnK+QmpXxBoAcAuHdSm?= =?us-ascii?Q?AJ3Erbjp7w26U+sftVsW0MGExXDR5WEjVvVVWnyE?= x-ms-exchange-antispam-messagedata-1: LxE5/lsSAa+8bygUMA4AmbRNMzXURt1nlvFSOYhnkMiv5Oh2RTKEuNVVfUVxOqmqQo4AWc9VRHuzfEMcaCsxsqgP0t/MnjyXjbhYL5mb7BD4EraL8iXSW4gXEaxJVwMvZGAb1VG8vdBUewBsujf6uAuHND+ZlJ4FGrMNYyh8sfoJ/x2Z0FZ1Kx1sEA03o+Do/Slr6z33IOYdo0WWJW8oZ3sHm2aqY/VxLsq55Q6LhRulc86NrJL0VkRdB2evU8AdBV5z5iiuJiNs/hPbA6/eN5CzFM1I2mtG4o0xibIBMZzCYGBNGVcdYQJCnYv5xfeOmaJcWOmx0rry4pWSxOKMPh238dzN4Rt6Cgn7XEoB5fZzOkQl8v1kzG9nm0celnaligEp066AMcIzOEbC9JeSJXAY x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB0798.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87edc997-9555-4b42-38a2-08d91f4ade74 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 07:01:06.8536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +gOuFN4HGQJub1ObFYogXLP+6GrIAzb+gNwhJjiW3Vi94j7MpzNskjfgbruIKDdLgCYK/2mGi4h6q8p+8z16+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB2004 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_LINEPADDING, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2021 07:01:15 -0000 That eliminates the previous error but there is a new one: eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [3/199] Building CXX object CMakeFiles/quipper_perf.dir/third_party/perf_da= ta_converter/src/quipper/perf_reader.cc.o FAILED: CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/qui= pper/perf_reader.cc.o=20 /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_party/pe= rf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../third_pa= rty/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMakeFil= es/quipper_perf.dir/third_party/perf_data_converter/src/quipper/perf_reader= .cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/q= uipper/perf_reader.cc.o.d -o CMakeFiles/quipper_perf.dir/third_party/perf_d= ata_converter/src/quipper/perf_reader.cc.o -c ../third_party/perf_data_conv= erter/src/quipper/perf_reader.cc ../third_party/perf_data_converter/src/quipper/perf_reader.cc: In member fu= nction 'bool quipper::PerfReader::ReadCPUTopologyMetadata(quipper::DataRead= er*, size_t)': ../third_party/perf_data_converter/src/quipper/perf_reader.cc:1518:46: erro= r: no match for 'operator[]' (operand types are 'const google::protobuf::Re= peatedField' and 'int') nrcpus =3D proto_uint32_metadata.data()[0]; -----Original Message----- From: Wei Mi =20 Sent: Monday, May 24, 2021 8:54 PM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang Davi= d Li ; Jan Hubicka ; gcc@gcc.gnu.org; W= enlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC It isn't exposed on my platform either. Looks like a bug in perf_data_conve= rter (i.e., quipper). Could you try adding #include in thir= d_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see if it = fixes the problem? If it works, I will need to file a bug against perf_data= _converter. Thanks, Wei. On Mon, May 24, 2021 at 8:33 PM Eugene Rozenfeld wrote: > > That fixed the error I saw before but the build still fails. The=20 > errors start with > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja > > [2/217] Building CXX object=20 > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quippe > r/huge_page_deducer.cc.o > > FAILED:=20 > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quippe > r/huge_page_deducer.cc.o > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_party/= perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../third_= party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMakeF= iles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/huge_page= _deducer.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_convert= er/src/quipper/huge_page_deducer.cc.o.d -o CMakeFiles/quipper_perf.dir/thir= d_party/perf_data_converter/src/quipper/huge_page_deducer.cc.o -c ../third_= party/perf_data_converter/src/quipper/huge_page_deducer.cc > > ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc:14 > 4:26: error: 'unordered_map' in namespace 'std' does not name a=20 > template type > > using container =3D std::unordered_map; > > ^~~~~~~~~~~~~ > > > > > > > > From: Wei Mi > Sent: Monday, May 24, 2021 8:12 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang=20 > David Li ; Jan Hubicka ;=20 > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > Sorry, I added dependency for create_gcov but missed it for dump_gcov. Fi= xed it at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F= %2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F6ca36cdc30986f13583a3aef3e27746= ca4fc5bf6&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7C1bcb2fda4= fce4f173c1808d91f30d1fc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637575= 116816277204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLC= JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DhwJ%2BG64Yw%2BEGMAV7kzilOjA= OkHoOv3TQpdqkzcHGO%2FM%3D&reserved=3D0. > > > > Thanks, > > Wei. > > > > On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld wrote: > > Thank you Wei. Looks like something is still missing. This time perf_data= .pb.h is not found. I'm getting the error below (on Ubuntu 18.04 with cmake= 3.12.1): > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/241] Building=20 > CXX object CMakeFiles/dump_gcov_lib.dir/profile.cc.o > FAILED: CMakeFiles/dump_gcov_lib.dir/profile.cc.o > /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/abseil -I= ../third_party/perf_data_converter/src -I../third_party/perf_data_converter= /src/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMakeF= iles/dump_gcov_lib.dir/profile.cc.o -MF CMakeFiles/dump_gcov_lib.dir/profil= e.cc.o.d -o CMakeFiles/dump_gcov_lib.dir/profile.cc.o -c ../profile.cc > In file included from ../third_party/perf_data_converter/src/quipper/perf= _parser.h:18:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0:=20 > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define=20 > DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > In file included from ../profile.h:14:0, > from ../profile.cc:5: > ../base/macros.h:114:0: note: this is the location of the previous=20 > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > In file included from ../third_party/perf_data_converter/src/quipper/perf= _parser.h:18:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0:=20 > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) /=20 > sizeof(*x)) > > In file included from ../profile.h:14:0, > from ../profile.cc:5: > ../base/macros.h:162:0: note: this is the location of the previous=20 > definition #define arraysize(array) (sizeof(ArraySizeHelper(array))) > > In file included from ../third_party/perf_data_converter/src/quipper/perf= _parser.h:21:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/compat/proto.h:14:10:=20 > fatal error: perf_data.pb.h: No such file or directory #include "perf_da= ta.pb.h" > ^~~~~~~~~~~~~~~~ > compilation terminated. > [6/241] Building CXX object=20 > CMakeFiles/dump_gcov_lib.dir/symbol_map.cc.o > ninja: build stopped: subcommand failed. > > Thanks, > > Eugene > > From: Wei Mi > Sent: Saturday, May 22, 2021 9:37 AM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang=20 > David Li ; Jan Hubicka ;=20 > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > It is a proto library build dependency issue which didn't expose on my pl= atform. I fix it at https://nam06.safelinks.protection.outlook.com/?url=3Dh= ttps%3A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F98269aee9674cc885cc5e= b1bd917eb2d12731710&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7= C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C= 0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi= V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DPikMs8RtJHBsTUqdj= CVWAKNSC5Rls%2B71pSEhq4z0XsM%3D&reserved=3D0. Please try again. > > Thanks, > Wei. > > On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld wrote: > I tried following the instructions in "2.2 Build autofdo tool for gcc" in= https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfeld%40mi= crosoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141af91ab2d7cd0= 11db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA= wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DEwHt= N1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D&reserved=3D0 got build fai= lures: > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228] Building=20 > CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o > FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o > /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/abseil=20 > -I../third_party/perf_data_converter/src -I../third_party/perf_data_conve= rter/src/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CM= akeFiles/create_gcov_lib.dir/profile.cc.o -MF CMakeFiles/create_gcov_lib.di= r/profile.cc.o.d -o CMakeFiles/create_gcov_lib.dir/profile.cc.o -c ../profi= le.cc In file included from ../third_party/perf_data_converter/src/quipper/= perf_parser.h:18:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0:=20 > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define=20 > DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../profile.h:1= 4:0, > from ../profile.cc:5: > ../base/macros.h:114:0: note: this is the location of the previous=20 > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file=20 > included from ../third_party/perf_data_converter/src/quipper/perf_parser.= h:18:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0:=20 > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) /=20 > sizeof(*x)) In file included from ../profile.h:14:0, > from ../profile.cc:5: > ../base/macros.h:162:0: note: this is the location of the previous=20 > definition #define arraysize(array) (sizeof(ArraySizeHelper(array)))=20 > In file included from ../third_party/perf_data_converter/src/quipper/perf= _parser.h:21:0, > from ../sample_reader.h:18, > from ../profile.h:15, > from ../profile.cc:5: > ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10:=20 > fatal error: perf_stat.pb.h: No such file or directory #include "perf_sta= t.pb.h" > ^~~~~~~~~~~~~~~~ > compilation terminated. > > What is supposed to generate perf_stat.pb.h? > > Thanks, > > Eugene > > From: Wei Mi > Sent: Monday, May 10, 2021 4:47 PM > To: Andi Kleen > Cc: Hongtao Yu ; Xinliang David Li=20 > ; Jan Hubicka ;=20 > mailto:gcc@gcc.gnu.org; Eugene Rozenfeld=20 > ; Wenlei He=20 > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fgoogle%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.= com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141af91ab2d7cd011db47%7= C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ= QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3Da9gGf48MYY2j= zbSucOAlhsmdLuYt%2BcM8V5hvGoA39Ms%3D&reserved=3D0 has been updated. Now= create_gcov/dump_gcov are added back and can be built separately. > > Please look at "2.2 Build autofdo tool for gcc" in=20 > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfeld > %40microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141af > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 > 000&sdata=3DEwHtN1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D&res > erved=3D0 On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen=20 > wrote: > > > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > > Andi, thanks for pointing out the perf script issues. Can you plea= se > > > elaborate a bit on the exact issue you have seen? We've been using > > > specific output of perf script such as mmap, LBR and callstack eve= nts > > > filtered by process id. It works fine so far but may certainly hit= issues > > > in the future with extended uses. > > > > Okay I took a look at the latest autofdo now. It seems to be=20 > > basically a LLVM project now that depends on LLVM to even build with=20 > > all kinds of dependency hell on some old LLVM version and other package= s. > > > > I guess gcc will really need a replacement that doesn't pull in all=20 > > of LLVM if it wants to continue supporting autofdo. > > > > I'm myself unable to build now. > > > > I'm using the old version I had a git fork of and that was before=20 > > all of this. I added a patch to make it work with the latest perf by=20 > > ignoring increased perf_attr and unknown perf events. > > > > Honza please use > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi > > thub.com%2Fandikleen%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%4 > > 0microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f141af > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZsb3 > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > > %7C1000&sdata=3DDilu5PUjpAbA6e6d6GBd5idoKLAMMr7H5eCve%2FGdC8g%3D&a > > mp;reserved=3D0 -b perf-future > > > > for testing. > > > > -Andi > >