From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2116.outbound.protection.outlook.com [40.107.93.116]) by sourceware.org (Postfix) with ESMTPS id B7FE938515FC for ; Wed, 26 May 2021 23:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B7FE938515FC ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAfH46K6TtIWEaTxg8aPAg0CjfBAo/C54WLaBljANbXp1uYbp2Eqhuwt84THx3rM+J7Df+Sbwb+HDDdENrrDePl6eeNo4Hm7Mp/O4gjgsF1my9PBGBy3h2jyfa7bo4slWXvmyowjEMagHIKtdemBhGg+x9+WsoYciwQfJkS7X8aTQqJiYgL5K1+mShy3pz/ZF4q+Oigze1e8GM6l3Ri6mtrzqm73KzY5u6vNC2VfUNF/8cqgLtGovdECsxirucZVLBx0fXcCmOrWuJpaoxoEnZxxE+4T6gGn9XacDoMWIRns3/SJJHKG/V2jyc+8awmEGMCWfxqoP5IR7RPNw0knxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TggU2tLb0B7vONdgk+5Qj/tIN1XV9KuuE6WDuMxISOU=; b=ZPH0LJZWRDVq5Q5H6RAoOWcgZq/iB1nzXk9M5dBZ4ci8/l0lJr2zoaeedtD8NZKrtLyPiU741LRV61KW2X+N7x1IoyTZoClpTHSRSvpPYlpM67OEeXr461BahRnL6tJ/fi7LBTZz1/nDUdEH0Y4+RwobNkFKcElBaHC4vdHaXVtB9t6bF0hYKr/m07KcgmxN2cZZddQdahRrSiG9IcWL276rEx2e1GQnQ38tSW9MX+z7j9u2g/Xesv5MCVzhhSIn8nqy2KCWWfmNBRSKB0wSE0xRIxTd2RrzVDyAEiHGGEfSBcE7UXEh+6l8bAr3W9RUXfMVJp/nQ4Tr2fbGRmxwJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MWHPR21MB0798.namprd21.prod.outlook.com (2603:10b6:300:128::18) by MWHPR21MB0142.namprd21.prod.outlook.com (2603:10b6:300:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.2; Wed, 26 May 2021 23:39:57 +0000 Received: from MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946]) by MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946%14]) with mapi id 15.20.4195.008; Wed, 26 May 2021 23:39:57 +0000 From: Eugene Rozenfeld To: Wei Mi CC: Andi Kleen , Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHXOsu5yff2ykdMyE6mPDeCIIGFBarK/raAgBJ5I4CAEWTx0IAA/viAgAO7iWCAABqKAIAABYKggAAGX4CAADNtcIAAnAYAgABLI5CAAGp1gIABV7XA Date: Wed, 26 May 2021 23:39:56 +0000 Message-ID: References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8f6f3675-7006-4bd8-8956-bb0cb78ffdeb; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-26T23:37:01Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-originating-ip: [2601:600:9700:56f0:359c:5f18:277b:30f2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44fe95e7-d2ad-4874-4b3c-08d9209f91f3 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LPkS1fF+Bz8LTOS1tKo2CylASaItpInfJe3uATzO6ECVBJSSBnOTVT6y4R2ZpFgRb7glF6iS0ZrAFLCf1ShVmI6iYg6gV9x5gy+ZSU/i4DWruQv3YxE7ql73NG4IcSsvubGBsLHbqNvEz6OX6Rd7YxrrZ+2bkRV9SD1uYPBuDM1ISxScctwZAj5Z8UzGXB0qZdHcMhW+qKivlf8cI6h/0/xxLJm8OzNasaAor8xxvYJ/BV1eQ+RUKl6zfjvnVXK5hXAFVnmkzm9sNHy6+qwfz3ypPJFqw8GYG4Ysh9DXjluvtxk4AxnswOQYPdN2rYBXi7x1iK/1/64VLgjmGzGxKY1Na8277670Zdk/FYA/Vn9kxgOvtfsxd6FUd01GA5y+0dpspRLPNoDEyfJMv5n/9E61dEt+0LCDMfpakZ/cA72IlRUk5UCV7oqmGw4YsuH/Nx6QSW9QWRQ9P0NwCi3rEQn+X5fTAnMaB07JJPQ7Z4wbIjYA5BXWX5lxVMANQ7LrKF0AM1CtAZElN00I/dECJIIHn78Ulpe7omtv4SpUMtzca+oM0xVLBxnSEzPX0uaJY9Q4m+Nq80Nl/spHh9ZJtrJdbtpfHCjXHYcDHpTivrX62N2SabOC7JamFI6xFNOYWre5IrTQRIa4/4wx0b7gaDRyYxjmNqJBgBX+/A9Qxxr/2s8h/4UnpPOB5KYbb90/dHpH9PxyHYxQTSHPP0eF7yAI1S5dIcDc7bNg0f/XpC9VkxoLgp8rKZXpE43DLk3Jsr8xexFCtwWwT2aujLCz/g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB0798.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(122000001)(7696005)(6506007)(478600001)(53546011)(2906002)(8990500004)(71200400001)(316002)(66946007)(9686003)(33656002)(52536014)(66556008)(82950400001)(186003)(54906003)(82960400001)(10290500003)(966005)(64756008)(86362001)(4326008)(55016002)(66476007)(5660300002)(30864003)(8676002)(83380400001)(8936002)(76116006)(6916009)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?igqkYKDdi/T7wv4SA0WaZLwJTNUfaqY+dh8N/4k2wjG1XviHbjgH44Y2ssLz?= =?us-ascii?Q?9iS1UsoYee9r21Ow1py6VfTCxhIgZRq74V6fx6aEyZgzkRQHBH0iUhhUR0vs?= =?us-ascii?Q?PTD93Zc+ELHZlD8sVe24IA/B8rgUTqJIJ2BcH5AELmmKESeFORJx2K1AMOSx?= =?us-ascii?Q?FEgAqTYaYX3Kx6wXuvwrU8bMo6h2xSdFlrzARjPSz5goh7SXt+J0L2vjn319?= =?us-ascii?Q?u5lTEM81ruLmQvyJ7V9RoPBdbcNn3vccG7cvwXr1jSVOtxiN/EGHmVxTIBd+?= =?us-ascii?Q?rLLBZYfYLiuSTGjCx08b9XLVxzI7n9p/PmTzpaKtDIqnVyNt+V8Hn90zMjzb?= =?us-ascii?Q?ULC23vW7Q+slxCtkBqhwrp+1Vkg+tKnpbJwi6MT07srIMDYIxhdJ4Id/Dul1?= =?us-ascii?Q?cXgeA4+rj+VtF+1HkQEdJz0pd/4QlIrtqhxdTZA5UGGHHIXWWcszg/sNsUiu?= =?us-ascii?Q?PCNhz3PnESc+u+uVGuU5ybfKTWkCzY4xzMG21RDgWA4pILaRhYq/otb4Wco7?= =?us-ascii?Q?oi3cXpFAx5oAGcCjs+f/o2NSg0VP4VEVe93XFRl6/p9oThhCgxs8qfkYTbpY?= =?us-ascii?Q?/ic0grt1fxhvFlvWMrXzWl5HFjaluh246+IhyzJ5wvz+GEPYEE50tlEXzfRw?= =?us-ascii?Q?bAM/wvWXV1lff1x+PtRlAKmJ2lR9vRgRVm4duGBE0xTNlV6GRqiq5nBIAKPZ?= =?us-ascii?Q?YwqQkzp24wgpczd5SlLVf1W1heQB2xwGYbZWfwHFjaIOepEVIB48eZZHqMri?= =?us-ascii?Q?nLqtjz/12AzmZvf3Egg5c/h+prnh3+8Pca9FY/rW6sTrOLLnvmatbfN01IlK?= =?us-ascii?Q?XyZghi8F0aJ9Rfx8IdfCnHxC4AQl9BGTOsJ9TUg00NQF1c+jr7h70dk1Ibbp?= =?us-ascii?Q?fGUDcq+9yJOHZ7mmg87sqI1Hb3lk1dU14zm+A3+dwBOSVL4+ovy1KITKGFMG?= =?us-ascii?Q?YJ4CTHtaMPYO48PkuMchwnasD9V/ki8/dEdb+/fM?= x-ms-exchange-antispam-messagedata-1: g0Naf8NCg9LNdE3rtte9ITnqKVFMfeU/M/MOOuaV9UbKCXWBdQGdXxCzWjwsMLhc/S/052PzAG7FeBg0JsM7jYoLxbvEure8F8geH6LzbiZ5b4b8FNLy2t+mJLuBT5GY42SuF6wRevtMautdkzsv7+tkn0WYUg0caoLJHzhAoVuAoWBrsii5uO8ETwobdxQHchGhWnD+T1Leui7EXH2Ewoy442DhrR7o3wegLlrWuIfdzRi6R4MgS7E8gBKZG/dyK0PqxF2oalb7LYyH7M7uz+dNLSJV/6xijCukGRNVsWQM2NOMn7/JvggpltfyI1EURkRRSD8Bf+rDHfF+VAotDbAHaFwO/xYdvVgUIfuji4xzYyeTEQe1O9YheqqsD+E1IytAWc3VWxau7fLEhQCnJj1H x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB0798.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44fe95e7-d2ad-4874-4b3c-08d9209f91f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2021 23:39:56.8056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mFOhtdG99yabyR0yokuvZsxyyeIb6R+Ojj7C+3jqtXtF/f0brSecGRuPNHxCGpO5sQ7eL8l1AUO/SWFkjn4vdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0142 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 23:40:03 -0000 3.0.0 is the latest supported version on Ubuntu 18.04. I verified that the = build works on Ubuntu 20.04 with protobuf-compiler and libprotobuf-dev ver= sion 3.6.1.3. Eugene -----Original Message----- From: Wei Mi =20 Sent: Tuesday, May 25, 2021 8:07 PM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang Davi= d Li ; Jan Hubicka ; gcc@gcc.gnu.org; W= enlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC I checked the source of protobuf 3.0.0 and it didn't contain the operator[]= in RepeatedField. Need to install a newer version of protobuf. Thanks, Wei. On Tue, May 25, 2021 at 1:49 PM Eugene Rozenfeld wrote: > > Both are 3.0.0-9.1ubuntu1: > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list=20 > protobuf-compiler Listing... Done protobuf-compiler/bionic,now=20 > 3.0.0-9.1ubuntu1 amd64 [installed]=20 > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list=20 > libprotobuf-dev Listing... Done libprotobuf-dev/bionic,now=20 > 3.0.0-9.1ubuntu1 amd64 [installed] > > -----Original Message----- > From: Wei Mi > Sent: Tuesday, May 25, 2021 9:17 AM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang=20 > David Li ; Jan Hubicka ;=20 > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > It looks like some version problem about protobuf-compiler and libprotobu= f-dev. Could you check what is the installed version on your end for those = two packages and see if they are consistent? > > On my platform, they are both 3.12.4. > > On Tue, May 25, 2021 at 12:01 AM Eugene Rozenfeld wrote: > > > > That eliminates the previous error but there is a new one: > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [3/199]=20 > > Building CXX object=20 > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quip > > pe > > r/perf_reader.cc.o > > FAILED: CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src= /quipper/perf_reader.cc.o > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_part= y/perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../thir= d_party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMak= eFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/perf_re= ader.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/s= rc/quipper/perf_reader.cc.o.d -o CMakeFiles/quipper_perf.dir/third_party/pe= rf_data_converter/src/quipper/perf_reader.cc.o -c ../third_party/perf_data_= converter/src/quipper/perf_reader.cc > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc: In membe= r function 'bool quipper::PerfReader::ReadCPUTopologyMetadata(quipper::Data= Reader*, size_t)': > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc:1518:46: = error: no match for 'operator[]' (operand types are 'const google::protobuf= ::RepeatedField' and 'int') > > nrcpus =3D proto_uint32_metadata.data()[0]; > > > > -----Original Message----- > > From: Wei Mi > > Sent: Monday, May 24, 2021 8:54 PM > > To: Eugene Rozenfeld > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > Xinliang David Li ; Jan Hubicka=20 > > ; gcc@gcc.gnu.org; Wenlei He > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > It isn't exposed on my platform either. Looks like a bug in perf_data_c= onverter (i.e., quipper). Could you try adding #include in = third_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see if= it fixes the problem? If it works, I will need to file a bug against perf_= data_converter. > > > > Thanks, > > Wei. > > > > On Mon, May 24, 2021 at 8:33 PM Eugene Rozenfeld wrote: > > > > > > That fixed the error I saw before but the build still fails. The=20 > > > errors start with > > > > > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja > > > > > > [2/217] Building CXX object > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/qu > > > ip > > > pe > > > r/huge_page_deducer.cc.o > > > > > > FAILED: > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/qu > > > ip > > > pe > > > r/huge_page_deducer.cc.o > > > > > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_pa= rty/perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../th= ird_party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CM= akeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/huge_= page_deducer.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_con= verter/src/quipper/huge_page_deducer.cc.o.d -o CMakeFiles/quipper_perf.dir/= third_party/perf_data_converter/src/quipper/huge_page_deducer.cc.o -c ../th= ird_party/perf_data_converter/src/quipper/huge_page_deducer.cc > > > > > > ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc: > > > 14 > > > 4:26: error: 'unordered_map' in namespace 'std' does not name a=20 > > > template type > > > > > > using container =3D std::unordered_map; > > > > > > ^~~~~~~~~~~~~ > > > > > > > > > > > > > > > > > > > > > > > > From: Wei Mi > > > Sent: Monday, May 24, 2021 8:12 PM > > > To: Eugene Rozenfeld > > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > > Xinliang David Li ; Jan Hubicka=20 > > > ; gcc@gcc.gnu.org; Wenlei He > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > > > > > Sorry, I added dependency for create_gcov but missed it for dump_gcov= . Fixed it at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3= A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F6ca36cdc30986f13583a3aef3e2= 7746ca4fc5bf6&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7Cc1341= 4d95f7a4b50bd9108d91ff35765%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63= 7575952275806806%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz= IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DJnEc%2FRvRNehbDEh2NhqjO= NnPJJDEaoFEqPCet%2BhByXU%3D&reserved=3D0. > > > > > > > > > > > > Thanks, > > > > > > Wei. > > > > > > > > > > > > On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld wrote: > > > > > > Thank you Wei. Looks like something is still missing. This time perf_= data.pb.h is not found. I'm getting the error below (on Ubuntu 18.04 with c= make 3.12.1): > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/241]=20 > > > Building CXX object CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > FAILED: CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/absei= l -I../third_party/perf_data_converter/src -I../third_party/perf_data_conve= rter/src/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CM= akeFiles/dump_gcov_lib.dir/profile.cc.o -MF CMakeFiles/dump_gcov_lib.dir/pr= ofile.cc.o.d -o CMakeFiles/dump_gcov_lib.dir/profile.cc.o -c ../profile.cc > > > In file included from ../third_party/perf_data_converter/src/quipper/= perf_parser.h:18:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > > > In file included from ../profile.h:14:0, > > > from ../profile.cc:5: > > > ../base/macros.h:114:0: note: this is the location of the previous=20 > > > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > > > In file included from ../third_party/perf_data_converter/src/quipper/= perf_parser.h:18:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > > sizeof(*x)) > > > > > > In file included from ../profile.h:14:0, > > > from ../profile.cc:5: > > > ../base/macros.h:162:0: note: this is the location of the previous=20 > > > definition #define arraysize(array) > > > (sizeof(ArraySizeHelper(array))) > > > > > > In file included from ../third_party/perf_data_converter/src/quipper/= perf_parser.h:21:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:14:10: > > > fatal error: perf_data.pb.h: No such file or directory #include "per= f_data.pb.h" > > > ^~~~~~~~~~~~~~~~ > > > compilation terminated. > > > [6/241] Building CXX object > > > CMakeFiles/dump_gcov_lib.dir/symbol_map.cc.o > > > ninja: build stopped: subcommand failed. > > > > > > Thanks, > > > > > > Eugene > > > > > > From: Wei Mi > > > Sent: Saturday, May 22, 2021 9:37 AM > > > To: Eugene Rozenfeld > > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > > Xinliang David Li ; Jan Hubicka=20 > > > ; gcc@gcc.gnu.org; Wenlei He > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > It is a proto library build dependency issue which didn't expose on m= y platform. I fix it at https://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F98269aee9674cc885= cc5eb1bd917eb2d12731710&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.c= om%7Cc13414d95f7a4b50bd9108d91ff35765%7C72f988bf86f141af91ab2d7cd011db47%7C= 1%7C0%7C637575952275806806%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ= IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3Dg3hPIoq%2Bbkl= BPFZOFdtXhcAtAtky7W4KyjOdL6S%2F7bI%3D&reserved=3D0. Please try again. > > > > > > Thanks, > > > Wei. > > > > > > On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld wrote: > > > I tried following the instructions in "2.2 Build autofdo tool for gcc= " in https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi= thub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfeld%= 40microsoft.com%7Cc13414d95f7a4b50bd9108d91ff35765%7C72f988bf86f141af91ab2d= 7cd011db47%7C1%7C0%7C637575952275816803%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= mkBZF667WnlvaktNmI9VInqfLLKbIu1B41g%2BaqUi03w%3D&reserved=3D0 got build= failures: > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228]=20 > > > Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > /usr/bin/c++ -I../ -I../third_party/glog/src=20 > > > -I../third_party/abseil -I../third_party/perf_data_converter/src -I..= /third_party/perf_data_converter/src/quipper -I../util -I. -Ithird_party/gl= og -std=3Dgnu++1z -MD -MT CMakeFiles/create_gcov_lib.dir/profile.cc.o -MF C= MakeFiles/create_gcov_lib.dir/profile.cc.o.d -o CMakeFiles/create_gcov_lib.= dir/profile.cc.o -c ../profile.cc In file included from ../third_party/perf= _data_converter/src/quipper/perf_parser.h:18:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../profile= .h:14:0, > > > from ../profile.cc:5: > > > ../base/macros.h:114:0: note: this is the location of the previous=20 > > > definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file=20 > > > included from ../third_party/perf_data_converter/src/quipper/perf_par= ser.h:18:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > > sizeof(*x)) In file included from ../profile.h:14:0, > > > from ../profile.cc:5: > > > ../base/macros.h:162:0: note: this is the location of the previous=20 > > > definition #define arraysize(array)=20 > > > (sizeof(ArraySizeHelper(array))) In file included from ../third_party= /perf_data_converter/src/quipper/perf_parser.h:21:0, > > > from ../sample_reader.h:18, > > > from ../profile.h:15, > > > from ../profile.cc:5: > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10: > > > fatal error: perf_stat.pb.h: No such file or directory #include "perf= _stat.pb.h" > > > ^~~~~~~~~~~~~~~~ > > > compilation terminated. > > > > > > What is supposed to generate perf_stat.pb.h? > > > > > > Thanks, > > > > > > Eugene > > > > > > From: Wei Mi > > > Sent: Monday, May 10, 2021 4:47 PM > > > To: Andi Kleen > > > Cc: Hongtao Yu ; Xinliang David Li=20 > > > ; Jan Hubicka ;=20 > > > mailto:gcc@gcc.gnu.org; Eugene Rozenfeld=20 > > > ; Wenlei He=20 > > > > > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= ithub.com%2Fgoogle%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%40micros= oft.com%7Cc13414d95f7a4b50bd9108d91ff35765%7C72f988bf86f141af91ab2d7cd011db= 47%7C1%7C0%7C637575952275816803%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA= iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DTHWF6m1l= y3ZHjfqLCSDummsISA2bItUWVyHmdLIvxmU%3D&reserved=3D0 has been updated. N= ow create_gcov/dump_gcov are added back and can be built separately. > > > > > > Please look at "2.2 Build autofdo tool for gcc" in=20 > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F > > > gi > > > th > > > ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozen > > > fe > > > ld > > > %40microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f1 > > > 41 > > > af > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbGZs > > > b3 > > > d8 > > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > > > %7 > > > C1 > > > 000&sdata=3DEwHtN1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D& > > > ;r > > > es > > > erved=3D0 On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen=20 > > > wrote: > > > > > > > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > > > > Andi, thanks for pointing out the perf script issues. Can you = please > > > > > elaborate a bit on the exact issue you have seen? We've been u= sing > > > > > specific output of perf script such as mmap, LBR and callstack= events > > > > > filtered by process id. It works fine so far but may certainly= hit issues > > > > > in the future with extended uses. > > > > > > > > Okay I took a look at the latest autofdo now. It seems to be=20 > > > > basically a LLVM project now that depends on LLVM to even build=20 > > > > with all kinds of dependency hell on some old LLVM version and othe= r packages. > > > > > > > > I guess gcc will really need a replacement that doesn't pull in=20 > > > > all of LLVM if it wants to continue supporting autofdo. > > > > > > > > I'm myself unable to build now. > > > > > > > > I'm using the old version I had a git fork of and that was=20 > > > > before all of this. I added a patch to make it work with the=20 > > > > latest perf by ignoring increased perf_attr and unknown perf events= . > > > > > > > > Honza please use > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F% > > > > 2F > > > > gi > > > > thub.com%2Fandikleen%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfe > > > > ld > > > > %4 > > > > 0microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86f1 > > > > 41 > > > > af > > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbG > > > > Zs > > > > b3 > > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > > > > 0% > > > > 3D > > > > %7C1000&sdata=3DDilu5PUjpAbA6e6d6GBd5idoKLAMMr7H5eCve%2FGdC8g% > > > > 3D > > > > &a > > > > mp;reserved=3D0 -b perf-future > > > > > > > > for testing. > > > > > > > > -Andi > > > >