From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2136.outbound.protection.outlook.com [40.107.94.136]) by sourceware.org (Postfix) with ESMTPS id 9C6333857831 for ; Sat, 12 Jun 2021 01:14:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C6333857831 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8BmZys3rrf1JfuB9ObT1u5yQX40ilsoR2m2MqDmqFpT1UHJSC2e16hQuKPY/YuTm2Wbcq5HwV41yLN3UnFifk2P0libeq6yjO7baB3yex++5fpSiQw/VDU4ufZwp82APUBSVfdInpYEogfynEbdGsVMFkLqHdvtgIv5evr9Ocn5aKN8+rIH+qByVqQM93ueGleIzANCwxU3dqrzYNaTRHiYyghIvPdcJrHoHhsHbY4iAaJCMMuR+2huQlAWfvS+GpweQyfHe7bIsLkkihhplxwdquAiWKQrrRMy+HJPmFEUgBeFY0S87CXziYh6PZwJBpyFdw/c+iQQOwHEufSlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lj0UHiZfz+sRPGvaB862UeZy+wwt28lQXZ9YgmQlfXk=; b=X51DM87KIVEuHVfb0LW3jqh34Cg9MDnYIR7vifFfstiriWRAs/M+CeRcA9DVANKYTe8iA5EzukRNonkceyMJGn5Q/EnxRDPXbl4lNsfrSKGdtNc8yBtWeE4hnvqJFNLArzVBfJZdaBu1fxqfkJtfix8BasRQGKEJXbEv22o1UVSVfjzJxFCVBMZDC88zANMOKgv/gkXEWZ88/oStifc53lLB5cKMxAWY9ex29RpFhnAhfsErjNEaVWjq/4+NAMp455VWZWnwUjBgeYHUzarc9qlTTjDpuEGexemiujBPHCjZ/hq6bCjU5v+6DLvFotqL2BMbeFf/SSNteoaxGvhHpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from MWHPR21MB0798.namprd21.prod.outlook.com (2603:10b6:300:128::18) by MW4PR21MB1860.namprd21.prod.outlook.com (2603:10b6:303:7a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.5; Sat, 12 Jun 2021 01:14:47 +0000 Received: from MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946]) by MWHPR21MB0798.namprd21.prod.outlook.com ([fe80::1d02:9a92:e9:c946%14]) with mapi id 15.20.4242.013; Sat, 12 Jun 2021 01:14:47 +0000 From: Eugene Rozenfeld To: Wei Mi CC: Andi Kleen , Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHXOsu5yff2ykdMyE6mPDeCIIGFBarK/raAgBJ5I4CAEWTx0IAA/viAgAO7iWCAABqKAIAABYKggAAGX4CAADNtcIAAnAYAgABLI5CAAGp1gIABV7XAgAA2bICAGQiOoA== Date: Sat, 12 Jun 2021 01:14:47 +0000 Message-ID: References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=0e178637-5fba-4892-841d-ed106a12a3fb; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-06-12T01:08:55Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 404a2a76-5db8-43db-5c0b-08d92d3f7844 x-ms-traffictypediagnostic: MW4PR21MB1860: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wmP0RyIOIQWIoyv8xiWRe8rpgoI8d1F4PesByzhAGkKqozGWAC5fTR7I2DtUeT+IM/AlE7A/QaiFTGywNuZ+Dd6VGa9ffQvlz2i9AXh3yRLFBZZU4lz5PwV3Q0YFhNXzU7KsD/6m/5h0ewmXN/uL7fhQEBgGi77X5rxLqNbLQ5rpuuNcrTUGcVJjwqMCf8vGEoqgtXzqR/CqsTBO9W3k//w2Mk8pUVKPGIMG8+PdtGFq4MGKvr9wKciVNhiHqxDPDYY4+Hvpf/RgQdazMt6sMIT8bFlPauWIX3R2s1895Kk3oaaylbMv5nJpQJol/yZnw2OGQO6JyKtcuDWJoBqkP2nQTUIy7u4da/XSLNiT6ikHfAT2m2tcC8OI79D08prO/fRYNBrm27MC0dNbgEqLmUcS3bsx8hFP8aVkKVbfO88hNTCSmK7Rkls+CMSdJm6yID5G6gSYkSq+zQR2FoEhBt/qnIpnQle/a7ntWKkNhKmTCYorM1lwOcZhqOXPk4ipPQF+lsaxTKPIF2dX6SJ+OVl9sfxrt+blsVVC+hSly6u16j8/37jfKBHVdcqI0B4jXe3D25/xZ8vwhjsSi4W9eBiEB80+rPljowr71mpDmtj6Imc5ZDTfbbckUMt4o6SXiYFpbkoygPq1nv6m0uraV70d4hUsP7jYjj/hPTIbHlpYO6/YCzgeAsQopf/kIQEANevkmGU53wT11B/pPJXt++fBx8DlAbqVj7RrmbK4TF+LSNUhv546L3gTdt08LO8hWf1DSekGjUgJXziCzexOj/C276u33T34vXVy4DrJFceaDN00ZEe4QEzSByMhuiPp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR21MB0798.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(30864003)(82960400001)(10290500003)(6916009)(478600001)(316002)(86362001)(2906002)(83380400001)(4326008)(54906003)(76116006)(55016002)(66476007)(82950400001)(9686003)(53546011)(186003)(66556008)(33656002)(7696005)(38100700002)(5660300002)(71200400001)(966005)(8990500004)(8936002)(52536014)(122000001)(66446008)(6506007)(8676002)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?izThf9g3CHL4SdOebt58IqFlCqmMehaouP310cnXEgUzUlTvjfWvuuxl6Uj/?= =?us-ascii?Q?C46IglgOh5xXQCe2OfHVd7HdQxI3agdLwpuG8aXoxWyYbZQORMduvMAsxHqz?= =?us-ascii?Q?TMra+880Sq11FxeVrZ1ZIal710KFCZgs0QoOZA6Ffo9ilCisrdNittGuo0gx?= =?us-ascii?Q?Q2GOf2NxMsiDz4aU7hxSdotifzpydX+VR/eCqRIVJw7UhWJgFTVs2o+xOIaw?= =?us-ascii?Q?q0THUDmm25IVF/uQhYCcUJSsOz6Sjw7XCeumfnJ78f9jlLZhJe9zngJywvnP?= =?us-ascii?Q?/xGzztL2GOy7J9bULq6WDE/TDYEZj9J3FbTLOqcs1c9qRSbTaZkB0LK6p0KK?= =?us-ascii?Q?BZvFawrdhwSqP39qXNF26Ou0UZIHSFL+aZnG3Wd205EKOTmlQ+kS4kX91Z/j?= =?us-ascii?Q?tA92PvdyJR8InFizbK4kl8C+swK9B5kR4Zz3Zt+kuRTr1AA1Wzh+eya96236?= =?us-ascii?Q?dn7yW9eKHiSrtlzvpdq7kBAnOwgRqytyoViekXmM8lnypn0gtYaNruwkWNqN?= =?us-ascii?Q?mv/Gt+tR3IezaHE5CrDC3AAqpjtVGJ2NUGnxiDNSp7duMa116SJY5ldYJgHe?= =?us-ascii?Q?/a/yensAOgrcKamMl+bYkES4wQ+KYegQ0fLSKDZSwhbcY7mf8fOVSsQbZyHS?= =?us-ascii?Q?5FrGaPNqODcHDD7slIjaF1sWxcPXxwB6qEcG6aA1B1FxFG20Hffzy/9otXfD?= =?us-ascii?Q?V+JPqBhfw2XOOIctURCWoriXomSHQP3jm6yR80R4lugWWQ6n6Ayng2fGpdaC?= =?us-ascii?Q?BVE8OJ9yD9vY5fLWoQqDmF5pxiHQKaFHzJGjDOTIL3MgDbEldulqLTZH+4vb?= =?us-ascii?Q?4RMcDBfjJ1Mc1N/IheRspCCxyt+aoSq297cPcZWRx3XhAqUl7ddZUAEuYWzc?= =?us-ascii?Q?JPpbOH+uH7u8EEXk6gXtK+OKgc8qXRUiYIx2+D+Kr7EhSSWqK7YzWEQv4ggj?= =?us-ascii?Q?PVZywRKwe7kWIeyagsIO3ooWB3385o7/eoETbuJ82NTM7ntxSvRQlxTn2yHi?= =?us-ascii?Q?LyAppc2CTaN8U6JFqiARFM3JpQ3Gs5LdZAESpBsg0m9qblha3Bx2RWGuw1iv?= =?us-ascii?Q?VQP1g4kw6Qw0O/LhnC2uic1pxmDxfrmRkg3btypwkIvCoGQXzeFQ5in10JeH?= =?us-ascii?Q?QHYP9guotIEghQ/vfNSzzNn191VYcDTVzh5BshfkEy+03iqqnOVwbl3jGupY?= =?us-ascii?Q?BTioKVtvi1SgBL5thF4s9GalhU2MAD3+o0SG3x7p9PINxVTm7S6DAwXIj7cQ?= =?us-ascii?Q?Ad84S0KF3cE6Cm93soxQenWG2Zc+y/bxArXR4mV7aSKi1K06uZ/Y+3uSYwiE?= =?us-ascii?Q?6lHIj/T2lApV0+6V9aZ3je25JyaWaUNoOQkycEuDTJQXDUWV3EosEOFJRzVd?= =?us-ascii?Q?8CnOQEe3VjqoZ1inpOFXHBBMvNJ8?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB0798.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 404a2a76-5db8-43db-5c0b-08d92d3f7844 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2021 01:14:47.2361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S7cr9lqv9qYBLiWQpuVcIW6JCptcUFIdTCdB5INV37YW3be9yA/oj/G23PfA+3PJ1uIy9DLwLJxbnQFKtn8sFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR21MB1860 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2021 01:14:54 -0000 It appears that create_gcov doesn't support binaries with dwarf version 5 (= which is the current default).=20 I tried a trivial example and got reasonable gcov files for binaries with d= warf v2, v3, and v4 but the same example with dwarf v5 produced=20 "File './sort' has mangled .debug_info section." and a gcov file with 0 functions. Does create_llvm_prof has the same limitation? Eugene -----Original Message----- From: Wei Mi =20 Sent: Wednesday, May 26, 2021 7:52 PM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang Davi= d Li ; Jan Hubicka ; gcc@gcc.gnu.org; W= enlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC Thanks. Good to know the build works with newer protobuf. Wei. On Wed, May 26, 2021 at 4:40 PM Eugene Rozenfeld wrote: > > 3.0.0 is the latest supported version on Ubuntu 18.04. I verified that th= e build works on Ubuntu 20.04 with protobuf-compiler and libprotobuf-dev v= ersion 3.6.1.3. > > Eugene > > -----Original Message----- > From: Wei Mi > Sent: Tuesday, May 25, 2021 8:07 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang=20 > David Li ; Jan Hubicka ;=20 > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > I checked the source of protobuf 3.0.0 and it didn't contain the operator= [] in RepeatedField. Need to install a newer version of protobuf. > > Thanks, > Wei. > > On Tue, May 25, 2021 at 1:49 PM Eugene Rozenfeld wrote: > > > > Both are 3.0.0-9.1ubuntu1: > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list=20 > > protobuf-compiler Listing... Done protobuf-compiler/bionic,now > > 3.0.0-9.1ubuntu1 amd64 [installed] > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt list=20 > > libprotobuf-dev Listing... Done libprotobuf-dev/bionic,now > > 3.0.0-9.1ubuntu1 amd64 [installed] > > > > -----Original Message----- > > From: Wei Mi > > Sent: Tuesday, May 25, 2021 9:17 AM > > To: Eugene Rozenfeld > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > Xinliang David Li ; Jan Hubicka=20 > > ; gcc@gcc.gnu.org; Wenlei He > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > It looks like some version problem about protobuf-compiler and libproto= buf-dev. Could you check what is the installed version on your end for thos= e two packages and see if they are consistent? > > > > On my platform, they are both 3.12.4. > > > > On Tue, May 25, 2021 at 12:01 AM Eugene Rozenfeld wrote: > > > > > > That eliminates the previous error but there is a new one: > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [3/199]=20 > > > Building CXX object=20 > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/qu > > > ip > > > pe > > > r/perf_reader.cc.o > > > FAILED: CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/s= rc/quipper/perf_reader.cc.o > > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_pa= rty/perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../th= ird_party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CM= akeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/perf_= reader.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_converter= /src/quipper/perf_reader.cc.o.d -o CMakeFiles/quipper_perf.dir/third_party/= perf_data_converter/src/quipper/perf_reader.cc.o -c ../third_party/perf_dat= a_converter/src/quipper/perf_reader.cc > > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc: In mem= ber function 'bool quipper::PerfReader::ReadCPUTopologyMetadata(quipper::Da= taReader*, size_t)': > > > ../third_party/perf_data_converter/src/quipper/perf_reader.cc:1518:46= : error: no match for 'operator[]' (operand types are 'const google::protob= uf::RepeatedField' and 'int') > > > nrcpus =3D proto_uint32_metadata.data()[0]; > > > > > > -----Original Message----- > > > From: Wei Mi > > > Sent: Monday, May 24, 2021 8:54 PM > > > To: Eugene Rozenfeld > > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > > Xinliang David Li ; Jan Hubicka=20 > > > ; gcc@gcc.gnu.org; Wenlei He > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > It isn't exposed on my platform either. Looks like a bug in perf_data= _converter (i.e., quipper). Could you try adding #include i= n third_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see = if it fixes the problem? If it works, I will need to file a bug against per= f_data_converter. > > > > > > Thanks, > > > Wei. > > > > > > On Mon, May 24, 2021 at 8:33 PM Eugene Rozenfeld wrote: > > > > > > > > That fixed the error I saw before but the build still fails. The=20 > > > > errors start with > > > > > > > > > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja > > > > > > > > [2/217] Building CXX object > > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/ > > > > qu > > > > ip > > > > pe > > > > r/huge_page_deducer.cc.o > > > > > > > > FAILED: > > > > CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/ > > > > qu > > > > ip > > > > pe > > > > r/huge_page_deducer.cc.o > > > > > > > > /usr/bin/c++ -I../third_party/perf_data_converter/src -I../third_= party/perf_data_converter/src/quipper -I../ -I../third_party/glog/src -I../= third_party/abseil -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT = CMakeFiles/quipper_perf.dir/third_party/perf_data_converter/src/quipper/hug= e_page_deducer.cc.o -MF CMakeFiles/quipper_perf.dir/third_party/perf_data_c= onverter/src/quipper/huge_page_deducer.cc.o.d -o CMakeFiles/quipper_perf.di= r/third_party/perf_data_converter/src/quipper/huge_page_deducer.cc.o -c ../= third_party/perf_data_converter/src/quipper/huge_page_deducer.cc > > > > > > > > ../third_party/perf_data_converter/src/quipper/huge_page_deducer.cc= : > > > > 14 > > > > 4:26: error: 'unordered_map' in namespace 'std' does not name a=20 > > > > template type > > > > > > > > using container =3D std::unordered_map; > > > > > > > > ^~~~~~~~~~~~~ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Wei Mi > > > > Sent: Monday, May 24, 2021 8:12 PM > > > > To: Eugene Rozenfeld > > > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > > > Xinliang David Li ; Jan Hubicka=20 > > > > ; gcc@gcc.gnu.org; Wenlei He > > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > > > > > > > > > Sorry, I added dependency for create_gcov but missed it for dump_gc= ov. Fixed it at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps= %3A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F6ca36cdc30986f13583a3aef3= e27746ca4fc5bf6&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft.com%7Cf1e= 7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C= 637576807258125451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu= MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D826uc8So5JIW6bTbsxBMi= EbLWexdiBiPjYrxexHOLmI%3D&reserved=3D0. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Wei. > > > > > > > > > > > > > > > > On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld wrote: > > > > > > > > Thank you Wei. Looks like something is still missing. This time per= f_data.pb.h is not found. I'm getting the error below (on Ubuntu 18.04 with= cmake 3.12.1): > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/241]=20 > > > > Building CXX object CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > > FAILED: CMakeFiles/dump_gcov_lib.dir/profile.cc.o > > > > /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/abs= eil -I../third_party/perf_data_converter/src -I../third_party/perf_data_con= verter/src/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT = CMakeFiles/dump_gcov_lib.dir/profile.cc.o -MF CMakeFiles/dump_gcov_lib.dir/= profile.cc.o.d -o CMakeFiles/dump_gcov_lib.dir/profile.cc.o -c ../profile.c= c > > > > In file included from ../third_party/perf_data_converter/src/quippe= r/perf_parser.h:18:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ > > > > > > > > In file included from ../profile.h:14:0, > > > > from ../profile.cc:5: > > > > ../base/macros.h:114:0: note: this is the location of the=20 > > > > previous definition #define DISALLOW_COPY_AND_ASSIGN(TypeName)=20 > > > > \ > > > > > > > > In file included from ../third_party/perf_data_converter/src/quippe= r/perf_parser.h:18:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x)=20 > > > > / > > > > sizeof(*x)) > > > > > > > > In file included from ../profile.h:14:0, > > > > from ../profile.cc:5: > > > > ../base/macros.h:162:0: note: this is the location of the=20 > > > > previous definition #define arraysize(array) > > > > (sizeof(ArraySizeHelper(array))) > > > > > > > > In file included from ../third_party/perf_data_converter/src/quippe= r/perf_parser.h:21:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:14:10= : > > > > fatal error: perf_data.pb.h: No such file or directory #include "p= erf_data.pb.h" > > > > ^~~~~~~~~~~~~~~~ > > > > compilation terminated. > > > > [6/241] Building CXX object > > > > CMakeFiles/dump_gcov_lib.dir/symbol_map.cc.o > > > > ninja: build stopped: subcommand failed. > > > > > > > > Thanks, > > > > > > > > Eugene > > > > > > > > From: Wei Mi > > > > Sent: Saturday, May 22, 2021 9:37 AM > > > > To: Eugene Rozenfeld > > > > Cc: Andi Kleen ; Hongtao Yu ;=20 > > > > Xinliang David Li ; Jan Hubicka=20 > > > > ; gcc@gcc.gnu.org; Wenlei He > > > > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > It is a proto library build dependency issue which didn't expose on= my platform. I fix it at https://nam06.safelinks.protection.outlook.com/?u= rl=3Dhttps%3A%2F%2Fgithub.com%2Fgoogle%2Fautofdo%2Fcommit%2F98269aee9674cc8= 85cc5eb1bd917eb2d12731710&data=3D04%7C01%7CEugene.Rozenfeld%40microsoft= .com%7Cf1e7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab2d7cd011db47%= 7C1%7C0%7C637576807258125451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D%2Br9qK1fc2= SQu%2FT9rHOCsJcYqzpkXnDu7SNfpLB9NCqQ%3D&reserved=3D0. Please try again. > > > > > > > > Thanks, > > > > Wei. > > > > > > > > On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld wrote: > > > > I tried following the instructions in "2.2 Build autofdo tool for g= cc" in https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F= github.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Rozenfel= d%40microsoft.com%7Cf1e7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab= 2d7cd011db47%7C1%7C0%7C637576807258125451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM= C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata= =3DKpbQ1SBpwtPLdgJCpJQ6aW6iHj3mvisPN5kZVRiRQhM%3D&reserved=3D0 got buil= d failures: > > > > > > > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228]=20 > > > > Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > > FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o > > > > /usr/bin/c++ -I../ -I../third_party/glog/src=20 > > > > -I../third_party/abseil -I../third_party/perf_data_converter/src -I= ../third_party/perf_data_converter/src/quipper -I../util -I. -Ithird_party/= glog -std=3Dgnu++1z -MD -MT CMakeFiles/create_gcov_lib.dir/profile.cc.o -MF= CMakeFiles/create_gcov_lib.dir/profile.cc.o.d -o CMakeFiles/create_gcov_li= b.dir/profile.cc.o -c ../profile.cc In file included from ../third_party/pe= rf_data_converter/src/quipper/perf_parser.h:18:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: > > > > warning: "DISALLOW_COPY_AND_ASSIGN" redefined #define > > > > DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../profi= le.h:14:0, > > > > from ../profile.cc:5: > > > > ../base/macros.h:114:0: note: this is the location of the=20 > > > > previous definition #define DISALLOW_COPY_AND_ASSIGN(TypeName) \=20 > > > > In file included from ../third_party/perf_data_converter/src/quippe= r/perf_parser.h:18:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: > > > > warning: "arraysize" redefined #define arraysize(x) (sizeof(x) / > > > > sizeof(*x)) In file included from ../profile.h:14:0, > > > > from ../profile.cc:5: > > > > ../base/macros.h:162:0: note: this is the location of the=20 > > > > previous definition #define arraysize(array) > > > > (sizeof(ArraySizeHelper(array))) In file included from ../third_par= ty/perf_data_converter/src/quipper/perf_parser.h:21:0, > > > > from ../sample_reader.h:18, > > > > from ../profile.h:15, > > > > from ../profile.cc:5: > > > > ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10= : > > > > fatal error: perf_stat.pb.h: No such file or directory #include "pe= rf_stat.pb.h" > > > > ^~~~~~~~~~~~~~~~ > > > > compilation terminated. > > > > > > > > What is supposed to generate perf_stat.pb.h? > > > > > > > > Thanks, > > > > > > > > Eugene > > > > > > > > From: Wei Mi > > > > Sent: Monday, May 10, 2021 4:47 PM > > > > To: Andi Kleen > > > > Cc: Hongtao Yu ; Xinliang David Li=20 > > > > ; Jan Hubicka=20 > > > > ; mailto:gcc@gcc.gnu.org; Eugene=20 > > > > Rozenfeld ; Wenlei He=20 > > > > > > > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fgithub.com%2Fgoogle%2Fautofdo&data=3D04%7C01%7CEugene.Rozenfeld%40micr= osoft.com%7Cf1e7a16701ba4295722c08d920ba6846%7C72f988bf86f141af91ab2d7cd011= db47%7C1%7C0%7C637576807258135446%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM= DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D0qVyYY= mYDZfHt3cdxg1LjUYvonck6G6PLAOFeYCNnTc%3D&reserved=3D0 has been updated.= Now create_gcov/dump_gcov are added back and can be built separately. > > > > > > > > Please look at "2.2 Build autofdo tool for gcc" in=20 > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F% > > > > 2F > > > > gi > > > > th > > > > ub.com%2Fgoogle%2Fautofdo%23readme&data=3D04%7C01%7CEugene.Roz > > > > en > > > > fe > > > > ld > > > > %40microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86 > > > > f1 > > > > 41 > > > > af > > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFpbG > > > > Zs > > > > b3 > > > > d8 > > > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > > > 3D > > > > %7 > > > > C1 > > > > 000&sdata=3DEwHtN1OqRmBwL6qMgTc1lAU6cz5%2BJzQZxpd5nos11FM%3D&a > > > > mp > > > > ;r > > > > es > > > > erved=3D0 On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen=20 > > > > wrote: > > > > > > > > > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > > > > > Andi, thanks for pointing out the perf script issues. Can yo= u please > > > > > > elaborate a bit on the exact issue you have seen? We've been= using > > > > > > specific output of perf script such as mmap, LBR and callsta= ck events > > > > > > filtered by process id. It works fine so far but may certain= ly hit issues > > > > > > in the future with extended uses. > > > > > > > > > > Okay I took a look at the latest autofdo now. It seems to be=20 > > > > > basically a LLVM project now that depends on LLVM to even=20 > > > > > build with all kinds of dependency hell on some old LLVM version = and other packages. > > > > > > > > > > I guess gcc will really need a replacement that doesn't pull=20 > > > > > in all of LLVM if it wants to continue supporting autofdo. > > > > > > > > > > I'm myself unable to build now. > > > > > > > > > > I'm using the old version I had a git fork of and that was=20 > > > > > before all of this. I added a patch to make it work with the=20 > > > > > latest perf by ignoring increased perf_attr and unknown perf even= ts. > > > > > > > > > > Honza please use > > > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2 > > > > > F% > > > > > 2F > > > > > gi > > > > > thub.com%2Fandikleen%2Fautofdo&data=3D04%7C01%7CEugene.Rozen > > > > > fe > > > > > ld > > > > > %4 > > > > > 0microsoft.com%7C1bcb2fda4fce4f173c1808d91f30d1fc%7C72f988bf86 > > > > > f1 > > > > > 41 > > > > > af > > > > > 91ab2d7cd011db47%7C1%7C0%7C637575116816287200%7CUnknown%7CTWFp > > > > > bG > > > > > Zs > > > > > b3 > > > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > > > > > Mn > > > > > 0% > > > > > 3D > > > > > %7C1000&sdata=3DDilu5PUjpAbA6e6d6GBd5idoKLAMMr7H5eCve%2FGdC8 > > > > > g% > > > > > 3D > > > > > &a > > > > > mp;reserved=3D0 -b perf-future > > > > > > > > > > for testing. > > > > > > > > > > -Andi > > > > >