From: "Dave Korn" <dave.korn@artimi.com>
To: "'Alexandre Oliva'" <aoliva@redhat.com>,
"'Richard Henderson'" <rth@redhat.com>
Cc: "'Bernd Schmidt'" <bernds_cb1@t-online.de>, <gcc@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>
Subject: RE: [RFC] avoiding too narrow register classes in reload
Date: Thu, 16 Dec 2004 14:14:00 -0000 [thread overview]
Message-ID: <NUTMEGVtiQJYI02PrKl000007d9@NUTMEG.CAM.ARTIMI.COM> (raw)
In-Reply-To: <or6533s4uc.fsf@livre.redhat.lsd.ic.unicamp.br>
> -----Original Message-----
> From: gcc-owner On Behalf Of Alexandre Oliva
> Sent: 15 December 2004 20:07
> On Dec 15, 2004, Richard Henderson wrote:
>
> > Ok, except,
> >> - if (reg_class_size[this_alternative[i]] == 1
> >> + if (reg_class_size[this_alternative[i]] > 0
> >> + && SMALL_REGISTER_CLASS_P (this_alternative[i])
>
> > reg_class_size check redundant with SMALL_REGISTER_CLASS_P.
>
> I thought I'd leave it in for, like, documentation purposes, just in
> case someone reworks SMALL_REGISTER_CLASS_P such that it can match
> even for 0-sized classes, but fine.
As long as it's not in a critical inner loop, I always feel that a couple of
memory accesses and a test-and-branch are a small price to pay for having code
that clearly self-documents the intent behind it. But hey, no big deal :)
cheers,
DaveK
--
Can't think of a witty .sigline today....
next prev parent reply other threads:[~2004-12-16 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 21:20 Alexandre Oliva
2004-12-14 2:06 ` Richard Henderson
2004-12-14 21:20 ` Alexandre Oliva
2004-12-14 22:31 ` Richard Henderson
2004-12-15 6:56 ` Alexandre Oliva
2004-12-15 8:09 ` Richard Henderson
2004-12-15 20:07 ` Alexandre Oliva
2004-12-16 14:14 ` Dave Korn [this message]
2004-12-14 16:22 ` Bernd Schmidt
2004-12-14 20:53 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NUTMEGVtiQJYI02PrKl000007d9@NUTMEG.CAM.ARTIMI.COM \
--to=dave.korn@artimi.com \
--cc=aoliva@redhat.com \
--cc=bernds_cb1@t-online.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).