From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3177 invoked by alias); 13 Mar 2009 05:51:33 -0000 Received: (qmail 3162 invoked by uid 22791); 13 Mar 2009 05:51:33 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Mar 2009 05:51:01 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.14.3/8.13.8) with ESMTP id n2D5oCGH321802; Fri, 13 Mar 2009 05:50:12 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2D5oC5R3444950; Fri, 13 Mar 2009 06:50:12 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2D5oCxp029573; Fri, 13 Mar 2009 06:50:12 +0100 Received: from d12mc102.megacenter.de.ibm.com (d12mc102.megacenter.de.ibm.com [9.149.167.114]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2D5oCUV029568; Fri, 13 Mar 2009 06:50:12 +0100 In-Reply-To: References: <7FB04A5C213E9943A72EE127DB74F0AD49E5D35DFF@SJEXCHCCR02.corp.ad.broadcom.com> Subject: [PATCH] SMS - Pass the actual schedulable rows to compute_split_row X-KeepSent: A993E7A6:563C4F73-C2257577:00329B47; type=4; name=$KeepSent To: Ayal Zaks Cc: "Adrian Ashley" , "Bingfeng Mei" , "gcc@gcc.gnu.org" , gcc-patches@gcc.gnu.org Message-ID: From: Revital1 Eres Date: Fri, 13 Mar 2009 06:43:00 -0000 MIME-Version: 1.0 Content-type: multipart/mixed; Boundary="0__=4DBBFFE4DFA11DD78f9e8a93df938690918c4DBBFFE4DFA11DD7" Content-Disposition: inline X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-03/txt/msg00376.txt.bz2 --0__=4DBBFFE4DFA11DD78f9e8a93df938690918c4DBBFFE4DFA11DD7 Content-type: text/plain; charset=US-ASCII Content-length: 943 Hello, > > Using testsuite/gcc.dg/sms-6.c as an example and compiling it for > PowerPC, > > node 18 (see attachment) is in a SCC and cannot be scheduled until > spliting > > twice. The MII = 20 and the schedule can only be found at II = 24. > > Yes, I see. This example raises a couple of issues: > > o The first row split (from II=20 to II=21) is miscalculated; it should be > row 20=0 instead of 19. Splitting row 19 cannot help schedule node 18, and > indeed we immediately split another row. We're now checking a small patch > to fix this, which should save one cycle of II in the above example. Here is the patch, on behalf of Ayal. Passed bootstrap + regtest with SMS flags on ppc64 and bootstrap + regtest x86. I'll commit it later today to trunk if that's OK. Thanks, Revital * modulo-sched.c (sms_schedule_by_order): Pass the actual schedulable rows to compute_split_row. (See attached file: patch_sms_12_3.txt) --0__=4DBBFFE4DFA11DD78f9e8a93df938690918c4DBBFFE4DFA11DD7 Content-type: text/plain; name="patch_sms_12_3.txt" Content-Disposition: attachment; filename="patch_sms_12_3.txt" Content-transfer-encoding: base64 Content-length: 1115 SW5kZXg6IG1vZHVsby1zY2hlZC5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gbW9kdWxvLXNjaGVkLmMJKHJldmlzaW9uIDE0NDczOSkNCisrKyBt b2R1bG8tc2NoZWQuYwkod29ya2luZyBjb3B5KQ0KQEAgLTE4MzMsMTAgKzE4 MzMsMTAgQEAgc21zX3NjaGVkdWxlX2J5X29yZGVyIChkZGdfcHRyIGcsIGlu dCBtaQ0KIA0KICAgICAgICAgICAgICAgbnVtX3NwbGl0cysrOw0KICAgICAg ICAgICAgICAgaWYgKHN0ZXAgPT0gMSkNCi0gICAgICAgICAgICAgICAgc3Bs aXRfcm93ID0gY29tcHV0ZV9zcGxpdF9yb3cgKHNjaGVkX25vZGVzLCBzdGFy dCwgZW5kLA0KKyAgICAgICAgICAgICAgICBzcGxpdF9yb3cgPSBjb21wdXRl X3NwbGl0X3JvdyAoc2NoZWRfbm9kZXMsIHN0YXJ0LCBlbmQgLSAxLA0KICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cHMtPmlpLCB1X25vZGUpOw0KICAgICAgICAgICAgICAgZWxzZQ0KLSAgICAg ICAgICAgICAgICBzcGxpdF9yb3cgPSBjb21wdXRlX3NwbGl0X3JvdyAoc2No ZWRfbm9kZXMsIGVuZCwgc3RhcnQsDQorICAgICAgICAgICAgICAgIHNwbGl0 X3JvdyA9IGNvbXB1dGVfc3BsaXRfcm93IChzY2hlZF9ub2RlcywgZW5kICsg MSwgc3RhcnQsDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBwcy0+aWksIHVfbm9kZSk7DQogDQogICAgICAgICAg ICAgICBwc19pbnNlcnRfZW1wdHlfcm93IChwcywgc3BsaXRfcm93LCBzY2hl ZF9ub2Rlcyk7DQo= --0__=4DBBFFE4DFA11DD78f9e8a93df938690918c4DBBFFE4DFA11DD7--