public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Leehod Baruch <LEEHOD@il.ibm.com>
To: Roger Sayle <roger@eyesopen.com>
Cc: gcc@gcc.gnu.org, Mircea Namolaru <NAMOLARU@il.ibm.com>
Subject: Re: Question about merging two instructions.
Date: Sun, 21 Aug 2005 17:54:00 -0000	[thread overview]
Message-ID: <OFB3CF453F.B7E4DC69-ONC2257064.005F5FD0-C2257064.00627321@il.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0508211022100.21895-100000@www.eyesopen.com>

>>(insn 1 0 2 0 (set (reg/v:Xmode r)
>>        (sign_extend:Xmode (op:Ymode (...))))
>>(insn 2 1 3 0 (set (lhs) (rhs)))

> To summarise, the change above is not unreasonable and I'd be
> happy to allow this change to simplify-rtx.c, but I'd be more
> cautious about where and why it was used.  For example, if you're
> sure nothing bad can happen in the LHS, it might be reasonable
> to instead place this code in a simplify_replace_set() function.

I want to replace every use of (reg r) with the extension.  There might 
be such use on the LHS, this is why the LHS might change.

1. Can you please give me an example of something bad that can happen to 
the LHS.  Maybe I'm missing something here.

2. After calling simplify_replace_rtx I try to recognize the instruction.
Is this been cautious or is it unnecessary?

3. Isn't it reasonable to expect that every instance on old_rtx will be 
replaced by new_rtx even if it can't be simplified?
This is what I understand from the function's documentation.
But actually every expressions that can't be simplified is not replaced.


Thanks,
Leehod.

  reply	other threads:[~2005-08-21 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-21 13:52 Leehod Baruch
2005-08-21 16:55 ` Roger Sayle
2005-08-21 17:54   ` Leehod Baruch [this message]
2005-08-22  7:38     ` Paolo Bonzini
2005-08-22 13:33       ` Leehod Baruch
2005-08-22 13:37         ` Paolo Bonzini
2005-08-22 16:30           ` Richard Henderson
2005-08-22 13:49     ` Roger Sayle
2005-08-22  7:10   ` Paolo Bonzini
2005-08-22 14:12     ` Leehod Baruch
2005-08-22 14:42       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OFB3CF453F.B7E4DC69-ONC2257064.005F5FD0-C2257064.00627321@il.ibm.com \
    --to=leehod@il.ibm.com \
    --cc=NAMOLARU@il.ibm.com \
    --cc=gcc@gcc.gnu.org \
    --cc=roger@eyesopen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).