From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-55096-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4585 invoked by alias); 14 Jun 2002 14:41:06 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 4551 invoked from network); 14 Jun 2002 14:41:03 -0000
Received: from unknown (HELO d12lmsgate.de.ibm.com) (195.212.91.199)
  by sources.redhat.com with SMTP; 14 Jun 2002 14:41:03 -0000
Received: from d12relay02.de.ibm.com (d12relay02.de.ibm.com [9.165.215.23])
	by d12lmsgate.de.ibm.com (8.12.3/8.12.3) with ESMTP id g5EEf0in038356;
	Fri, 14 Jun 2002 16:41:00 +0200
Received: from d12ml028.de.ibm.com (d12ml028_cs0 [9.165.223.24])
	by d12relay02.de.ibm.com (8.11.1m3/NCO/VER6.1) with ESMTP id g5EEf0N30862;
	Fri, 14 Jun 2002 16:41:00 +0200
Importance: Normal
Sensitivity: 
Subject: Re: Interesting Makefile race condition ...
To: DJ Delorie <dj@redhat.com>
Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org
Message-ID: <OFEA40FCB1.AFB2804D-ONC1256BD8.004FD604@de.ibm.com>
From: "Ulrich Weigand" <Ulrich.Weigand@de.ibm.com>
Date: Fri, 14 Jun 2002 07:53:00 -0000
MIME-Version: 1.0
Content-type: text/plain; charset=us-ascii
X-SW-Source: 2002-06/txt/msg00961.txt.bz2


>DJ Delorie wrote:
>
>> How should this be fixed?  Maybe any Makefile target using
>> $(GCC_FOR_TARGET) should depend on specs as well as on xgcc?
>
>That seems like an obvious fix to me.

Actually it looks like all other targets using $(GCC_FOR_TARGET)
already depend on specs, it is just missing for libgcc.mk.

So I committed the following patch as obvious.  Bootstrapped on
s390-ibm-linux.

ChangeLog:

      * Makefile.in (libgcc.mk): Depend on specs.


Index: gcc/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.899
diff -c -p -r1.899 Makefile.in
*** gcc/Makefile.in     11 Jun 2002 20:06:04 -0000    1.899
--- gcc/Makefile.in     14 Jun 2002 13:57:05 -0000
*************** xlimits.h: glimits.h limitx.h limity.h
*** 994,1000 ****
  LIB2ADD = $(LIB2FUNCS_EXTRA)
  LIB2ADD_ST = $(LIB2FUNCS_STATIC_EXTRA)

! libgcc.mk: config.status Makefile mklibgcc $(LIB2ADD) $(LIB2ADD_ST) xgcc
$(exeext)
      objext='$(objext)' \
      LIB1ASMFUNCS='$(LIB1ASMFUNCS)' \
      LIB2FUNCS_1='$(LIB2FUNCS_1)' \
--- 994,1000 ----
  LIB2ADD = $(LIB2FUNCS_EXTRA)
  LIB2ADD_ST = $(LIB2FUNCS_STATIC_EXTRA)

! libgcc.mk: config.status Makefile mklibgcc $(LIB2ADD) $(LIB2ADD_ST) xgcc
$(exeext) specs
      objext='$(objext)' \
      LIB1ASMFUNCS='$(LIB1ASMFUNCS)' \
      LIB2FUNCS_1='$(LIB2FUNCS_1)' \


Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
  Dr. Ulrich Weigand
  Linux for S/390 Design & Development
  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
  Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand@de.ibm.com