Breaking up enormous source files

Breaking up enormous source files

[Ansgar Esztermann]

That project has been sitting on the web site for quite some time
now, so I thought I'd start working on it.
I have picked fold-const.c for now and intend to work my way through
the list. However, I have a few questions:

What size should I aim for in the resulting files? Is 50k OK, too 
small, or still too large?

Is it OK to submit several smaller patches instead of a single large
one? E.g., when breaking up a.c into a.c, b.c, and c.c, first 
preparing one patch that creates b.c and reduces the size of a.c by
roughly one third would probably decrease the likelihood of conflicts
when checking in that patch (as opposed to creating b.c and c.c all
in one go).

Which copyright dates should I give the new files? In a way, they are
new, but then again, their contents is just copied from an older
file. What about header files? Does an old function prototype in a
new file constitute a new or an old copyright?


Thanks for your patience.

Ansgar Esztermann

-- 
Institut fuer theoretische Physik II    | Geb. 25.32.02
Heinrich-Heine-Universitaet Duesseldorf | +49-211-8112059 (phone)
Universitaetsstr. 1                     | +49-211-8112262 (fax)
D-40225 Duesseldorf, Germany            | 

Re: Breaking up enormous source files

[Ansgar Esztermann]

On 20 Feb 2003, Steven Bosscher wrote:

> > I have picked fold-const.c for now and intend to work my way through
> > the list. However, I have a few questions:
> 
> Be careful with fold-const.c.  Jeff Law broke out big chunks from fold()
> to smaller functions on the tree-ssa branch, but unfortunately that work
> is not on the mainline.  Having two people working on one big file in
> different branches usually means "merge trouble".

Yes, that would certainly happen.
However, I could just start with a different file, say, expr.c.

Ansgar

-- 
Institut fuer theoretische Physik II    | Geb. 25.32.02
Heinrich-Heine-Universitaet Duesseldorf | +49-211-8112059 (phone)
Universitaetsstr. 1                     | +49-211-8112262 (fax)
D-40225 Duesseldorf, Germany            | 

Re: Breaking up enormous source files

[Fergus Henderson]

On 20-Feb-2003, Steven Bosscher <s.bosscher@student.tudelft.nl> wrote:
> > I have picked fold-const.c for now and intend to work my way through
> > the list. However, I have a few questions:
> 
> Be careful with fold-const.c.  Jeff Law broke out big chunks from fold()
> to smaller functions on the tree-ssa branch, but unfortunately that work
> is not on the mainline.  Having two people working on one big file in
> different branches usually means "merge trouble".

Yes.  I suggest starting with a different file.

-- 
Fergus Henderson <fjh@cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.

Re: Breaking up enormous source files

[Steven Bosscher]

Op do 20-02-2003, om 14:09 schreef Ansgar Esztermann:
> That project has been sitting on the web site for quite some time
> now, so I thought I'd start working on it.

Cool!

> I have picked fold-const.c for now and intend to work my way through
> the list. However, I have a few questions:

Be careful with fold-const.c.  Jeff Law broke out big chunks from fold()
to smaller functions on the tree-ssa branch, but unfortunately that work
is not on the mainline.  Having two people working on one big file in
different branches usually means "merge trouble".

Jeff, could your tree-ssa patch be applied to mainline, too?

Greetz
Steven