public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Roger Sayle <roger@eyesopen.com>
To: gcc@gcc.gnu.org, <gcc-patches@gcc.gnu.org>
Cc: Joern Rennecke <joern.rennecke@superh.com>,
	Richard Henderson <rth@redhat.com>
Subject: Floating point registers vs. LOAD_EXTEND_OP on alpha
Date: Sun, 18 Jan 2004 18:05:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0401181003080.27690-100000@www.eyesopen.com> (raw)


I believe I've managed to diagnose the cause of the current mainline
bootstrap failure on alphaev67-dec-osf5.1 and presumably all alpha
targets.

The failure was triggered by Joern's recent patch to postreload.c:

> 2004-01-16  J"orn Rennecke <joern.rennecke@superh.com>
>
>       PR 11864
>       * postreload.c (reload_cse_simplify_operands): Don't remove
>       implicit extension from LOAD_EXTEND_OP.

which causes a miscompilation of the garbage collection preprocessors,
such that gt-emit-rtl.h generated during stage2 contains garbage, such
that building emit-rtl.o in stage2 fails, terminating the bootstrap.

Running the regression tests from a non-bootstrapped compiler, and
comparing the results to a compiler with the appove patch reverted,
shows five new regressions, all gcc.c-torture/execute/memcpy-bi.c at
different optimization levels.

Comparing the assembly output of compiling memcpy-bi.c at -O3 shows
the following differences:

594a595
>       cvtlq $f2,$f2
716a718
>       cvtlq $f3,$f3
846a849
>       cvtlq $f4,$f4


The patch has eliminated the sign extensions of an integer value held
in the alpha's floating point registers.  Clearly there's some poor
interaction between LOAD_EXTEND_OP and loading integer values into FP
registers.

I'm guesing that in the sequence:

        lds $f2,40($10)
	cvtlq $f2,$f2
	sts $f2,40($9)

the "cvtlq" is actually doing something useful, such that the alpha
backend's definition of LOAD_EXTEND_OP depends upon register allocation?


Hopefully, this analysis is enough for an alpha maintainer to determine
whether Joern needs an additional check in his post-reload patch or if
the alpha backend's LOAD_EXTEND_OP should claim to be extending in these
modes.

Roger
--

             reply	other threads:[~2004-01-18 18:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-18 18:05 Roger Sayle [this message]
2004-01-18 19:01 ` Richard Henderson
2004-01-18 22:29   ` Richard Henderson
2004-01-19 20:33 ` Joern Rennecke
2004-01-19 20:41   ` Richard Henderson
2004-01-20  9:30     ` Richard Sandiford
2004-01-20 17:17       ` Richard Henderson
2004-01-20 19:05         ` Joern Rennecke
2004-01-20 19:21           ` Joern Rennecke
2004-01-26 19:30             ` Eric Botcazou
2004-01-26 19:46               ` Joern Rennecke
2004-01-26 20:06                 ` Gerald Pfeifer
2004-01-26 20:53                   ` Joern Rennecke
2004-01-26 21:16                     ` Eric Botcazou
2004-01-26 21:18                       ` Gabriel Dos Reis
2004-01-26 20:38                 ` Eric Botcazou
2004-01-22  9:49           ` Richard Sandiford
2004-01-22 19:32             ` Richard Henderson
2004-01-19 21:25 ` Joern Rennecke
2004-01-19 21:38   ` Richard Henderson
2004-01-18 20:42 Richard Kenner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0401181003080.27690-100000@www.eyesopen.com \
    --to=roger@eyesopen.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=joern.rennecke@superh.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).