From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6168 invoked by alias); 17 Jan 2004 17:07:31 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 6154 invoked from network); 17 Jan 2004 17:07:29 -0000 Received: from unknown (HELO lon-mail-3.gradwell.net) (193.111.201.127) by sources.redhat.com with SMTP; 17 Jan 2004 17:07:29 -0000 Received: (qmail 28023 invoked from network); 17 Jan 2004 17:07:28 -0000 Received: from digraph.polyomino.org.uk (postmaster%pop3.polyomino.org.uk@81.187.227.50) by lon-mail-3.gradwell.net with SMTP; 17 Jan 2004 17:07:28 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.30) id 1Ahtuy-0006wg-2d; Sat, 17 Jan 2004 17:07:28 +0000 Date: Sat, 17 Jan 2004 17:07:00 -0000 From: "Joseph S. Myers" X-X-Sender: jsm28@digraph.polyomino.org.uk To: Daniel Berlin cc: Florian Weimer , "gcc@gcc.gnu.org" , gcc-patches@gcc.gnu.org Subject: Re: [RFC] Contributing tree-ssa to mainline In-Reply-To: <42BD9D55-48FC-11D8-AECF-000A95DA505C@dberlin.org> Message-ID: References: <10401170324.AA15949@vlsi1.ultra.nyu.edu> <1074309907.3147.139.camel@frodo.toronto.redhat.com> <20040117134753.GA14621@deneb.enyo.de> <42BD9D55-48FC-11D8-AECF-000A95DA505C@dberlin.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-01/txt/msg01074.txt.bz2 On Sat, 17 Jan 2004, Daniel Berlin wrote: > As Diego stated when SRA was committed, the following limitation exists: > /* Maximum number of fields that a structure should have to be > scalarized. > FIXME This limit has been arbitrarily set to 5. Experiment to find > a > sensible setting. */ > #define MAX_NFIELDS_FOR_SRA 5 Before the merge to mainline, please at least change hardcoded parameters like this to use --param (which does make experimenting with different values easier). I've understood ever since Mark added that option that using it was the convention, it just hasn't been documented as such. OK to commit the following web page patch? (The beginner.html patch is because it seems no-one ever took up my suggestion in that thread to add converting existing parameters to the projects list, and I don't think they've all been done. Adding comments to parameters that for whatever reason shouldn't be converted to --param, saying so, would be useful.) Index: codingconventions.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v retrieving revision 1.30 diff -u -r1.30 codingconventions.html --- codingconventions.html 11 Oct 2003 14:02:53 -0000 1.30 +++ codingconventions.html 17 Jan 2004 17:00:49 -0000 @@ -23,7 +23,8 @@
    -
  • All command-line options must be documented in the GCC manual.
    • +
  • All command-line options (including all --param + arguments) must be documented in the GCC manual.
  • Any change to documented behavior (for example, the behavior of a command-line option or a GNU language extension) must include the @@ -184,6 +185,9 @@ against error_mark_node rather than by comparing the TREE_CODE against ERROR_MARK; see message.

    + +

    Internal numeric parameters that may affect generated code should +be controlled by --param rather than being hardcoded.

    Spelling, terminology and markup

    Index: projects/beginner.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/projects/beginner.html,v retrieving revision 1.43 diff -u -r1.43 beginner.html --- projects/beginner.html 3 Jan 2004 19:15:42 -0000 1.43 +++ projects/beginner.html 17 Jan 2004 17:00:49 -0000 @@ -414,6 +414,10 @@ href="../codingconventions.html">GCC coding conventions consistently.
    • +
  • Change code to follow the coding conventions in other ways. For +example, change arbitrary hardcoded parameters to use the +--param mechanism.
    • +

Port cleanliness

-- Joseph S. Myers jsm@polyomino.org.uk