From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23111 invoked by alias); 24 Sep 2004 00:15:45 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 23090 invoked from network); 24 Sep 2004 00:15:43 -0000 Received: from unknown (HELO lon-mail-3.gradwell.net) (193.111.201.127) by sourceware.org with SMTP; 24 Sep 2004 00:15:43 -0000 Received: (qmail 72094 invoked from network); 24 Sep 2004 00:15:43 -0000 Received: from digraph.polyomino.org.uk (postmaster%pop3.polyomino.org.uk@81.187.227.50) by lon-mail-3.gradwell.net with SMTP; 24 Sep 2004 00:15:43 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.41) id 1CAdkU-0008SH-VE; Fri, 24 Sep 2004 00:15:42 +0000 Date: Fri, 24 Sep 2004 01:30:00 -0000 From: "Joseph S. Myers" X-X-Sender: jsm28@digraph.polyomino.org.uk To: Andrew Pinski cc: Geoffrey Keating , gcc List Subject: Re: attribute data structure rewrite In-Reply-To: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> Message-ID: References: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-09/txt/msg01367.txt.bz2 On Thu, 23 Sep 2004, Andrew Pinski wrote: > Shouldn't name be redefined as char* as you don't really need a full > IDENTIFIER_NODE? Yes I know that correctly it is not but I would suspect > that it would give a good speedup as you don't need to allocate as many > trees as before. The IDENTIFIER_NODEs would probably already have been allocated in the course of parsing. Indeed plain strings would probably be better datastructures - and the cleanup suggested in the comment above is_attribute_p, keeping the lists in canonical form, might make sense too - but better to separate such changes into separate patches from the minimal patch that changes the datastructure to the form indicated. -- Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/ http://www.srcf.ucam.org/~jsm28/gcc/#c90status - status of C90 for GCC 4.0 jsm@polyomino.org.uk (personal mail) jsm28@gcc.gnu.org (Bugzilla assignments and CCs)