Re: Fortran bootstrap broken

Re: Fortran bootstrap broken

[Tobias Burnus]

Dear Gerald,

> /usr/test/gcc/gcc/fortran/intrinsic.c: In function 'add_sym':
> /usr/test/gcc/gcc/fortran/intrinsic.c:306: error: enum conversion in assignment is invalid in C++

Can you try whether the following patch works? If so, you can
commit it as obvious. (I cannot test/commit it until this evening.)

Tobias

Index: intrinsic.c
===================================================================
--- intrinsic.c (revision 147659)
+++ intrinsic.c (working copy)
@@ -303,7 +303,7 @@
       type = (bt) va_arg (argp, int);
       kind = va_arg (argp, int);
       optional = va_arg (argp, int);
-      intent = va_arg (argp, int);
+      intent = (sym_intent) va_arg (argp, int);

       if (sizing != SZ_NOTHING)
        nargs++;

Re: Fortran bootstrap broken

[Richard Guenther]

On Mon, May 18, 2009 at 3:00 PM, Tobias Burnus <burnus@net-b.de> wrote:
> Dear Gerald,
>
>> /usr/test/gcc/gcc/fortran/intrinsic.c: In function 'add_sym':
>> /usr/test/gcc/gcc/fortran/intrinsic.c:306: error: enum conversion in assignment is invalid in C++
>
> Can you try whether the following patch works? If so, you can
> commit it as obvious. (I cannot test/commit it until this evening.)
>
> Tobias
>
> Index: intrinsic.c
> ===================================================================
> --- intrinsic.c (revision 147659)
> +++ intrinsic.c (working copy)
> @@ -303,7 +303,7 @@
>       type = (bt) va_arg (argp, int);
>       kind = va_arg (argp, int);
>       optional = va_arg (argp, int);
> -      intent = va_arg (argp, int);
> +      intent = (sym_intent) va_arg (argp, int);

  intent = va_arg (argp, sym_intent);

instead?

>
>       if (sizing != SZ_NOTHING)
>        nargs++;
>

Re: Fortran bootstrap broken

[Andreas Schwab]

Richard Guenther <richard.guenther@gmail.com> writes:

> On Mon, May 18, 2009 at 3:00 PM, Tobias Burnus <burnus@net-b.de> wrote:
>> Index: intrinsic.c
>> ===================================================================
>> --- intrinsic.c (revision 147659)
>> +++ intrinsic.c (working copy)
>> @@ -303,7 +303,7 @@
>>       type = (bt) va_arg (argp, int);
>>       kind = va_arg (argp, int);
>>       optional = va_arg (argp, int);
>> -      intent = va_arg (argp, int);
>> +      intent = (sym_intent) va_arg (argp, int);
>
>   intent = va_arg (argp, sym_intent);

The argument of va_arg must be the promoted type, the enum type may not
qualify.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Fortran bootstrap broken

[Janus Weil]

2009/5/18 Tobias Burnus <burnus@net-b.de>:
> Can you try whether the following patch works? If so, you can
> commit it as obvious. (I cannot test/commit it until this evening.)
>
> Tobias
>
> Index: intrinsic.c
> ===================================================================
> --- intrinsic.c (revision 147659)
> +++ intrinsic.c (working copy)
> @@ -303,7 +303,7 @@
>       type = (bt) va_arg (argp, int);
>       kind = va_arg (argp, int);
>       optional = va_arg (argp, int);
> -      intent = va_arg (argp, int);
> +      intent = (sym_intent) va_arg (argp, int);
>
>       if (sizing != SZ_NOTHING)
>        nargs++;

This seems to work. I will commit it.

I'm really sorry I broke bootstrap. I usually don't test my Fortran
patches with a full bootstrap (to save time), since I assumed
bootstrapping would not be essential for the Fortran front end.

Sorry for the inconvenience,
Janus

Re: Fortran bootstrap broken

[Janus Weil]

2009/5/18 Janus Weil <janus@gcc.gnu.org>:
> 2009/5/18 Tobias Burnus <burnus@net-b.de>:
>> Can you try whether the following patch works? If so, you can
>> commit it as obvious. (I cannot test/commit it until this evening.)
>>
>> Tobias
>>
>> Index: intrinsic.c
>> ===================================================================
>> --- intrinsic.c (revision 147659)
>> +++ intrinsic.c (working copy)
>> @@ -303,7 +303,7 @@
>>       type = (bt) va_arg (argp, int);
>>       kind = va_arg (argp, int);
>>       optional = va_arg (argp, int);
>> -      intent = va_arg (argp, int);
>> +      intent = (sym_intent) va_arg (argp, int);
>>
>>       if (sizing != SZ_NOTHING)
>>        nargs++;
>
> This seems to work. I will commit it.

Sending        gcc/fortran/ChangeLog
Sending        gcc/fortran/intrinsic.c
Transmitting file data ..
Committed revision 147662.

Re: Fortran bootstrap broken

[Joseph S. Myers]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 363 bytes --]

On Mon, 18 May 2009, Richard Guenther wrote:

> > -      intent = va_arg (argp, int);
> > +      intent = (sym_intent) va_arg (argp, int);
> 
>   intent = va_arg (argp, sym_intent);
> 
> instead?

You can't use va_arg with an enum type on short-enums hosts, though we may 
not presently support any such.

-- 
Joseph S. Myers
joseph@codesourcery.com

Fortran bootstrap broken

[Gerald Pfeifer]

As follows:

> cc1: warnings being treated as errors
> /usr/test/gcc/gcc/fortran/intrinsic.c: In function 'add_sym':
> /usr/test/gcc/gcc/fortran/intrinsic.c:306: error: enum conversion in assignment is invalid in C++
> gmake[3]: *** [fortran/intrinsic.o] Error 1
> gmake[3]: Leaving directory `/usr/nabil-files/pfeifer/OBJ-0518-1229/gcc'

Looks like a consequence of:

  2009-05-18  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/36947
        PR fortran/40039
        * expr.c (gfc_check_pointer_assign): Check intents when comparing
        interfaces.
        * gfortran.h (typedef struct gfc_intrinsic_arg): Add 'intent' member.
        (gfc_compare_interfaces): Additional argument.
        * interface.c (operator_correspondence): Add check for equality of
        intents, and new argument 'intent_check'.
        (gfc_compare_interfaces): New argument 'intent_check', which is passed
        on to operator_correspondence.
        (check_interface1): Don't check intents when comparing interfaces.
        (compare_parameter): Do check intents when comparing interfaces.
        * intrinsic.c (add_sym): Add intents for arguments of intrinsic
        procedures. ...
       
I'm trying to develop and test my stdint.h patch on FreeBSD, but bootstrap
keeps being broken for all sorts of different reasons. :-(

Gerald