From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 41E1A383D831 for ; Tue, 6 Jul 2021 21:36:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41E1A383D831 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-Bp3hzDhDNAqQOzckOc7c5Q-1; Tue, 06 Jul 2021 17:36:24 -0400 X-MC-Unique: Bp3hzDhDNAqQOzckOc7c5Q-1 Received: by mail-qk1-f199.google.com with SMTP id j6-20020a37c2460000b02903b55e9da892so1272601qkm.5 for ; Tue, 06 Jul 2021 14:36:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CdJ7irCA8G1fm178+Md2AktOMn6dTo8KkGjmeqBra8I=; b=NiYLpw5KqLJJ1+w0q+R12L1VVkg/uVe7f2LSi7lbXz1fT8wl9z/BOeWG4I3vSH7unv qUc9n00BnjIHY+11xgQpZm2SqPBSkN1Zm6fsXlMS+xi4rxZMD/9L9XRfZXQg0uVWCZk1 7QJLxYM6yCb+b/ELtDaJyjIt34VQqiM7fqulhMQ6BbaY0ozFeApgVC8yiSuEbz785nS1 eD8PKbpwp5B6gPs1C2M8jWCRY2y8pwi2nHIjD4tVKWpV/ULwLzdcqwWJ7ldxra9YsHJW dGqvFTjqERskjyxxpOancecrXgeY6bnaTshRu54lKxE4ExM3dw9D8tp1mOpHNJcEedNS zbtg== X-Gm-Message-State: AOAM532H9PxMPl2TkQn32Wqa1y7H08CVM3gCqxyyqO/jCu8Rd7XUf1PK SBm5qZuptQ8ZZMwj1bDVD7qWJTNfVRmYZ7fnEbhs3r3WLbr1wgdDquJcBG2T2ovA4JFMYZA+sgP 44ENKbmA= X-Received: by 2002:ac8:5bc8:: with SMTP id b8mr19423223qtb.386.1625607383814; Tue, 06 Jul 2021 14:36:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF4o6UjuQFhkPoeHMMB81oLpuCKW4BOCASRCZpqzFjQi1IqeD9qzddmAtuM/tpsCYqMbmqdw== X-Received: by 2002:ac8:5bc8:: with SMTP id b8mr19423206qtb.386.1625607383621; Tue, 06 Jul 2021 14:36:23 -0700 (PDT) Received: from redhat.com ([2601:184:4780:4310::8e66]) by smtp.gmail.com with ESMTPSA id j7sm7403294qkd.21.2021.07.06.14.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 14:36:23 -0700 (PDT) Date: Tue, 6 Jul 2021 17:36:21 -0400 From: Marek Polacek To: Martin Sebor Cc: gcc mailing list Subject: Re: where is PRnnnn required again? Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 21:36:27 -0000 On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: > I came away from the recent discussion of ChangeLogs requirements > with the impression that the PRnnnn bit should be in the subject > (first) line and also above the ChangeLog part but doesn't need > to be repeated again in the ChangeLog entries. But my commit > below was rejected last Friday with the subsequent error. Adding > PR middle-end/98871 to the ChangeLog entry let me push the change: > > https://gcc.gnu.org/g:6feb628a706e86eb3f303aff388c74bdb29e7381 > > I just had the same error happen now, again with what seems like > a valid commit message. Did I misunderstand something or has > something changed recently? > > Martin > > commit 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 (HEAD -> master) > Author: Martin Sebor > Date: Fri Jul 2 16:16:31 2021 -0600 > > Improve warning suppression for inlined functions [PR98512]. > > Resolves: > PR middle-end/98871 - Cannot silence -Wmaybe-uninitialized at > declaration si > te > PR middle-end/98512 - #pragma GCC diagnostic ignored ineffective in > conjunct > ion with alias attribute This should be just PR middle-end/98871 PR middle-end/98512 , no? Either here, or... > gcc/ChangeLog: ...here. > * diagnostic.c (get_any_inlining_info): New. > (update_effective_level_from_pragmas): Handle inlining context. > (diagnostic_enabled): Same. > (diagnostic_report_diagnostic): Same. > * diagnostic.h (struct diagnostic_info): Add ctor. > (struct diagnostic_context): Add new member. > * tree-diagnostic.c (set_inlining_locations): New. > (tree_diagnostics_defaults): Set new callback pointer. > > > > Enumerating objects: 11, done. > Counting objects: 100% (11/11), done. > Delta compression using up to 16 threads > Compressing objects: 100% (6/6), done. > Writing objects: 100% (6/6), 3.37 KiB | 3.37 MiB/s, done. > Total 6 (delta 5), reused 0 (delta 0) > remote: *** The following commit was rejected by your > hooks.commit-extra-checker script (status: 1) > remote: *** commit: 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 > remote: *** ChangeLog format failed: > remote: *** ERR: PR 98512 in subject but not in changelog: "Improve warning > suppression for inlined functions [PR98512]." > remote: *** > remote: *** Please see: > https://gcc.gnu.org/codingconventions.html#ChangeLogs > remote: *** > remote: error: hook declined to update refs/heads/master > To git+ssh://gcc.gnu.org/git/gcc.git > ! [remote rejected] master -> master (hook declined) > error: failed to push some refs to > 'git+ssh://msebor@gcc.gnu.org/git/gcc.git' > Marek