From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 37D6F385842B for ; Fri, 20 May 2022 15:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37D6F385842B Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-588-LoZN5CthPDeY69_iwmiRPw-1; Fri, 20 May 2022 11:52:14 -0400 X-MC-Unique: LoZN5CthPDeY69_iwmiRPw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7273A1C04B54; Fri, 20 May 2022 15:52:14 +0000 (UTC) Received: from tucnak (unknown [10.39.192.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FF7EC50941; Fri, 20 May 2022 15:52:14 +0000 (UTC) Received: from tucnak (localhost [127.0.0.1]) by tucnak (8.17.1/8.17.1) with ESMTPS id 24KFqBLx003115 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 20 May 2022 17:52:11 +0200 Received: (from jakub@localhost) by tucnak (8.17.1/8.17.1/Submit) id 24KFm2e6002925; Fri, 20 May 2022 17:48:02 +0200 Resent-From: Jakub Jelinek Resent-Date: Fri, 20 May 2022 17:47:01 +0200 Resent-Message-ID: Resent-To: Mohamed Atef , gcc@gcc.gnu.org Date: Fri, 20 May 2022 17:46:17 +0200 From: Jakub Jelinek To: Mohamed Atef Cc: gcc@gcc.gnu.org Subject: Re: problem with Makefile.in generation in lingomp Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 15:52:20 -0000 On Fri, May 20, 2022 at 11:53:36AM +0200, Mohamed Atef wrote: > I use 1.15.1. > This is the link to the line I mentioned. > https://github.com/gcc-mirror/gcc/blob/master/libgomp/plugin/Makefrag.am#L29 You shouldn't be running autoreconf, just automake to regenerate Makefile.in, and when I run it, it certainly doesn't emit that error. Anyway, can you explain the https://gcc.gnu.org/g:c7a99c5953487c4dd6cdce1b01126ac2b06f16cd commit? That makes the branch quite useless. The point is that all commits pushed to gcc trunk have to have proper ChangeLog in the commit log to describe the actual changes in that commit. Commits aren't allowed to be pushed there unless they satisfy the checking. On development branches this isn't checked on commits, but if those branches are meant to be usable for commits to trunk later, they need to follow those rules (as I said, git gcc-verify should check it). I suppose the 8b5ad311eac66b0939a1e6473a46f68e31158bfe commit might have passed it, but I don't see how c7a99c5953487c4dd6cdce1b01126ac2b06f16cd could, you've used the same ChangeLog entry but that doesn't describe the changes you've done in that commit, you've reverted some Makefile.am changes (why?), removed the FSF Copyright lines (that is ok but it should have been replaced by the Copyright The GNU Toolchain Authors. line in that case), but the ChangeLog then would need to describe those changes. Jakub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 37F7D3856DC4 for ; Fri, 20 May 2022 15:52:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37F7D3856DC4 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-302-ZxD2Tb4jPrOk_pUYKN2viQ-1; Fri, 20 May 2022 11:52:14 -0400 X-MC-Unique: ZxD2Tb4jPrOk_pUYKN2viQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 72BA03C02182; Fri, 20 May 2022 15:52:14 +0000 (UTC) Received: from tucnak (unknown [10.39.192.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FF7B1121314; Fri, 20 May 2022 15:52:14 +0000 (UTC) Received: from tucnak (localhost [127.0.0.1]) by tucnak (8.17.1/8.17.1) with ESMTPS id 24KFqBLv003115 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 20 May 2022 17:52:11 +0200 Received: (from jakub@localhost) by tucnak (8.17.1/8.17.1/Submit) id 24KFjG1u002751; Fri, 20 May 2022 17:45:16 +0200 X-Authentication-Warning: tucnak: jakub set sender to jakub@redhat.com using -f Date: Fri, 20 May 2022 17:44:15 +0200 From: Jakub Jelinek To: Mohamed Atef Cc: gcc@gcc.gnu.org Subject: Re: problem with Makefile.in generation in lingomp Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 15:52:20 -0000 Message-ID: <20220520154415.3I6hE79ZJixEdcbTfSShwOoGMJ8XxuYk-JMwOZXXYUI@z> On Fri, May 20, 2022 at 11:53:36AM +0200, Mohamed Atef wrote: > I use 1.15.1. > This is the link to the line I mentioned. > https://github.com/gcc-mirror/gcc/blob/master/libgomp/plugin/Makefrag.am#L29 You shouldn't be running autoreconf, just automake to regenerate Makefile.in, and when I run it, it certainly doesn't emit that error. Anyway, can you explain the https://gcc.gnu.org/g:c7a99c5953487c4dd6cdce1b01126ac2b06f16cd commit? That makes the branch quite useless. The point is that all commits pushed to gcc trunk have to have proper ChangeLog in the commit log to describe the actual changes in that commit. Commits aren't allowed to be pushed there unless they satisfy the checking. On development branches this isn't checked on commits, but if those branches are meant to be usable for commits to trunk later, they need to follow those rules (as I said, git gcc-verify should check it). I suppose the 8b5ad311eac66b0939a1e6473a46f68e31158bfe commit might have passed it, but I don't see how c7a99c5953487c4dd6cdce1b01126ac2b06f16cd could, you've used the same ChangeLog entry but that doesn't describe the changes you've done in that commit, you've reverted some Makefile.am changes (why?), removed the FSF Copyright lines (that is ok but it should have been replaced by the Copyright The GNU Toolchain Authors. line in that case), but the ChangeLog then would need to describe those changes. Jakub