From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, pmladek@suse.com, gcc@gcc.gnu.org
Subject: Re: [PATCH] panic: suppress gnu_printf warning
Date: Mon, 8 Jan 2024 09:56:29 +0800 [thread overview]
Message-ID: <ZZtWTcK3enKIygWM@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240107102103.3c0ba0cfa4df37df4b59090e@linux-foundation.org>
On 01/07/24 at 10:21am, Andrew Morton wrote:
> On Sun, 7 Jan 2024 17:16:41 +0800 Baoquan He <bhe@redhat.com> wrote:
>
> > with GCC 13.2.1 and W=1, there's compiling warning like this:
> >
> > kernel/panic.c: In function ‘__warn’:
> > kernel/panic.c:676:17: warning: function ‘__warn’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > 676 | vprintk(args->fmt, args->args);
> > | ^~~~~~~
> >
> > The normal __printf(x,y) adding can't fix it. So add workaround which
> > disables -Wsuggest-attribute=format to mute it.
> >
> > ...
> >
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -666,8 +666,13 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> > pr_warn("WARNING: CPU: %d PID: %d at %pS\n",
> > raw_smp_processor_id(), current->pid, caller);
> >
> > +#pragma GCC diagnostic push
> > +#ifndef __clang__
> > +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
> > +#endif
> > if (args)
> > vprintk(args->fmt, args->args);
> > +#pragma GCC diagnostic pop
> >
> > print_modules();
>
> __warn() clearly isn't such a candidate. I'm suspecting that gcc's
> implementation of this warning is pretty crude. Is it a new thing in
> gcc-13.2?
Yeah, this isn't like other warnings in kernel. The compiler seems too
smart by look into the parameter 'args' of 'struct warn_args*'.
>
> A bit of context for gcc@gcc.gnu.org:
>
> struct warn_args {
> const char *fmt;
> va_list args;
> };
>
> ...
>
> void __warn(const char *file, int line, void *caller, unsigned taint,
> struct pt_regs *regs, struct warn_args *args)
> {
> disable_trace_on_warning();
>
> if (file)
> pr_warn("WARNING: CPU: %d PID: %d at %s:%d %pS\n",
> raw_smp_processor_id(), current->pid, file, line,
> caller);
> else
> pr_warn("WARNING: CPU: %d PID: %d at %pS\n",
> raw_smp_processor_id(), current->pid, caller);
>
> if (args)
> vprintk(args->fmt, args->args);
>
> print_modules();
>
> if (regs)
> show_regs(regs);
>
> check_panic_on_warn("kernel");
>
> if (!regs)
> dump_stack();
>
> print_irqtrace_events(current);
>
> print_oops_end_marker();
> trace_error_report_end(ERROR_DETECTOR_WARN, (unsigned long)caller);
>
> /* Just a warning, don't kill lockdep. */
> add_taint(taint, LOCKDEP_STILL_OK);
> }
>
next prev parent reply other threads:[~2024-01-08 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240107091641.579849-1-bhe@redhat.com>
2024-01-07 18:21 ` Andrew Morton
2024-01-08 1:56 ` Baoquan He [this message]
2024-01-09 13:25 ` Manuel López-Ibáñez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZtWTcK3enKIygWM@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gcc@gcc.gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).