From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id CA2753849AD9 for ; Fri, 19 Apr 2024 19:11:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA2753849AD9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA2753849AD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713553897; cv=none; b=KPIVmw/fkeN5Xerh7AKOvV175B773JmNBn/WCR1xIVOw3ghBoazT/xhY97gWZxULeBM61wpVvyDMsBArqHWqP6NWHgBDmK+Bs8lvI2dMeLcVkWWjX7hgpqZ4gRibY5HLPzBJYLk+sAfSvG6fa2z+HHUzks3H6INchlFr+F195VM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713553897; c=relaxed/simple; bh=uZQR5gAJWxxTRomGWaAi+ND97WDdKx767+eNE447nz4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=VfmcPZQ/PmIvmSESjxdIxp0SLdzDkvocwJOazd175bpmTw37E6KriHYTElVBafW/6NdFYei66NZWECM/a72T1HTOuR1Pb2gqDn0llWLwPcQUvvYS5FJyZ+tc6hf6JHwgSjEg197da0aJwFbB6zLL60S0v6Tw5+9Bw3IsNmSR3vI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-419ca3f3dd0so5238435e9.2 for ; Fri, 19 Apr 2024 12:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713553893; x=1714158693; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9Qr6H2rGHJBT77arFG47kL01cXxq/qUcPfIr0ORwKcg=; b=Y6nd6VIAq28NFVTdjBluZpmPwkooejy54W5jk7q4WXZAxsb63YadBwaQiw9YelBoz2 Sb2l4v33qRk6oHcXyXgfiP6mEFOc+XakK9C57D3ZK3jSuBeKlASWky8GibTTu/cBvLHe G83goRRiFG835ueJndx26q/slHctqzvE4n8952/jNzK9Kx8Q1VQA95QfzcO7zX17TnIp harbePTHshIOGJDr+pgDVov9AJEmSEwgingUezcO6ryrbM6tKT6V/klmE/ak/BnOc1v9 u/doZeGuKXp7QftnnUnybiKyfaII6ii10Bzk4heB2X/rBU748T5K2bCHbvKPHx2CqFd0 vNZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713553893; x=1714158693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9Qr6H2rGHJBT77arFG47kL01cXxq/qUcPfIr0ORwKcg=; b=WWYI2SflHCxnx9HmSI3F/LcOgrFE+jLKXWXDMe2uX38pJ4BSNSFbK9Bmubuorr76cR noysiOEhatGBnRGrBHQnPAqXdIu7pbkKa4eoXUCNLziDxeAtBXtGGF7rbvlMFbQSkz1n Ob7JVkT0eyLpf2CEyWKOjhcDT+EARc/teFv0tDH/ipm24sgFoU6fv4NHLgWPL9aX/FSj VeLNHNNzKgJilqt9cPFUb8GJKf92Xd313gCYeb7yP12Glj50dK/pffqRBG2uqXdIMD2m Lz789svEom309mi5aww4/ChnOIHNukmvKZerqmXiXOkSkOrZ74c+cxlM3DuIzQJ/ZfwO ED/A== X-Forwarded-Encrypted: i=1; AJvYcCVYs/41wZ35Y5MObiR2lU7FgOBHQ6u1t99+Vvd+6Xjloco7RBUfLaWDWJeAd/Qj+M9VEJHrl0iIZYZAVsPRu9A= X-Gm-Message-State: AOJu0Yy7CXmmF0TDnIDn09Ip9cuwcEZDw6TxD4Xywh5s2aTNSTkz87N+ I5UaBHDg2rK97xngMqPxgIBcdNNssf2m8ZpVLYGHI1aVN0w+kM5opyBZ6EQ17NtPO9hJ6tQZGr6 H X-Google-Smtp-Source: AGHT+IFQFVd3LgDZ2c4H0C4IVnc48Tqm2Rz1N1iN3ghBPnz6q19cxzZxq1YtOTOLIxkG7B09M4dkRg== X-Received: by 2002:a05:600c:4ecb:b0:418:e7b6:21de with SMTP id g11-20020a05600c4ecb00b00418e7b621demr2649628wmq.23.1713553892743; Fri, 19 Apr 2024 12:11:32 -0700 (PDT) Received: from takamaka.gnat.com ([37.169.59.190]) by smtp.gmail.com with ESMTPSA id s9-20020a05600c45c900b004170e0aff7asm11229011wmo.35.2024.04.19.12.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 12:11:32 -0700 (PDT) Received: by takamaka.gnat.com (Postfix, from userid 1000) id B445F8188D; Fri, 19 Apr 2024 12:11:26 -0700 (PDT) Date: Fri, 19 Apr 2024 12:11:26 -0700 From: Joel Brobecker To: "Frank Ch. Eigler" Cc: brobecker@adacore.com, gdb@sourceware.org, gcc@gcc.gnu.org Subject: Re: adacore git-hooks - daemon-mode email vs. systemd-logind linger Message-ID: References: <20240416105622.GD1423@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416105622.GD1423@redhat.com> X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Frank, > - just send the emails immediately, without the daemon stuff; if the > delays are there to try to sequentialize them, consider instead > getting the hooks to emit Message-Id:/In-Reply-To:/Date: headers to > let MUA's sort properly at reception We can certainly add a non-daemon mode to the hooks. I don't know when I'd have time to work on this enhancement, unfortunately. > - invoke the email sending wrapped in a "systemd-run --user" > deferred execution gadget, including a "sleep XXX" if you must > keep time-hope-based sequencing > > - move email stuff entirely out of the hooks; these repos are "public > property" anyhow, and we can put cron jobs in place elsewhere to > trigger email notifications about commits; heck, they could run the > hook code itself later, just feed it retrospective git-hook lines You can configure the hooks to turn emailing off completely. From memory, this triggers a warning message on the user end when they do the push, just to let them know to not expect emails. The downside of going this way, other than the minor annoyance above, is that you lose track of who did the push. Right now, the emails allows you to derive the information from the emails' from field. Thinking more long term, I think there are talks about using a more comprehensive system for source and contribution management, similar to products such as GitLab or GitHub. Those will likely come with they own set of tooling for things such as alerting, pre-commit checks, keeping track of who submitted, who reviewed and approved, and who pushed. That's why I tend to think that, for the moment, I'd go the simplest route overall: In this case, I think the simplest is to just have a way to disable the daemon mode, and just have the users wait. In the vast majority of cases, the wait will be a few seconds. Even with a patch-series of a 100 patches, it would mean a 1min40s wait. Very bearable. If you agree, we can create an issue for it on the git-hooks repoisitory on GitHub. -- Joel