From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by sourceware.org (Postfix) with ESMTPS id 1545B3858C39 for ; Thu, 14 Mar 2024 11:30:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1545B3858C39 Authentication-Results: sourceware.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cloud.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1545B3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710415817; cv=none; b=x71EcvbxMeSWiBiLF9QXnxNyGnU3eNG4dPIray4qILXv+VnjUvaoqFCFouNYF91BrJw5PjxUurjLd8E8W6v4UuQfltYD/V1FB1UBMl/fXRR4zD4hCZ5UOeXVA7Hc9vggU6qJEFR+i1kd+fVJZ7qFh8WEOX7P5D/zgzgw8fFMvtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710415817; c=relaxed/simple; bh=GEvVjH6btUfm2GzGY/0kA5x/deelf0aWLVf863sly2c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=d5fVdcoKr7spIq1hakBDTSfpF5B1L9JgsAgxUYs4JFhqM1S8+ljHc/OhKCg0UjN+d8bxWO8TiH6cvkWYL2EJUKWEu9eIMbwqUE8DZYWOTLGGKN+8SdvDj7HgS3beB6v+CZoNTcSyD40p7MW6bom6kUpA4BNQXdbDTdxXG6BF21s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-68ee2c0a237so6490276d6.1 for ; Thu, 14 Mar 2024 04:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1710415815; x=1711020615; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fkaEQeTGNZPByDPXp1uhAhKG0Vx5XgUqiAcsZ8EA7wY=; b=jSdE3aB6fFmYKoSujZ5okXd99UTA6tP5u0QN2L7Nk3omZTyVNW/h2j6SUDplRiIkSo 4g1OnXCCcYvz7rRoHthsnUorT83SY/KNI/xPDKPIhOgZgLKJyzNWUoSaJ4aMHgwbDtWK G6ftLuK5CgEM6MBXouuWpvXsQY+8KTpu+W+bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710415815; x=1711020615; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fkaEQeTGNZPByDPXp1uhAhKG0Vx5XgUqiAcsZ8EA7wY=; b=gZnE6AE3+s69bw+mHl1SQCqDE3Aztade0nHediEkGuBTW78B2DbXtsJyblRKWLTZOf K+EPWaLYQczo46TSEKp8hJgnaqQi68gwwnHoZp80LQ3fWsPWoQv1UHbqZ3oTqx05YYUb g2exR7BMrhDCyEgd0RnSBrlEvowp0uIzrH+nN0IaWYaJX4vLsWbKgM2mvycDEkcTGBFI /H+cnlAl+41K5RN5Mw/+GJD+KkRYuE+j8l8FDttFnBnhUqOPW7ltfwyD6oeEbSa+lQ0D UnYVlwIJ+c2UpmpDjQZ86eFkMaWd87aTpqmttel+tCryx+faSE0bmpXhP8QNmAGow2fu ZZng== X-Gm-Message-State: AOJu0YxaSAdYoY5QVeRv72KquyxV+CkiHGHfH21vGo8tafvB2PxjC8Ye 0DADhkeNYVX2roLJCIB9qknNNRs7ZPsdWhjW7cpvtbyJT9fhzN7qgObLi5R8XXo= X-Google-Smtp-Source: AGHT+IH7sSwWnRRDGHfg7bZuShuntTFLpNYxqyQbOneE45+QzDB9WW5I8enaVtZX6U8HuURMK7H/3g== X-Received: by 2002:a05:6214:1d0d:b0:691:14c3:b8f6 with SMTP id e13-20020a0562141d0d00b0069114c3b8f6mr3902646qvd.18.1710415815380; Thu, 14 Mar 2024 04:30:15 -0700 (PDT) Received: from [10.80.67.149] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id mk21-20020a056214581500b006915ddbbb71sm221809qvb.78.2024.03.14.04.30.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 04:30:14 -0700 (PDT) Message-ID: Date: Thu, 14 Mar 2024 11:30:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Builtin for consulting value analysis (better ffs() code gen) Content-Language: en-GB To: Alexander Monakov Cc: gcc@gcc.gnu.org References: <06d7af49-c4a9-43d5-a18f-266439c7f82d@citrix.com> <12b2c99d-993d-ba8d-75ff-b107de2eba67@ispras.ru> From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <12b2c99d-993d-ba8d-75ff-b107de2eba67@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/03/2024 6:04 am, Alexander Monakov wrote: > On Thu, 14 Mar 2024, Andrew Cooper via Gcc wrote: > >> I suppose that what I'm looking for is something a little like >> __builtin_constant_p() which can either be used in a straight if(), or >> in a __builtin_choose_expr(). >> >> Anyway - is there a way of doing this that I've managed to overlook? > I am missing what is lacking for you with __builtin_constant_p, I would > do it like this: > > unsigned ffs(unsigned x) > { > unsigned res; > unsigned nonzero = x != 0; > if (__builtin_constant_p(nonzero) && nonzero) > asm("bsf %1, %0" : "=r"(res) : "rm"(x)); > else { > res = -1; > asm("bsf %1, %0" : "+r"(res) : "rm"(x)); > } > return res; > } Oh - so it does.  I'd not considered that expressing it like that would still work. > > or with handling known-zero-input case like this: > > unsigned ffs(unsigned x) > { > unsigned res; > unsigned nonzero = x != 0; > if (!__builtin_constant_p(nonzero)) { > res = -1; > asm("bsf %1, %0" : "+r"(res) : "rm"(x)); > } else if (nonzero) { > asm("bsf %1, %0" : "=r"(res) : "rm"(x)); > } else { > res = -1; > } > return res; > } > > > Does it work for you? I simplified things when asking the question.  The real implementation has a general     if (__builtin_constant_p(x))         return __builtin_ffs(x); so any known-constant value can be folded.  What I'm dealing with is the remainder of the cases. Anyway - thankyou for your help. ~Andrew