From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2F0B73858D28 for ; Tue, 1 Aug 2023 17:06:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F0B73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690909598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kwzL+LVDsaRY6t1Ngn0YonuB7+i1UkPJuOIPukn0TnA=; b=QJJRHnxIxb8e0bbSxkgC5RWJX4SljA2L5eH+dyE3d2rKujnC/eG5o2u3p7s8gA+Qcdbphx xSYrU1JCPyQdn/KvLI/k+1pbvmoN+SzKhFjeyvvxSx84qzztE59LP+7l2Ssur9tCCvx4OM 21ZWWUOJauu+fLS5gcjfGQcUe3mRbe0= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-H5_SFH6KM2ueWaEmkCbXvQ-1; Tue, 01 Aug 2023 13:06:37 -0400 X-MC-Unique: H5_SFH6KM2ueWaEmkCbXvQ-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3a3df1d46e5so10097554b6e.3 for ; Tue, 01 Aug 2023 10:06:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690909596; x=1691514396; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kwzL+LVDsaRY6t1Ngn0YonuB7+i1UkPJuOIPukn0TnA=; b=QEe28mdnCuHkQMjpfl8Cgg+dGn+7anNSKMORyDk5FBEFc8A63qD8CUPriX7ayH1CuB FU2WuZXlHN500BcPKt6R1/dvlGxPs/gkQkY0Y898c47aRrspCz1LCVH4X+Bp3w3iD4nI pys3Ud+D704sWUkAH2NB/Kf8HT74OWttX9GecSVul6hkwasZkHYcQbjW0Pvy1KQGmXDx 2+2sMZl7QjCbHgtS2Vlc51PbTdIhiPSB3K/9Z500d4njBDUeS03w1DjGNgIhE4NS5HsT kM73WcidO+gDQjsaKb7oVc0odzOHWs5ddFnsww6swu39KgNK8FKyh97QD2zmE6Tm9wPb QxpA== X-Gm-Message-State: ABy/qLYHNWvjCX/w3z7qyYUcV0bJwRYB5kFn2klCtMaYVn7QY0aNI3a9 2kXp9eCrV4t+IZbrfAFkzbGxUb2Vjh3suuu4U90gnJEQIoZE2y3qhBbVK7s617XXCHMhVo5HEgy UEHQCAhg= X-Received: by 2002:a05:6808:ddd:b0:3a4:2204:e9e6 with SMTP id g29-20020a0568080ddd00b003a42204e9e6mr13306306oic.21.1690909596734; Tue, 01 Aug 2023 10:06:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlEZEuAz/mWd6IDXCqvj/48RB+yr1HTGofeQk9s54iXcY1TEI1fWqypc1XSKOYWQ3YXJ0290bw== X-Received: by 2002:a05:6808:ddd:b0:3a4:2204:e9e6 with SMTP id g29-20020a0568080ddd00b003a42204e9e6mr13306284oic.21.1690909596451; Tue, 01 Aug 2023 10:06:36 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id p7-20020a0ccb87000000b0063d3744c5c5sm4737707qvk.5.2023.08.01.10.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 10:06:35 -0700 (PDT) Message-ID: Subject: Re: Update and Questions on CPython Extension Module -fanalyzer plugin development From: David Malcolm To: Eric Feng Cc: gcc@gcc.gnu.org Date: Tue, 01 Aug 2023 13:06:35 -0400 In-Reply-To: References: <969057b59e5cf472b73e8e1dedcc4a46630b31a0.camel@redhat.com> <6050a30719fed76a5bdb36c00620f4cb44e00aad.camel@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-08-01 at 09:57 -0400, Eric Feng wrote: > >=20 > > My guess is that you were trying to do it from the > > PLUGIN_ANALYZER_INIT > > hook rather than from the plugin_init function, but it's hard to be > > sure without seeing the code. > >=20 >=20 > Thanks Dave, you are entirely right =E2=80=94 I made the mistake of tryin= g to > do it from PLUGIN_ANALYZER_INIT hook and not from the plugin_init > function. After following your suggestion, the callbacks are getting > registered as expected.=C2=A0 Ah, good. > I submitted a patch to review for this feature > on gcc-patches; please let me know if it looks OK. Thanks Eric; I've posted a reply to your email there, so let's discuss the details there. Dave