From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-169742-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 26902 invoked by alias); 6 Aug 2011 15:33:13 -0000
Received: (qmail 26894 invoked by uid 22791); 6 Aug 2011 15:33:13 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail1-relais-roc.national.inria.fr (HELO mail1-relais-roc.national.inria.fr) (192.134.164.82)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 06 Aug 2011 15:32:49 +0000
Received: from afontenayssb-151-1-40-125.w83-114.abo.wanadoo.fr (HELO laptop-mg.local) ([83.114.90.125])  by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 Aug 2011 17:32:47 +0200
Date: Sat, 06 Aug 2011 15:33:00 -0000
From: Marc Glisse <marc.glisse@inria.fr>
Reply-To: gcc@gcc.gnu.org
To: Andreas Schwab <schwab@linux-m68k.org>
cc: Basile Starynkevitch <basile@starynkevitch.net>, gcc@gcc.gnu.org
Subject: Re: autogen version testing in fixincludes/genfixes
In-Reply-To: <m2k4cwf69b.fsf@igel.home>
Message-ID: <alpine.DEB.2.02.1108061717110.7897@laptop-mg.saclay.inria.fr>
References: <20110608082914.76c339f2.basile@starynkevitch.net> <m3boy8eog7.fsf@redhat.com> <20110608202921.b98c1302.basile@starynkevitch.net> <m2zklsf94s.fsf@igel.home> <20110608213956.63f3e29b.basile@starynkevitch.net> <m2k4cwf69b.fsf@igel.home>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
X-SW-Source: 2011-08/txt/msg00149.txt.bz2

On Wed, 8 Jun 2011, Andreas Schwab wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
>
>> And I also believe that the minuscule patch I am proposing in
>> http://gcc.gnu.org/ml/gcc/2011-06/msg00081.html
>> should work on your system too. Could you try it please?
>
> That's not the point.  The point is, if you patch, you should do it
> right.

Hello,

so what's the right way to do it?
(the number of people using 5.12 is increasing, we have to fix it)

1) not test autogen at all. It will fail if it has to fail. Besides,
    nobody has autogen 4.* anymore.
2) instead of grepping Ver. 5., grep for " 5." or GNU, or grep -v for
    " [0-4]".
3) something else.

-- 
Marc Glisse