Strange changes triggered by --enable-maintainer-mode

Strange changes triggered by --enable-maintainer-mode

[Thomas Koenig]

Hi,

I recently had occastion to use --enable-maintainer-mode after the
change to autoconf 2.69 / automake 1.15.1.

This led to two changes in libgfortran/configure. First, an option
"runstatedir" was removed (whatever this does, or is). Second, the
definition of a macro LARGE_OFF_T was changed.

I am a bit concrend about these changes. Using the same tools
should lead to the same results, right?  And what should I do
if I wanted to actually commit a patch which incudes wanted
changes to libgfortran/configure ?

Regards

	Thoams

Index: libgfortran/configure
===================================================================
--- libgfortran/configure       (Revision 267172)
+++ libgfortran/configure       (Arbeitskopie)
@@ -780,7 +780,6 @@ infodir
  docdir
  oldincludedir
  includedir
-runstatedir
  localstatedir
  sharedstatedir
  sysconfdir
@@ -871,7 +870,6 @@ datadir='${datarootdir}'
  sysconfdir='${prefix}/etc'
  sharedstatedir='${prefix}/com'
  localstatedir='${prefix}/var'
-runstatedir='${localstatedir}/run'
  includedir='${prefix}/include'
  oldincludedir='/usr/include'
  docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
@@ -1124,15 +1122,6 @@ do
    | -silent | --silent | --silen | --sile | --sil)
      silent=yes ;;

-  -runstatedir | --runstatedir | --runstatedi | --runstated \
-  | --runstate | --runstat | --runsta | --runst | --runs \
-  | --run | --ru | --r)
-    ac_prev=runstatedir ;;
-  -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \
-  | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \
-  | --run=* | --ru=* | --r=*)
-    runstatedir=$ac_optarg ;;
-
    -sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb)
      ac_prev=sbindir ;;
    -sbindir=* | --sbindir=* | --sbindi=* | --sbind=* | --sbin=* \
@@ -1270,7 +1259,7 @@ fi
  for ac_var in  exec_prefix prefix bindir sbindir libexecdir datarootdir \
                 datadir sysconfdir sharedstatedir localstatedir 
includedir \
                 oldincludedir docdir infodir htmldir dvidir pdfdir psdir \
-               libdir localedir mandir runstatedir
+               libdir localedir mandir
  do
    eval ac_val=\$$ac_var
    # Remove trailing slashes.
@@ -1423,7 +1412,6 @@ Fine tuning of the installation directories:
    --sysconfdir=DIR        read-only single-machine data [PREFIX/etc]
    --sharedstatedir=DIR    modifiable architecture-independent data 
[PREFIX/com]
    --localstatedir=DIR     modifiable single-machine data [PREFIX/var]
-  --runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]
    --libdir=DIR            object code libraries [EPREFIX/lib]
    --includedir=DIR        C header files [PREFIX/include]
    --oldincludedir=DIR     C header files for non-gcc [/usr/include]
@@ -12696,7 +12684,7 @@ else
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 12699 "configure"
+#line 12687 "configure"
  #include "confdefs.h"

  #if HAVE_DLFCN_H
@@ -12802,7 +12790,7 @@ else
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 12805 "configure"
+#line 12793 "configure"
  #include "confdefs.h"

  #if HAVE_DLFCN_H
@@ -16051,7 +16039,7 @@ else
      We can't simply define LARGE_OFF_T to be 9223372036854775807,
      since some C++ compilers masquerading as C compilers
      incorrectly reject 9223372036854775807.  */
-#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) 
<< 31))
+#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
    int off_t_is_large[(LARGE_OFF_T % 2147483629 == 721
                        && LARGE_OFF_T % 2147483647 == 1)
                       ? 1 : -1];
@@ -16097,7 +16085,7 @@ else
      We can't simply define LARGE_OFF_T to be 9223372036854775807,
      since some C++ compilers masquerading as C compilers
      incorrectly reject 9223372036854775807.  */
-#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) 
<< 31))
+#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
    int off_t_is_large[(LARGE_OFF_T % 2147483629 == 721
                        && LARGE_OFF_T % 2147483647 == 1)
                       ? 1 : -1];
@@ -16121,7 +16109,7 @@ rm -f core conftest.err conftest.$ac_objext confte
      We can't simply define LARGE_OFF_T to be 9223372036854775807,
      since some C++ compilers masquerading as C compilers
      incorrectly reject 9223372036854775807.  */
-#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) 
<< 31))
+#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
    int off_t_is_large[(LARGE_OFF_T % 2147483629 == 721
                        && LARGE_OFF_T % 2147483647 == 1)
                       ? 1 : -1];
@@ -16166,7 +16154,7 @@ else
      We can't simply define LARGE_OFF_T to be 9223372036854775807,
      since some C++ compilers masquerading as C compilers
      incorrectly reject 9223372036854775807.  */
-#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) 
<< 31))
+#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
    int off_t_is_large[(LARGE_OFF_T % 2147483629 == 721
                        && LARGE_OFF_T % 2147483647 == 1)
                       ? 1 : -1];
@@ -16190,7 +16178,7 @@ rm -f core conftest.err conftest.$ac_objext confte
      We can't simply define LARGE_OFF_T to be 9223372036854775807,
      since some C++ compilers masquerading as C compilers
      incorrectly reject 9223372036854775807.  */
-#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) 
<< 31))
+#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
    int off_t_is_large[(LARGE_OFF_T % 2147483629 == 721
                        && LARGE_OFF_T % 2147483647 == 1)
                       ? 1 : -1];

Re: Strange changes triggered by --enable-maintainer-mode

[Rainer Orth]

Hi Thomas,


> I recently had occastion to use --enable-maintainer-mode after the
> change to autoconf 2.69 / automake 1.15.1.
>
> This led to two changes in libgfortran/configure. First, an option
> "runstatedir" was removed (whatever this does, or is). Second, the
> definition of a macro LARGE_OFF_T was changed.
>
> I am a bit concrend about these changes. Using the same tools
> should lead to the same results, right?  And what should I do
> if I wanted to actually commit a patch which incudes wanted
> changes to libgfortran/configure ?

I haven't looked for the LARGE_OFF_T issue, but runstatedir isn't in
vanilla autoconf 2.69, but was added sometime later.  Obviously the
configure etc. files were generated with some modified version of
autoconf 2.69.

In a similar case (libphobos), I've simply regenerated all files with
unmodifed self-built versions of autoconf 2.69 and automake 1.15.1.  I
suspect some Linux distibutions see fit to ship those
between-2.69-and-2.70 versions without any indication what they're
doing...

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Strange changes triggered by --enable-maintainer-mode

[Joseph Myers]

On Sat, 15 Dec 2018, Rainer Orth wrote:

> In a similar case (libphobos), I've simply regenerated all files with
> unmodifed self-built versions of autoconf 2.69 and automake 1.15.1.  I

That's also what I did when updating the autoconf / automake versions used 
in GCC.

-- 
Joseph S. Myers
joseph@codesourcery.com