From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-199994-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 101388 invoked by alias); 22 Aug 2019 17:00:03 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 100735 invoked by uid 89); 22 Aug 2019 17:00:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:_kEuMVL, H*f:sk:_kEuMVL, HX-Languages-Length:520
X-HELO: esa3.mentor.iphmx.com
Received: from esa3.mentor.iphmx.com (HELO esa3.mentor.iphmx.com) (68.232.137.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Aug 2019 17:00:01 +0000
IronPort-SDR: ONb73WwytVUkypRtJS91YCSXpfDi7MZkd4kf3z65fdt0h2ljpRON4Wgr7nSxJNY39BBa3XmJbJ kfBEk6GLlChSGHR/CxKC4P74D0wN46gGi7+32u33pcBpLtBc/6HIiunYo+4RtaQA7te6dewi3s Xe7bfqb9J3v+cP40ZFpUU7jfN7rdNXPS/agZT6OhZheqb43Vrbr5K7MVMy/Feq+X2cFynxLbac hcaNUQyt+FaDFBU8240kFc4Ko1yBJYVB03ecU479qU8m1x3hsKINx0Z0PHJ5KnRMlScRnQspwr 3dU=
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])  by esa3.mentor.iphmx.com with ESMTP; 22 Aug 2019 08:59:59 -0800
IronPort-SDR: UgChZCUBw4slF8uCgfJZzLRUeKm5eIt+rqGgt7KrAHTEuAFkFFbKDR8BWaV310HkkB9Jd51z8e MtrqGJdK07pbjCldjaTpgE76LuIEfdjS/sjUUR81Fd+H3yd23IoO+ZL9GbmeQqPSquNdbWX9SN LwoShN9BEo50iLFB3gehRIBa/M0zA3xOICQJeODOWvDOh5R8+yb7T6zgX4O/ilRTJMnfGd8y9m ZcjauJrvEE3gLGa/lCb9Icfwk4iRf3UYLkLMOaZT/a9qihthhfT9rCsHjeZdaSYYbHmK2reJFw 5Ao=
Date: Thu, 22 Aug 2019 17:00:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Tejas Joshi <tejasjoshi9673@gmail.com>
CC: <gcc@gcc.gnu.org>, Martin Jambor <mjambor@suse.cz>, <hubicka@ucw.cz>
Subject: Re: [PATCH] Builtin function roundeven folding implementation
In-Reply-To: <CACMrGjDFMFPRckKC-rx7-LRPXBou-O_xV=_kEuMVL4BSMSKkew@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.1908221659330.29112@digraph.polyomino.org.uk>
References: <CACMrGjCu54zN+Smc7+3JF8MBZV76HXwaP-vk1HFTQGhRc=Toww@mail.gmail.com> <alpine.DEB.2.21.1908092021090.31221@digraph.polyomino.org.uk> <CACMrGjCPNr+Hjz--CL6ocV5y3GqGp13fpQCXtXJT4qeGQWk86A@mail.gmail.com> <ri636hug2zr.fsf@suse.cz> <alpine.DEB.2.21.1908211156360.6172@digraph.polyomino.org.uk> <ri6pnkye7ll.fsf@suse.cz> <alpine.DEB.2.21.1908211906340.25161@digraph.polyomino.org.uk> <ri6ftlte12y.fsf@suse.cz> <alpine.DEB.2.21.1908221426570.27000@digraph.polyomino.org.uk> <CACMrGjCUbFja_j_gUquQuAO=HKam9j-R5+-cjde+_eWsfDs+XA@mail.gmail.com> <alpine.DEB.2.21.1908221633440.29112@digraph.polyomino.org.uk> <CACMrGjDFMFPRckKC-rx7-LRPXBou-O_xV=_kEuMVL4BSMSKkew@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Return-Path: joseph@codesourcery.com
X-SW-Source: 2019-08/txt/msg00188.txt.bz2

On Thu, 22 Aug 2019, Tejas Joshi wrote:

> > I think you should have at least four tests of sign of zero result
> > (arguments -0.5, -0.0, 0.0 and 0.5).  Probably also tests of values
> > between +/- 0.5 and 0, e.g. test -0.25 and 0.25 as well.
> 
> Okay, I have made the following changes and again, the tests pass for roundeven.

Thanks, I look forward to seeing a full patch with these revisions on 
gcc-patches.

-- 
Joseph S. Myers
joseph@codesourcery.com