From: Joseph Myers <joseph@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
<gcc@gcc.gnu.org>
Subject: Re: gcc-cvs mails for personal/vendor branches for merge commits
Date: Thu, 16 Jan 2020 18:58:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2001161431290.18540@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20200116114002.GB13162@adacore.com>
On Thu, 16 Jan 2020, Joel Brobecker wrote:
> emails are to be sent. This happens for instance when people used
> development branches that they had silenced so as to avoid spamming
> people. And because they have been rebasing their branch regularly,
> the "merge" ended up being a fast-forward. And because it was a fast
> forward, the hooks saw that the commits were already known to the
> repository, and no email was sent at all for those new commits.
The approach used by post-receive-email is to send a summary email but
without resending the already-sent commits. That seems appropriate to me.
> Beyond this specific issue of users being surprised about the missing
> emails, we thought about it more, and it seemed logical that we would
> want a trace for each branch a commit makes it to. It's an essential
> element of being able to track where a given commit was applied.
A summary email just listing the commits merged seems much better than
sending email maybe dozens of times for every commit to master.
> Typically, branches were non-fast-forward changes are allowed are
> branches that are personal and not shared. In those instances,
> the typical setup is to disable emails on those development branches.
> It sounds to me like turning emails off for branches that can
> do non-fast-forward is the better solution here.
I think it's desirable for development that *happens on* the personal and
vendor branches to be visible in gcc-cvs - that is different from things
getting merged into them.
Likewise for the refs/heads/devel/* development branches -
non-fast-forward pushes are not permitted there, but such branches can
expect to have lots of merges from master, and it's the actual development
taking place *on* the branches - the new commits - that is of interest to
see on gcc-cvs, not the merging of existing commits.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-01-16 14:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:07 Jakub Jelinek
2020-01-15 15:42 ` Joseph Myers
2020-01-15 15:51 ` Jakub Jelinek
2020-01-15 16:01 ` Joseph Myers
2020-01-15 16:42 ` Jason Merrill
2020-01-15 16:58 ` Joseph Myers
2020-01-15 17:09 ` Jason Merrill
2020-01-15 17:57 ` Iain Sandoe
2020-01-15 20:20 ` Jason Merrill
2020-01-19 14:10 ` Segher Boessenkool
2020-01-19 22:40 ` Julien "_FrnchFrgg_" Rivaud
2020-01-20 18:42 ` Segher Boessenkool
2020-01-15 19:21 ` Richard Earnshaw (lists)
2020-01-16 9:55 ` Joseph Myers
2020-01-16 14:28 ` Joel Brobecker
2020-01-16 14:35 ` Jakub Jelinek
2020-01-16 14:43 ` Richard Earnshaw (lists)
2020-01-16 18:51 ` Jakub Jelinek
2020-01-16 22:03 ` Joseph Myers
2020-01-16 18:58 ` Joseph Myers [this message]
2020-01-17 16:47 ` Joel Brobecker
2020-01-17 17:22 ` Iain Sandoe
2020-01-17 17:59 ` Joel Brobecker
2020-01-17 19:15 ` Jason Merrill
2020-01-17 22:39 ` Joel Brobecker
2020-01-18 9:50 ` Iain Sandoe
2020-01-18 11:07 ` Jason Merrill
2020-01-18 14:30 ` Joseph Myers
2020-01-17 17:23 ` Joseph Myers
2020-01-17 21:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001161431290.18540@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Richard.Earnshaw@arm.com \
--cc=brobecker@adacore.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).