From: Gerald Pfeifer <gerald@pfeifer.com>
To: Michael Eager <eager@eagerm.com>
Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org
Subject: Re: PING -- MicroBlaze target support patches
Date: Sat, 10 Jul 2010 18:04:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.1007102001100.5661@acrux.dbai.tuwien.ac.at> (raw)
In-Reply-To: <4BEB0738.5060704@eagerm.com>
On Wed, 12 May 2010, Michael Eager wrote:
> Could someone please review these patches?
>
> Add support for Xilinx MicroBlaze processor:
>
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01903.html
This is okay with three small changes.
Please use "Do not" instead of "Don't" in invoke.texi.
Use proper markup for -fno-zero-initialized-in-bss in the same.
Similarly, please use @var in
Supported values are in the format vX.YY.Z, where X is a major version,
YY is the minor version, and Z is compatiblity code.
in invoke.texi.
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01905.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01908.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01907.html
These three I cannot review/approve, but the strike me as pretty
straightforward, not touching lots of core code? Where are we
regarding this? Is this stuck somewhere?
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01906.html
This is fine, too. For the announcement on the main page, let's say
"processor" (lower case) and there is a closing </p> missing on the
changes.html page.
Good work!
Gerald
prev parent reply other threads:[~2010-07-10 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 19:53 Michael Eager
2010-07-10 18:04 ` Gerald Pfeifer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1007102001100.5661@acrux.dbai.tuwien.ac.at \
--to=gerald@pfeifer.com \
--cc=eager@eagerm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).