From: Richard Biener <rguenther@suse.de>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
Jakub Jelinek <jakub@redhat.com>,
Alexander Ivchenko <aivchenk@gmail.com>, gcc <gcc@gcc.gnu.org>
Subject: Re: [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
Date: Tue, 03 Sep 2013 07:48:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.1309030947430.20077@zhemvz.fhfr.qr> (raw)
In-Reply-To: <CAGWvnymo7FGXFtPSPXkvkYiYN5eJSi+sk+xuQEdpSOGUqedysA@mail.gmail.com>
On Mon, 2 Sep 2013, David Edelsohn wrote:
> On Mon, Sep 2, 2013 at 5:28 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > Hi!
> >
> > On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> >> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> >> > I certainly missed that OPTION_BIONIC is not defined for linux targets
> >> > that do not include config/linux.h in their tm.h.
> >> >
> >> > This patch fixed build for powerpc64le-linux and mn10300-linux.
> >> > linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
> >> [...]
> >>
> >> It would be nice if somebody would review this patch. The initial
> >> commit had fallout on a few targets:
> >>
> >> alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537&mode=view
> >> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
> >> sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655&mode=view
> >> tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647&mode=view
> >> powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638&mode=view
> >> (all other PPC variants, too.)
> >
> > This is still broken. Today it's two weeks. Can we please have the
> > patch ACKed or revert the patch?
>
> I agree. This is ridiculous. Would some global reviewer please approve the fix?
Patch is ok.
_Please_ mark patches properly and send them in a separate thread.
Otherwise I just notice [buildbot] and skip the mail. A proper
subject would be [PATCH] Unbreak bootstrap on XYZ
Richard.
next prev parent reply other threads:[~2013-09-03 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 17:43 Jan-Benedict Glaw
2013-08-20 10:57 ` Alexander Ivchenko
2013-08-21 14:54 ` [buildrobot] .../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ " Jan-Benedict Glaw
2013-08-26 16:19 ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
2013-09-02 21:28 ` [ping^2] " Jan-Benedict Glaw
2013-09-02 22:10 ` David Edelsohn
2013-09-03 7:48 ` Richard Biener [this message]
2013-09-06 13:31 ` [ping] " Jan-Benedict Glaw
2013-09-10 0:01 ` Maxim Kuvyrkov
2013-09-10 10:07 ` Jan-Benedict Glaw
2013-09-10 22:10 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1309030947430.20077@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=aivchenk@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jbglaw@lug-owl.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).