public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: gcc@gcc.gnu.org
Subject: Re: [PATCH] RISC-V documentation cleanups
Date: Tue, 14 Mar 2017 20:29:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.20.1703142125300.3498@anthias.pfeifer.com> (raw)
In-Reply-To: <20170313173933.5524-2-palmer@dabbelt.com>

On Mon, 13 Mar 2017, Palmer Dabbelt wrote:
> A recent mailing list post about install.texi cleanup suggested I 
> take a look at ours, and there were a few problems:
> 
>  * No table of contents entries
>  * Not alphabetically ordered
>  * Missing a note about requiring binutils-2.28

This looks fine with a few changes, thank you.

Perhaps a bit repetitive?  I'm wondering, would it make sense to 
have general riscv64-*-* entries that cover the general items?

> 2017-03-13  Palmer Dabbelt  <palmer@dabbelt.com
> 
>         * doc/install.texi (Specific) <riscv32-*-elf>: Add table of contents
>         link.
>         <riscv32-*-linux>: Likewise.
>         <riscv64-*-elf>: Likewise
>         <riscv64-*-linux>: Likewise.

Here I'd just say

	* doc/install.texi (Specific): Add foo, bar, didl, doo to the
	table of contents.

>         <riscv32-*-elf>: Add a note about requiring binutils-2.28.

Here and in the text, binutils 2.28 (without the dash).

Approved.

Gerald

PS: We usually send patches to the gcc-patches@ list.

  reply	other threads:[~2017-03-14 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 11:27 Target maintainers: doc/install.texi love and care Gerald Pfeifer
2017-03-13  0:41 ` Palmer Dabbelt
2017-03-13  8:59   ` Gerald Pfeifer
2017-03-13 17:56     ` Palmer Dabbelt
2017-03-13 17:56       ` [PATCH] RISC-V documentation cleanups Palmer Dabbelt
2017-03-14 20:29         ` Gerald Pfeifer [this message]
2017-03-13 18:15 ` Target maintainers: doc/install.texi love and care Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1703142125300.3498@anthias.pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=gcc@gcc.gnu.org \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).