From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 35EBB3858D35 for ; Fri, 14 Jan 2022 16:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35EBB3858D35 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 39153210E2; Fri, 14 Jan 2022 16:10:25 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 1EAC4A3B8A; Fri, 14 Jan 2022 16:10:25 +0000 (UTC) Received: by wotan.suse.de (Postfix, from userid 10510) id EEC3C648D; Fri, 14 Jan 2022 16:10:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by wotan.suse.de (Postfix) with ESMTP id EDAAE61A1; Fri, 14 Jan 2022 16:10:24 +0000 (UTC) Date: Fri, 14 Jan 2022 16:10:24 +0000 (UTC) From: Michael Matz To: =?ISO-8859-15?Q?Martin_Li=A8ka?= cc: GCC Development , Joel Brobecker Subject: Re: git hooks: too strict check In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 16:10:27 -0000 Hello, On Fri, 14 Jan 2022, Martin Liška wrote: > Hello. > > I'm working on a testsuite clean-up where some of the files are wrongly named. > More precisely, so files have .cc extension and should use .C. However there's > existing C test-case and it leads to: > > marxin@marxinbox:~/Programming/gcc/gcc/testsuite> find . -name test-asm.* > ./jit.dg/test-asm.C > ./jit.dg/test-asm.c You can't have that, the check is correct. There are filesystems (NTFS for instance) that are case-preserving but case-insensitive, on those you really can't have two files that differ only in casing. You need to find a different solution, either consistently use .cc instead of .C, live with the inconsistency or rename the base name of these files. Ciao, Michael. > > test-kunlun me/rename-testsuite-files > Enumerating objects: 804, done. > Counting objects: 100% (804/804), done. > Delta compression using up to 16 threads > Compressing objects: 100% (242/242), done. > Writing objects: 100% (564/564), 142.13 KiB | 7.48 MiB/s, done. > Total 564 (delta 424), reused 417 (delta 295), pack-reused 0 > remote: Resolving deltas: 100% (424/424), completed with 222 local objects. > remote: *** The following filename collisions have been detected. > remote: *** These collisions happen when the name of two or more files > remote: *** differ in casing only (Eg: "hello.txt" and "Hello.txt"). > remote: *** Please re-do your commit, chosing names that do not collide. > remote: *** > remote: *** Commit: 7297e1de9bed96821d2bcfd034bad604ce035afb > remote: *** Subject: Rename tests in jit sub-folder. > remote: *** > remote: *** The matching files are: > remote: *** > remote: *** gcc/testsuite/jit.dg/test-quadratic.C > remote: *** gcc/testsuite/jit.dg/test-quadratic.c > remote: *** > remote: *** gcc/testsuite/jit.dg/test-switch.C > remote: *** gcc/testsuite/jit.dg/test-switch.c > remote: *** > remote: *** gcc/testsuite/jit.dg/test-asm.C > remote: *** gcc/testsuite/jit.dg/test-asm.c > remote: *** > remote: *** gcc/testsuite/jit.dg/test-alignment.C > remote: *** gcc/testsuite/jit.dg/test-alignment.c > > Can we please do something about it? > > Thanks, > Martin >