From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26317 invoked by alias); 18 Mar 2019 14:19:30 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 26308 invoked by uid 89); 18 Mar 2019 14:19:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Mar 2019 14:19:28 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3C8DFAE9D; Mon, 18 Mar 2019 14:19:26 +0000 (UTC) Subject: [WIP][RFC] split of i386.c From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: Uros Bizjak , Jeff Law Cc: Eric Gallager , GCC Development , =?UTF-8?Q?Jan_Hubi=c4=8dka?= , "H.J. Lu" , Jakub Jelinek References: <28098c4f-99a6-1004-90d4-82fa2f7eaa9c@redhat.com> Message-ID: Date: Mon, 18 Mar 2019 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00125.txt.bz2 Hi. I'm sending first version of the split, which has following statistics: gcc/config.gcc | 5 +- gcc/config/i386/i386-builtins.c | 2563 ++++++++++ gcc/config/i386/i386-builtins.h | 314 ++ gcc/config/i386/i386-expand.c | 19868 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ gcc/config/i386/i386-expand.h | 40 + gcc/config/i386/i386-features.c | 2854 +++++++++++ gcc/config/i386/i386-features.h | 179 + gcc/config/i386/i386-options.c | 3678 ++++++++++++++ gcc/config/i386/i386-options.h | 76 + gcc/config/i386/i386-protos.h | 4 - gcc/config/i386/i386.c | 62939 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------------------------------------------------------------------------------------------------ gcc/config/i386/i386.h | 9 + gcc/config/i386/t-i386 | 16 + 13 files changed, 46542 insertions(+), 46003 deletions(-) The newly created files have following content: - i386-builtins.c - builtin-in handling, __builtin_cpu_is and __builtin_cpu_supports, target pragma handling - i386-expand.c - all scalar and vector expansion code - i386-features.c - contains isolated target features - vzerotoupper, stv, cet, rpad, multi-versioning, - i386-options.c - option related functions, target attribute handling Now the i386.c file is down in size: 23038 gcc/config/i386/i386.c Question is whether I should continue or not? Remaining content of the file is made of various costing functions, print_reg*, various target hooks, coff, ms_abi, retpolines, output-functions, etc. I don't see any further split point which should define a new file. Patch: https://drive.google.com/file/d/1SiNcR35DHMNBumyg5ltbOozEJ5Q0ajKn/view?usp=sharing Thoughts? Thanks, Martin