public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: "Martin Liška" <mliska@suse.cz>, "GCC Development" <gcc@gcc.gnu.org>
Subject: Re: broken check: You should edit tm.texi.in rather than tm.texi
Date: Mon, 23 Nov 2020 12:06:19 -0700	[thread overview]
Message-ID: <b32a4046-8b22-54ed-0545-fa3944807692@gmail.com> (raw)
In-Reply-To: <c15c52de-69f4-c112-a217-f96559927d03@suse.cz>

On 11/20/20 6:23 AM, Martin Liška wrote:
> Hello.
> 
> I hit the following issue:
> /bin/sh /home/marxin/Programming/gcc/gcc/../move-if-change tmp-tm.texi 
> tm.texi
> You should edit /home/marxin/Programming/gcc/gcc/doc/tm.texi.in rather 
> than /home/marxin/Programming/gcc/gcc/doc/tm.texi .
> 
> Steps to reproduce:
> 1) modify target.def
> 2) you will see:
> 
> Verify that you have permission to grant a GFDL license for all
> new text in /dev/shm/objdir/gcc/tm.texi, then copy it to 
> /home/marxin/Programming/gcc/gcc/doc/tm.texi.
> 
> I copy and commit the changes.
> 
> 3) I made another modification to target.def
> 
> Now I face the issue as
>      elif test $(srcdir)/doc/tm.texi -nt $(srcdir)/doc/tm.texi.in \
>        && ( test $(srcdir)/doc/tm.texi -nt $(srcdir)/target.def \
> 
> So tm.texi.in is older that tm.texi, but it's fine as both tm.texi.in
> and tm.texi are not modified.
> 
> Ideas how to improve the error message? It took me some time to realize
> that 'touch tm.texi.in' is what I need.

I don't know if it was the same problem but I spent a bunch of time
just last week wrestling with this error before it finally went away.

I never did understand what it was complaining about, or the point
of making us jump through these hoops for updates to the internals
manual when the (arguably far more impactful) changes to GCC source
code or the user-visible manual aren't subject to the same check.
Could we dispense with this altogether?  If not, can we implement
something less obtrusive (e.g., looking up the authors email in
MAINTAINERS first)?

Martin

  parent reply	other threads:[~2020-11-23 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 13:23 Martin Liška
2020-11-20 13:42 ` H.J. Lu
2020-11-20 15:26   ` Martin Liška
2020-11-20 15:30     ` Martin Liška
2020-11-20 15:34     ` H.J. Lu
2020-11-23 19:06 ` Martin Sebor [this message]
2020-11-23 19:45   ` Joseph Myers
2020-11-23 20:13     ` Martin Sebor
2020-11-23 20:25       ` Joseph Myers
2020-11-23 21:04         ` Martin Sebor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32a4046-8b22-54ed-0545-fa3944807692@gmail.com \
    --to=msebor@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).