public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Alejandro Colomar <alx.manpages@gmail.com>, gcc@gcc.gnu.org
Subject: Re: [BUG] missing warning for pointer arithmetic out of bounds
Date: Tue, 13 Dec 2022 14:22:23 -0500	[thread overview]
Message-ID: <b36406480908bfa234c44782bc3c16166957bb93.camel@redhat.com> (raw)
In-Reply-To: <3597df95-929b-dfe2-d356-7938a99165ac@gmail.com>

On Tue, 2022-12-13 at 20:15 +0100, Alejandro Colomar via Gcc wrote:
> 
> 
> On 12/13/22 20:08, Alejandro Colomar wrote:
> > Hi!
> > 
> > For the following program:
> > 
> > 
> >      $ cat buf.c
> >      #include <stdio.h>
> > 
> >      int main(void)
> >      {
> >          char *p, buf[5];
> > 
> >          p = buf + 6;
> >          printf("%p\n", p);
> >      }
> > 
> > 
> > There are no warnings in gcc, as I would expect:
> 
> I just re-read my text, and it is ambiguous.  I meant that I expect
> warnings.

Yeah, it would be good to warn about such code.

Looking in bugzilla, I see:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81172
which seems to talk about this issue, but that bug was closed as
resolved on 2020-04-13; I'm not sure what happened here.

Dave


> 
> 
> > 
> >      $ gcc -Wall -Wextra buf.c -O0
> > 
> > Clang does warn, however:
> > 
> >      $ clang -Weverything -Wall -Wextra buf.c -O0
> >      buf.c:8:17: warning: format specifies type 'void *' but the
> > argument has 
> > type 'char *' [-Wformat-pedantic]
> >          printf("%p\n", p);
> >                  ~~     ^
> >                  %s
> >      buf.c:7:6: warning: the pointer incremented by 6 refers past
> > the end of the 
> > array (that contains 5 elements) [-Warray-bounds-pointer-
> > arithmetic]
> >          p = buf + 6;
> >              ^     ~
> >      buf.c:5:2: note: array 'buf' declared here
> >          char *p, buf[5];
> >          ^
> >      2 warnings generated.
> > 
> > Cheers,
> > 
> > Alex
> > 
> > 
> 
> -- 
> <http://www.alejandro-colomar.es/>


  parent reply	other threads:[~2022-12-13 19:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 19:08 Alejandro Colomar
2022-12-13 19:15 ` Alejandro Colomar
2022-12-13 19:18   ` Andrew Pinski
2022-12-18 12:48     ` Optimization levels for getting all warnings (was: [BUG] missing warning for pointer arithmetic out of bounds) Alejandro Colomar
2022-12-13 19:22   ` David Malcolm [this message]
2022-12-13 19:22 ` [BUG] missing warning for pointer arithmetic out of bounds Paul Koning
2022-12-13 19:24   ` Alejandro Colomar
2022-12-13 20:45   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b36406480908bfa234c44782bc3c16166957bb93.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=alx.manpages@gmail.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).