From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id 190363858D37 for ; Sun, 24 Apr 2022 17:42:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 190363858D37 Received: by mail-qk1-x736.google.com with SMTP id d198so9354498qkc.12 for ; Sun, 24 Apr 2022 10:42:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:from:subject; bh=hZqPuZ6PUV0yZk1tiG1+vXFaZhtYFRUYLzsU4SvZrL4=; b=RWvt/FOJ7T13ZtwyhYsWLGci+eAPFZqnb5o/Vj4IXhC7ceL7MVXQlvq06rMNsJy0Ib TGlbJWTDsh6GRhKOrFGIG0BJ3QnG/QwrskaXW0zqTdgxL2kYVmgS7MS6NLxaicBwjD9t CPVzXCzeuS+EwRBERUlzxoIEUHCDEXeEnVN6biZ+9P+2bDnQZUjiGqIy5ihVhDhZFNNQ Ye1Y4SvX3Mwj78KLd8Oh4V85TA9uhne2sku73wLxGlYI2tE720sC8lBaU+k4f57xW6QD JPrryRHKGdfcGWTGhBlJbHriiZtgf0Vc7tN069inPA2HN0f/2HCtsaKQJa6vSGl324uo k2LA== X-Gm-Message-State: AOAM531YSm0vRdtUJXfCPOmN3jSqvOj07Q42cG/D1lXfy4yahQAhEWdB xMrW5BVT3j1vIUDkSnyxlXxzO6Qu0x0= X-Google-Smtp-Source: ABdhPJxmRl8OdtyTY13CjqM/o0vVQz3suzM/3xDV16LIVKyXFbF1RQjAM3hNe8STaEFH2dlHYQ/tCw== X-Received: by 2002:a05:620a:450c:b0:69e:cc36:2b16 with SMTP id t12-20020a05620a450c00b0069ecc362b16mr8087464qkp.141.1650822152087; Sun, 24 Apr 2022 10:42:32 -0700 (PDT) Received: from [192.168.0.29] (65-130-32-223.slkc.qwest.net. [65.130.32.223]) by smtp.gmail.com with ESMTPSA id y25-20020a05620a09d900b0069e82fb9310sm3766123qky.15.2022.04.24.10.42.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 10:42:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------tBHHZq3QLi3yqFBcyaOcJrt9" Message-ID: Date: Sun, 24 Apr 2022 11:42:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: gcc@gcc.gnu.org, binutils@sourceware.org From: Jeff Law Subject: [committed] exec-stack warning for test which wants executable stacks X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2022 17:42:34 -0000 This is a multi-part message in MIME format. --------------tBHHZq3QLi3yqFBcyaOcJrt9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit About a week ago many targets started failing pr94157_0.c test like this (bfin-elf, but many other targets are also affected): > spawn -ignore SIGHUP /home/jlaw/test/obj/bfin-elf/obj/gcc/gcc/xgcc > -B/home/jlaw/test/obj/bfin-elf/obj/gcc/gcc/ c_lto_pr94157_0.o > -fdiagnostics-plain-output -dumpbase  -O0 -fipa-vrp -flto > -Wa,--noexecstack -Wa,--noexecstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -msim > -Wl,-wrap,exit -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort > -Wl,gcc_tg.o -o gcc-dg-lto-pr94157-01.exe^M > /home/jlaw/test/obj/bfin-elf/installed/bfin-elf/bin/ld: warning: > /tmp/ccfJUEvZ.ltrans0.ltrans.o: requires executable stack (because the > .note.GNU-stack section is executable)^M > FAIL: gcc.dg/lto/pr94157 c_lto_pr94157_0.o-c_lto_pr94157_0.o link,  > -O0 -fipa-vrp -flto -Wa,--noexecstack -Wa,--noexecstack > -Wa,--execstack  -Wa,--execstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack > -Wa,--execstack -Wa,--execstack This is due to a new binutils warning.  This patch just suppresses the warning for the one test where we explicitly wanted an executable stack. I'm guessing the repeated -Wa,--noexecstack options in this test are supposed to trigger a  buffer overflow or something similar, so I left those alone and just appended to the argument list. I used -z execstack rather than --no-warn-execstack as the former is recognized by older versions of ld, but the latter is a new option. The other approach would have been to prune the warning, but this seemed better since we'd like most tests to fail if somehow their stacks were executable. Committed to the trunk. Jeff --------------tBHHZq3QLi3yqFBcyaOcJrt9 Content-Type: text/plain; charset=UTF-8; name="P" Content-Disposition: attachment; filename="P" Content-Transfer-Encoding: base64 Y29tbWl0IDZiNzQ0MWE0NmM3NzFhYTZlY2RjMGM4ZWQ5NjE5NzQxN2QwMzZiOWEKQXV0aG9y OiBKZWZmIExhdyA8amVmZnJleWFsYXdAZ21haWwuY29tPgpEYXRlOiAgIFN1biBBcHIgMjQg MTM6Mzg6MTQgMjAyMiAtMDQwMAoKICAgIFtjb21taXR0ZWRdIGV4ZWMtc3RhY2sgd2Fybmlu ZyBmb3IgdGVzdCB3aGljaCB3YW50cyBleGVjdXRhYmxlIHN0YWNrcwogICAgCiAgICBnY2Mv dGVzdHN1aXRlCiAgICAgICAgICAgICogZ2NjLmRnL2x0by9wcjk0MTU3XzAuYzogQWxzbyBy ZXF1ZXN0IGV4ZWN1dGFibGUgc3RhY2sgZnJvbQogICAgICAgICAgICB0aGUgbGlua2VyLgoK ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL2x0by9wcjk0MTU3XzAuYyBiL2dj Yy90ZXN0c3VpdGUvZ2NjLmRnL2x0by9wcjk0MTU3XzAuYwppbmRleCBhNmUzMDhiODU1Yi4u YTc2MTQxYjE4MDkgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL2x0by9wcjk0 MTU3XzAuYworKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9sdG8vcHI5NDE1N18wLmMKQEAg LTEsNiArMSw2IEBACiAvKiB7IGRnLWx0by1kbyBsaW5rIH0gKi8KIC8qIHsgZGctcmVxdWly ZS1lZmZlY3RpdmUtdGFyZ2V0IGdhcyB9ICovCi0vKiB7IGRnLWx0by1vcHRpb25zIHsgeyAt TzAgLWZpcGEtdnJwIC1mbHRvIC1XYSwtLW5vZXhlY3N0YWNrIC1XYSwtLW5vZXhlY3N0YWNr IC1XYSwtLWV4ZWNzdGFjayAgLVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2Es LS1leGVjc3RhY2sgLVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVj c3RhY2sgLVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3RhY2sg LVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3RhY2sgLVdhLC0t ZXhlY3N0YWNrIH0gfSB9ICovCisvKiB7IGRnLWx0by1vcHRpb25zIHsgeyAtTzAgLWZpcGEt dnJwIC1mbHRvIC1XYSwtLW5vZXhlY3N0YWNrIC1XYSwtLW5vZXhlY3N0YWNrIC1XYSwtLWV4 ZWNzdGFjayAgLVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3Rh Y2sgLVdhLC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3RhY2sgLVdh LC0tZXhlY3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3RhY2sgLVdhLC0tZXhl Y3N0YWNrIC1XYSwtLWV4ZWNzdGFjayAtV2EsLS1leGVjc3RhY2sgLVdhLC0tZXhlY3N0YWNr IC1XbCwteixleGVjc3RhY2t9IH0gfSAqLwogCiBpbnQgbWFpbigpIHsKIAo= --------------tBHHZq3QLi3yqFBcyaOcJrt9--