From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 8958F3858C54 for ; Tue, 26 Apr 2022 13:54:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8958F3858C54 Received: by mail-pg1-x52d.google.com with SMTP id t13so16127700pgn.8 for ; Tue, 26 Apr 2022 06:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=HgShr7+3RTftWMxqzkpGzm5itqsWcLisQfWVh+DCygk=; b=WYoq6q9IIKCfdE38CSVP8gjX+raxL2azZNzDFHvxsOH2ScrMv3eZYYAwno5JyCF+n9 50DYXCtAIMFfqrt/uO1WTrZX4H98ruR4CvOyMvZt3Ozr976JW3tqsRJyYSdinBBrq2PO Vfim93eA5t7G8p2IpfFSneDE3c7BHwLvYzjXPxpK5uBkkosPd2YBfWnVmxJG79sS09m/ AR+zioAVr2D4smy5dj+oYehI2L0uj4SAGXNa8kSSZDTslumV7UnE/qVL59qrGCuLiSEm cBBL/BWZkTjwfOgksAQCSaSGhNZnLPLaY6qcTTQcROSx24ad7TTTJ5kQKR0bBNv4qzxf OeIA== X-Gm-Message-State: AOAM533H0dEw/2FdXDhPlQFRsPfWmoNBhUG0XMQd9OE3rUv5NLbzPu5j 5/bcFHT66fwTcw2p4g1JMkg= X-Google-Smtp-Source: ABdhPJxtSZFjWoUfzjcUMbHUO5JNtePfUSfPK+8WEqw8pqlRrD9dWNdHgmk2GM3vzsUztdClLRdwCA== X-Received: by 2002:aa7:9522:0:b0:4e1:d277:ce8 with SMTP id c2-20020aa79522000000b004e1d2770ce8mr24496914pfp.16.1650981254244; Tue, 26 Apr 2022 06:54:14 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id u15-20020a17090a890f00b001cd4989fee4sm3036997pjn.48.2022.04.26.06.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 06:54:13 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 07:54:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [committed] exec-stack warning for test which wants executable stacks Content-Language: en-US From: Jeff Law To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc@gcc.gnu.org, binutils@sourceware.org References: <8e46710d-573b-bd06-cb80-518575dceefc@suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 13:54:17 -0000 On 4/25/2022 8:37 AM, Jeff Law wrote: > > > On 4/25/2022 6:56 AM, Martin Liška wrote: >> >>> I used -z execstack rather than --no-warn-execstack as the former is >>> recognized by older versions of ld, but the latter is a new option. >> Thanks for it. > Unfortunately, I should have looked at the other failures that have > popped up over the last week.  Essentially all the nested function > tests are failing on some targets due to the same linker warning. > > Either pruning or adding  the option to all those tests is going to be > necessary ;( And -z execstack is not universally accepted either.  In fact, we even have some elf targets that don't support it due to oversights (?) in their linker configurations.  But the key thing AFAICT is that -z execstack is an ELF specific flag (I didn't know that until just now).  So we can't really depend on it across the board.  In fact, I wouldn't be surprised if AIX has regressed on the one file I adjusted earlier. So I think that means we're stuck with the less desirable option of pruning the output.  I'll take care of it and reverting the change that added -z execstack to the one test. jeff