public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@acm.org>
To: Michael Matz <matz@suse.de>, Richard Biener <rguenther@suse.de>
Cc: Mark Wielaard <mark@klomp.org>, gcc@gcc.gnu.org
Subject: Re: [RFC] Change PCH "checksum"
Date: Wed, 27 Feb 2019 16:56:00 -0000	[thread overview]
Message-ID: <c40197dc-cf7c-9a7a-842b-120b95451b2e@acm.org> (raw)
In-Reply-To: <alpine.LSU.2.21.1902261614410.5354@wotan.suse.de>

On 2/26/19 11:18 AM, Michael Matz wrote:
> Hi,
> 
> On Tue, 26 Feb 2019, Richard Biener wrote:
> 
>> get_build_id_1 (struct dl_phdr_info *info, size_t, void *data)
>> {
> 
> Isn't this all a bit silly?  We could simply encode the svn revision, or
> maybe even just some random bytes generated once in stage1 at build time
> as "checksum" and be done with.  In the latter case PCHs will then not
> work across different compiler builds, but so what?

FWIW, here's what I do on the modules branch, which has similar 
versioning concerns.

1) in experimental mode, I stamp with the local timestamp modification 
of the cp directory.  I allow mixing versions with in the same day (with 
a warning).

2) in non-experimental mode, I plan to lock to the GCC major.minor tuple.

PCH would need to look at more than the cp directory, but that's good 
enough for me.  I'm pondering an 'ignore version' developer option, but 
as it's only me right now, that's not been a need.

nathan

-- 
Nathan Sidwell

  parent reply	other threads:[~2019-02-27 16:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 11:29 Richard Biener
2019-02-22 15:47 ` Jeff Law
2019-02-22 16:03   ` Jakub Jelinek
2019-02-22 17:12     ` Richard Biener
2019-02-25  8:42 ` Mark Wielaard
2019-02-26  8:33   ` Richard Biener
2019-02-26 11:40     ` Mark Wielaard
2019-02-26 14:36       ` Richard Biener
2019-02-26 14:49         ` Richard Biener
2019-02-26 16:18           ` Michael Matz
2019-02-26 17:02             ` Richard Biener
2019-02-27 16:56             ` Nathan Sidwell [this message]
2019-02-26 17:03         ` Mark Wielaard
2019-02-26 17:13           ` Richard Biener
2019-02-26 17:35             ` Mark Wielaard
2019-02-27 13:12     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c40197dc-cf7c-9a7a-842b-120b95451b2e@acm.org \
    --to=nathan@acm.org \
    --cc=gcc@gcc.gnu.org \
    --cc=mark@klomp.org \
    --cc=matz@suse.de \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).