public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias@codesourcery.com>
To: Mohamed Atef <mohamedatef1698@gmail.com>,
	Jakub Jelinek <jakub@redhat.com>, <gcc@gcc.gnu.org>
Subject: Re: OMPD Branch
Date: Thu, 19 May 2022 09:47:34 +0200	[thread overview]
Message-ID: <c5a3d33f-a3c1-ff4c-2a84-a0fb8bd116c7@codesourcery.com> (raw)
In-Reply-To: <CAPFh8NKHonUhRjqHG7xmjALdc0qN0nHE2SrE1qLTUsdc96LZzQ@mail.gmail.com>

Hi Mohamed,

On 19.05.22 03:39, Mohamed Atef via Gcc wrote:
> Should I commit to devel/omp/gcc-11 branch?

Short answer – no.

Longer answer:

First, devel/omp/gcc-11 (alias OG11) is old – base on GCC 11 and you are targeting
mainline alias GCC 13. Thus, developing against an old version does not make sense.
(Side remark: OG12 should be available soon.)

If you have only localized patches – i.e. those which do not touch many files
which keep getting modified by others, simply posting the patches as you did seems
to be fine. Otherwise, you may want to have a (publicly visible?) git repro of
yourself which is based on mainline. - Thus the latter seems to be more reasonable,
but I think the current way of submitting patches is sufficient.

(An recent example of such a branch would be devel/loop-unswitch-support-switches,
but there are others and some which are not on the GCC git but just mirror it.
But also the initial OpenMP support was developed that way.)


Regarding OG.. itself:

The devel/omp/gcc-... (OG...) branches were created by us* to for two reasons:
to have a place of patches which are not yet in mainline to make them available
as early access – either because of legacy patches or when ready during the Stage 3/4
freezing – and to provide early access to OpenMP/OpenACC/offloading features with a
branch based on stable release.

Currently, there are still several legacy patches – but the goal is to have essentially
only mainline backports on the OG.. branches, with all legacy patches cleaned up,
submitted and then committed to mainline and all new patches applied first to
mainline. (With exceptions during the release freeze as then no larger commits
to mainline are possible. – The number of legacy patch has been reduced over the
last OG.. branches)

I hope it helps. - And thanks for your work on OMPD

Tobias
(*us = CodeSourcery alias (nowadays) Sourcery group at Siemens Digital Industries Software)

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

  reply	other threads:[~2022-05-19  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  1:39 Mohamed Atef
2022-05-19  7:47 ` Tobias Burnus [this message]
2022-05-19  8:27   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5a3d33f-a3c1-ff4c-2a84-a0fb8bd116c7@codesourcery.com \
    --to=tobias@codesourcery.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=mohamedatef1698@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).