public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>,
	Joseph Myers <joseph@codesourcery.com>
Cc: Jason Merrill <jason@redhat.com>, Eric Raymond <esr@thyrsus.com>,
	Jeff Law <law@redhat.com>, GCC Development <gcc@gcc.gnu.org>
Subject: Re: Commit messages and the move to git
Date: Tue, 03 Dec 2019 09:44:00 -0000	[thread overview]
Message-ID: <da348229-38dc-75e8-be77-989c8bcc3076@arm.com> (raw)
In-Reply-To: <20191203004750.GP24609@gate.crashing.org>

On 03/12/2019 00:47, Segher Boessenkool wrote:
> On Mon, Dec 02, 2019 at 08:24:47PM +0000, Joseph Myers wrote:
>> On Mon, 2 Dec 2019, Segher Boessenkool wrote:
>>
>>> Sure; I'm just saying rewriting old commit messages in such a style that
>>> they keep standing out from new ones is a bit of a weird choice.
>>
>> I'd say the rewrites make them stand out *less* (if people avoid having
>> new commit messages whose summary line is just the ChangeLog header line).
> 
> New commits will not start with [smth] in general.  Of course you *can*
> do that, with enough effort.  You can also have two consecutive empty
> lines in your commit messages just fine, but git won't let you without
> a fight.  This is similar.
> 
>> Simply having the Legacy-ID in the commit message will be a visible
>> difference from new commit messages.  But I'm happy it's desirable to have
>> it there, because references to SVN revisions in list archives are so
>> common and having it in the commit messages makes it very quick and easy
>> to map to a git commit id, without needing any on-the-side lists of commit
>> mappings or other tools.
> 
> Yes.  Either in the subject line, or later in the commit message (as
> with git-svn).  We can quibble about where is best, but (hopefully)
> everyone agrees we need the SVN id *somewhere* :-)
> 
> 
> Segher
> 

With my trial reposurgeon conversion:

	git log --all --oneline --grep="Legacy-ID: <number>$"

-all searches all branches, the trailing $ ensures an exact match; 
--oneline just prints the short summary.

eg.
$ git log --oneline --all --grep="Legacy-ID: 278572$"
44e365ba66c [backport] quadmath.h (M_Eq, [...]): Use two more decimal 
places.

No need to put this in the summary.

  reply	other threads:[~2019-12-03  9:44 UTC|newest]

Thread overview: 139+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 10:29 Richard Earnshaw (lists)
2019-11-04 12:11 ` Arnaud Charlet
2019-11-04 12:43 ` Martin Jambor
2019-11-04 17:43   ` Segher Boessenkool
2019-11-04 16:04 ` Jeff Law
2019-11-04 16:18   ` Richard Earnshaw (lists)
2019-11-05 15:48   ` Richard Earnshaw
2019-11-07 14:27   ` Eric S. Raymond
2019-11-08 13:43     ` Richard Earnshaw (lists)
2019-11-09  6:01       ` Eric S. Raymond
2019-11-18 15:32         ` Richard Earnshaw (lists)
2019-11-18 15:55           ` Segher Boessenkool
2019-11-18 16:48             ` Richard Earnshaw (lists)
2019-11-18 17:11               ` Segher Boessenkool
     [not found]                 ` <8c32c288-e9e6-b01b-7911-3f186116da85@gmail.com>
2019-11-18 17:24                   ` Nicholas Krause
2019-11-18 17:26                     ` Nicholas Krause
2019-11-18 17:46                       ` Richard Earnshaw (lists)
2019-11-18 17:49                         ` Richard Earnshaw (lists)
2019-11-18 17:55                         ` Nicholas Krause
2019-11-18 18:05                           ` Richard Earnshaw (lists)
2019-11-18 18:24                             ` Joseph Myers
2019-11-19 11:26                               ` Eric S. Raymond
2019-11-19 11:25                             ` Eric S. Raymond
2019-11-19 11:46                               ` Richard Earnshaw (lists)
2019-11-19 19:32                                 ` Eric S. Raymond
2019-11-19 19:47                                   ` Richard Earnshaw (lists)
2019-11-19 19:49                                     ` Richard Earnshaw (lists)
2019-11-19 22:14                                     ` Eric S. Raymond
2019-11-19 22:19                                       ` Richard Earnshaw (lists)
2019-11-21 16:41                                       ` Joseph Myers
2019-11-21 16:52                                         ` Richard Earnshaw (lists)
2019-11-21 18:11                                           ` Eric S. Raymond
2019-11-21 18:09                                         ` Eric S. Raymond
2019-11-21 19:22                                         ` Richard Earnshaw (lists)
2019-11-19 19:43                                 ` Richard Earnshaw (lists)
2019-11-19 22:08                                   ` Eric S. Raymond
2019-11-18 17:38                 ` Richard Earnshaw (lists)
2019-11-18 18:53                   ` Segher Boessenkool
2019-11-18 19:14                     ` Richard Earnshaw (lists)
2019-11-18 19:21                     ` Richard Earnshaw (lists)
2019-11-18 19:44                       ` Segher Boessenkool
2019-11-18 20:53                         ` Jason Merrill
2019-11-18 21:38                           ` Richard Earnshaw (lists)
2019-11-19 14:57                             ` Jason Merrill
2019-11-19 16:31                               ` Segher Boessenkool
2019-11-19 16:47                                 ` Jonathan Wakely
2019-11-19 16:48                                 ` Jason Merrill
2019-11-19 19:36                                   ` Eric S. Raymond
2019-11-19 23:29                                     ` Segher Boessenkool
2019-11-19 23:44                                       ` Joseph Myers
2019-11-19 23:51                                         ` Nicholas Krause
2019-11-20  8:55                                           ` Jonathan Wakely
2019-11-20 14:50                                         ` Szabolcs Nagy
2019-11-20 17:30                                         ` Richard Earnshaw (lists)
2019-11-20  8:58                                       ` Jonathan Wakely
2019-11-20 11:27                                         ` Segher Boessenkool
2019-11-20 11:30                                           ` Richard Earnshaw (lists)
2019-11-20 11:42                                             ` Segher Boessenkool
2019-11-20 14:25                                           ` Jason Merrill
2019-11-20 16:01                                             ` Segher Boessenkool
2019-11-19 16:49                                 ` Richard Earnshaw (lists)
2019-12-02 10:54                               ` Richard Earnshaw (lists)
2019-12-02 15:35                                 ` Segher Boessenkool
2019-12-02 16:19                                   ` Richard Earnshaw (lists)
2019-12-02 17:25                                     ` Segher Boessenkool
2019-12-02 17:47                                       ` Richard Earnshaw (lists)
2019-12-02 18:00                                         ` Segher Boessenkool
2019-12-02 18:11                                           ` Richard Earnshaw (lists)
2019-12-02 18:17                                           ` Eric S. Raymond
2019-12-02 20:24                                       ` Joseph Myers
2019-12-03  0:48                                         ` Segher Boessenkool
2019-12-03  9:44                                           ` Richard Earnshaw (lists) [this message]
2019-12-03 10:12                                             ` Richard Earnshaw (lists)
2019-12-02 20:22                                     ` Richard Sandiford
2019-12-04 23:52                                 ` Richard Earnshaw (lists)
2019-12-05 10:26                                   ` Jonathan Wakely
2019-12-05 10:32                                     ` Jonathan Wakely
2019-12-05 10:36                                       ` Richard Earnshaw (lists)
2019-12-05 10:41                                         ` Jonathan Wakely
2019-12-05 10:54                                           ` Jonathan Wakely
2019-12-05 13:18                                         ` Joseph Myers
2019-12-05 17:10                                           ` Eric S. Raymond
2019-12-05 17:22                                             ` Joseph Myers
2019-12-05 17:45                                               ` Eric S. Raymond
2019-12-05 20:14                                                 ` Joseph Myers
2019-12-05 20:46                                                   ` Joseph Myers
2019-12-05 21:14                                                     ` Eric S. Raymond
2019-12-05 21:13                                                   ` Eric S. Raymond
2019-12-05 15:33                                         ` Eric S. Raymond
2019-12-18 23:43                   ` Joseph Myers
2019-12-19  0:01                     ` Joseph Myers
2019-12-19  9:27                       ` Jonathan Wakely
2019-12-19 11:05                         ` Jonathan Wakely
2019-12-19 11:50                         ` Richard Earnshaw (lists)
2019-12-19 11:58                           ` Richard Earnshaw (lists)
2019-12-19 12:23                           ` Jonathan Wakely
2019-12-19 12:33                             ` Richard Earnshaw (lists)
2019-12-19 12:35                               ` Jonathan Wakely
2019-12-19 12:42                                 ` Richard Earnshaw (lists)
2019-12-19 13:34                                   ` Jonathan Wakely
2019-12-19 16:00                                     ` Joseph Myers
2019-12-19 16:06                                       ` Richard Earnshaw (lists)
2019-12-19 14:29                           ` Joseph Myers
2019-12-19 15:17                             ` Jonathan Wakely
2019-12-19 15:20                               ` Richard Earnshaw (lists)
2019-12-19 15:44                                 ` Jonathan Wakely
2019-12-19 15:47                                   ` Joseph Myers
2019-12-19 15:48                                     ` Jonathan Wakely
2019-12-19 15:48                                   ` Richard Earnshaw (lists)
2019-12-19 15:49                                 ` Joseph Myers
2019-12-19 16:27                                   ` Jonathan Wakely
2019-12-19 16:28                                     ` Jonathan Wakely
2019-12-19 16:33                                     ` Joseph Myers
2019-12-19 16:39                                       ` Jonathan Wakely
2019-12-19 16:43                                         ` Joseph Myers
2019-12-20 20:30                                     ` Joseph Myers
2019-12-20 21:30                                       ` Jonathan Wakely
2019-12-20 21:41                                         ` Joseph Myers
2019-12-20 22:11                                           ` Jonathan Wakely
2019-12-20 22:58                                             ` Joseph Myers
2019-12-20 23:23                                               ` Jonathan Wakely
2019-12-20 23:53                                                 ` Joseph Myers
2019-12-19 11:16                       ` Jakub Jelinek
2019-12-19 15:05                         ` Richard Earnshaw (lists)
2019-11-04 16:19 ` Jonathan Wakely
2019-11-04 16:35   ` Richard Earnshaw (lists)
2019-11-04 17:33   ` Segher Boessenkool
2019-11-04 17:42     ` Joseph Myers
2019-11-04 17:50       ` Segher Boessenkool
2019-11-05 11:07       ` Jonathan Wakely
2019-11-05 11:28         ` Jason Merrill
2019-11-05 14:12           ` Marek Polacek
2019-11-05 21:40             ` Richard Earnshaw (lists)
2019-11-05 14:50           ` David Malcolm
2019-11-05 22:08             ` Segher Boessenkool
2019-11-05 20:16         ` Segher Boessenkool
2019-11-05 21:01           ` Iain Sandoe
2019-11-05  2:51 ` Kewen.Lin
2019-11-05 21:42   ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da348229-38dc-75e8-be77-989c8bcc3076@arm.com \
    --to=richard.earnshaw@arm.com \
    --cc=esr@thyrsus.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).