From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id DE4B7384001A for ; Tue, 6 Jul 2021 21:20:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE4B7384001A Received: by mail-ot1-x32a.google.com with SMTP id d27-20020a05683018fbb02904ae64d1b56bso165364otf.9 for ; Tue, 06 Jul 2021 14:20:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=jeO5rVTg/DM9+C/AjT4XhlqtN45KW1NckvbORCIgqs0=; b=Y3N0J7hSGhx557+lyao5Ype8xXgvnUkemwNSGWqV3u2/s8RN7dZHP+qWHMfxx2SWJT Qs8kCdbgtrTNMZ6iljAzkDg9GWyuw2vgrHj1gZyzHcemjpZs7UjwKO39otPB0XVgz4TQ F/kpM8sDNxZWAkxv0s28MnrhZ5VUoAW74t3rESnWlVN7CNoClqaSv6JH2jEldPr0sCcd /eWgrA0nFYOYYQyBqlfwdwjXAMRmCFTYkB2S8TGIZc8euzlZoFA2P2H/kTWWLdECiY2B SVAJ/BogtYSi7jVH8kDqcgdXsMlPAJaycXupYJpUPBtWm0FvgEc5JHACFH5ibRxJ5ggV ngNw== X-Gm-Message-State: AOAM531czcZiG1IpED5geG24Xj61l7Ckh0VXWMO0vg2K1rLp37fctdZL BxirZYIMZ7ZAlvKk2sFxnDsbmEFk7jo= X-Google-Smtp-Source: ABdhPJzuLuMiqA9d3zKHKr2ZNn0pKdRkp3AmF0lBYg7enIr5O/VspD3njdxL/Aac+udlDBNnweSFDw== X-Received: by 2002:a9d:7982:: with SMTP id h2mr3040219otm.354.1625606433162; Tue, 06 Jul 2021 14:20:33 -0700 (PDT) Received: from [192.168.0.41] (75-166-102-22.hlrn.qwest.net. [75.166.102.22]) by smtp.gmail.com with ESMTPSA id f74sm2480489otf.45.2021.07.06.14.20.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 14:20:32 -0700 (PDT) From: Martin Sebor Subject: where is PRnnnn required again? To: gcc mailing list Message-ID: Date: Tue, 6 Jul 2021 15:20:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 21:20:35 -0000 I came away from the recent discussion of ChangeLogs requirements with the impression that the PRnnnn bit should be in the subject (first) line and also above the ChangeLog part but doesn't need to be repeated again in the ChangeLog entries. But my commit below was rejected last Friday with the subsequent error. Adding PR middle-end/98871 to the ChangeLog entry let me push the change: https://gcc.gnu.org/g:6feb628a706e86eb3f303aff388c74bdb29e7381 I just had the same error happen now, again with what seems like a valid commit message. Did I misunderstand something or has something changed recently? Martin commit 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 (HEAD -> master) Author: Martin Sebor Date: Fri Jul 2 16:16:31 2021 -0600 Improve warning suppression for inlined functions [PR98512]. Resolves: PR middle-end/98871 - Cannot silence -Wmaybe-uninitialized at declaration si te PR middle-end/98512 - #pragma GCC diagnostic ignored ineffective in conjunct ion with alias attribute gcc/ChangeLog: * diagnostic.c (get_any_inlining_info): New. (update_effective_level_from_pragmas): Handle inlining context. (diagnostic_enabled): Same. (diagnostic_report_diagnostic): Same. * diagnostic.h (struct diagnostic_info): Add ctor. (struct diagnostic_context): Add new member. * tree-diagnostic.c (set_inlining_locations): New. (tree_diagnostics_defaults): Set new callback pointer. Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 16 threads Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 3.37 KiB | 3.37 MiB/s, done. Total 6 (delta 5), reused 0 (delta 0) remote: *** The following commit was rejected by your hooks.commit-extra-checker script (status: 1) remote: *** commit: 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 remote: *** ChangeLog format failed: remote: *** ERR: PR 98512 in subject but not in changelog: "Improve warning suppression for inlined functions [PR98512]." remote: *** remote: *** Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs remote: *** remote: error: hook declined to update refs/heads/master To git+ssh://gcc.gnu.org/git/gcc.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'git+ssh://msebor@gcc.gnu.org/git/gcc.git'