From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 741C43857352 for ; Fri, 23 Jun 2023 20:05:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 741C43857352 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687550748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=enTTXAQqIg+y1RgiDmzk8hyl/V9QLXtKW2+XrzjoOAk=; b=bmCMx/cMA7gXaIFmOSQfUL/tv60uBk2txvsnbbWk6LTAp2noiAwzJuQrGbBmSrW+Bc9P/K xO/vVGN3sdLR7AyYqJe3LFOJEpAyXyeK2XZrc0dLnNrZDdEnbn3g/DCn9vLFZOyyCcofvJ gFc+700yTrC49bGCyREvq1DP4oUkfG0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-cTHV_ehcPiGt-CGRT_CKYg-1; Fri, 23 Jun 2023 16:05:46 -0400 X-MC-Unique: cTHV_ehcPiGt-CGRT_CKYg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-621257e86daso12574696d6.1 for ; Fri, 23 Jun 2023 13:05:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687550744; x=1690142744; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=enTTXAQqIg+y1RgiDmzk8hyl/V9QLXtKW2+XrzjoOAk=; b=VrN5oYcAV5WzvMEi7pvm9SXzUT+SmLHOArdipuJlbq0QkB0cNGthFu54Di2T6M0aBL K/NZtV17tYOPDHv66OI1hLAs8kX9dp9tZc1fyxlOkuxBQQhhuHfB1pO0ciPFPArFx/dv zheY54e4Teu2DewuN8rYCA2GvPo4d5TLVSVdjc7WKJnq8d4E+sWB5y1ahOPRT7t/VUi2 l5tIzxManwCDU8KnyJOimFjisKLlKCBq1eEReuN+zqwF0WLyRCSnKAH0J51o0VD6pMlx L7YZHeIlzUDuk9ps6rGCXwKjrLMg6/XLNjHMSHLMKgxWCPP3gJnNWxi2ctj9ymb9o7by 3HnQ== X-Gm-Message-State: AC+VfDyuXyQlnkipwD/Dlk3g3INONBLroTKGtHF5hve6nMb36GC5Y4Og bCNx6qo1uDQBCYQ2jZfISzLMvVjm8BB82mTehk0H2eZXc+C4jK/WZ9Mjj1+VIL/ldPqG6vwTEC2 V8aB+euU= X-Received: by 2002:a05:622a:13cc:b0:3f8:58d:713 with SMTP id p12-20020a05622a13cc00b003f8058d0713mr29937733qtk.55.1687550744251; Fri, 23 Jun 2023 13:05:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4APWV10NBCsfwKTBYokebFvpUgTiESzU1bpypg2tZhAiZQwcJ4iebnAqky7BOC4edCTJdkFA== X-Received: by 2002:a05:622a:13cc:b0:3f8:58d:713 with SMTP id p12-20020a05622a13cc00b003f8058d0713mr29937717qtk.55.1687550743985; Fri, 23 Jun 2023 13:05:43 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id cm22-20020a05622a251600b003f9e58afea6sm1208445qtb.12.2023.06.23.13.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 13:05:43 -0700 (PDT) Message-ID: Date: Fri, 23 Jun 2023 16:05:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/1] libcpp: allow UCS_LIMIT codepoints in UTF-8 strings To: Ben Boeckel , gcc-patches@gcc.gnu.org Cc: Ben Boeckel , gcc@gcc.gnu.org, brad.king@kitware.com, Damien Guibouret References: <20230621185820.1766291-1-ben.boeckel@kitware.com> From: Jason Merrill In-Reply-To: <20230621185820.1766291-1-ben.boeckel@kitware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/21/23 14:58, Ben Boeckel wrote: > libcpp/ > > * charset.cc: Allow `UCS_LIMIT` in UTF-8 strings. > > Reported-by: Damien Guibouret > Fixes: c1dbaa6656a (libcpp: reject codepoints above 0x10FFFF, 2023-06-06) > Signed-off-by: Ben Boeckel Applied, moving the Fixes line up and changing the commit ID to the git gcc-descr version. Thanks. > --- > libcpp/charset.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libcpp/charset.cc b/libcpp/charset.cc > index d4f573e365f..54ebab2b8a4 100644 > --- a/libcpp/charset.cc > +++ b/libcpp/charset.cc > @@ -1891,7 +1891,7 @@ cpp_valid_utf8_p (const char *buffer, size_t num_bytes) > invalid because they cannot be represented in UTF-16. > > Reject such values.*/ > - if (cp >= UCS_LIMIT) > + if (cp > UCS_LIMIT) > return false; > } > /* No problems encountered. */