GCC 10.3 Release Candidate available from gcc.gnu.org

GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Biener]

The first release candidate for GCC 10.3 is available from

 https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
 ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/

and shortly its mirrors.  It has been generated from git commit
892024d4af83b258801ff7484bf28f0cf1a1a999.

I have so far bootstrapped and tested the release candidate on
x86_64-linux.  Please test it and report any issues to bugzilla.

If all goes well, I'd like to release 10.3 on Thursday, April 8th.

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Eric Botcazou]

> I have so far bootstrapped and tested the release candidate on
> x86_64-linux.  Please test it and report any issues to bugzilla.

It does not build for Windows:
  https://gcc.gnu.org/pipermail/gcc-patches/2021-April/567582.html

-- 
Eric Botcazou

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Biener]

On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou <botcazou@adacore.com> wrote:
>> I have so far bootstrapped and tested the release candidate on
>> x86_64-linux.  Please test it and report any issues to bugzilla.
>
>It does not build for Windows:
>  https://gcc.gnu.org/pipermail/gcc-patches/2021-April/567582.html

Backporting the followup fix is approved. 

Richard. 

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Iain Sandoe]

Richard Biener <rguenther@suse.de> wrote:

> On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou  
> <botcazou@adacore.com> wrote:
>>> I have so far bootstrapped and tested the release candidate on
>>> x86_64-linux.  Please test it and report any issues to bugzilla.

On x86 Darwin, a lot of new libstdc++ experimental/filesystem fails.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99875

Iain

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jonathan Wakely]

On Thu, 1 Apr 2021 at 20:23, Iain Sandoe wrote:
>
> Richard Biener <rguenther@suse.de> wrote:
>
> > On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou
> > <botcazou@adacore.com> wrote:
> >>> I have so far bootstrapped and tested the release candidate on
> >>> x86_64-linux.  Please test it and report any issues to bugzilla.
>
> On x86 Darwin, a lot of new libstdc++ experimental/filesystem fails.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99875

I missed a backport, this is needed for gcc-10 branch:
https://gcc.gnu.org/cgi-bin/gcc-gitref.cgi?r=r11-7239
Only affects the testsuite, but in a util header that is used by lots of tests.

I'll wait for RM approval before pushing the backport.

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Biener]

On April 1, 2021 9:49:19 PM GMT+02:00, Jonathan Wakely via Gcc <gcc@gcc.gnu.org> wrote:
>On Thu, 1 Apr 2021 at 20:23, Iain Sandoe wrote:
>>
>> Richard Biener <rguenther@suse.de> wrote:
>>
>> > On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou
>> > <botcazou@adacore.com> wrote:
>> >>> I have so far bootstrapped and tested the release candidate on
>> >>> x86_64-linux.  Please test it and report any issues to bugzilla.
>>
>> On x86 Darwin, a lot of new libstdc++ experimental/filesystem fails.
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99875
>
>I missed a backport, this is needed for gcc-10 branch:
>https://gcc.gnu.org/cgi-bin/gcc-gitref.cgi?r=r11-7239
>Only affects the testsuite, but in a util header that is used by lots
>of tests.
>
>I'll wait for RM approval before pushing the backport.

This is OK.

Richard. 

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jonathan Wakely]

On Thu, 1 Apr 2021 at 21:08, Richard Biener wrote:
>
> On April 1, 2021 9:49:19 PM GMT+02:00, Jonathan Wakely via Gcc <gcc@gcc.gnu.org> wrote:
> >On Thu, 1 Apr 2021 at 20:23, Iain Sandoe wrote:
> >>
> >> Richard Biener <rguenther@suse.de> wrote:
> >>
> >> > On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou
> >> > <botcazou@adacore.com> wrote:
> >> >>> I have so far bootstrapped and tested the release candidate on
> >> >>> x86_64-linux.  Please test it and report any issues to bugzilla.
> >>
> >> On x86 Darwin, a lot of new libstdc++ experimental/filesystem fails.
> >>
> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99875
> >
> >I missed a backport, this is needed for gcc-10 branch:
> >https://gcc.gnu.org/cgi-bin/gcc-gitref.cgi?r=r11-7239
> >Only affects the testsuite, but in a util header that is used by lots
> >of tests.
> >
> >I'll wait for RM approval before pushing the backport.
>
> This is OK.

Pushed, thanks.

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jakub Jelinek]

On Thu, Apr 01, 2021 at 08:49:19PM +0100, Jonathan Wakely via Gcc wrote:
> On Thu, 1 Apr 2021 at 20:23, Iain Sandoe wrote:
> >
> > Richard Biener <rguenther@suse.de> wrote:
> >
> > > On April 1, 2021 4:08:21 PM GMT+02:00, Eric Botcazou
> > > <botcazou@adacore.com> wrote:
> > >>> I have so far bootstrapped and tested the release candidate on
> > >>> x86_64-linux.  Please test it and report any issues to bugzilla.
> >
> > On x86 Darwin, a lot of new libstdc++ experimental/filesystem fails.
> >
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99875
> 
> I missed a backport, this is needed for gcc-10 branch:
> https://gcc.gnu.org/cgi-bin/gcc-gitref.cgi?r=r11-7239
> Only affects the testsuite, but in a util header that is used by lots of tests.
> 
> I'll wait for RM approval before pushing the backport.

Ok.

	Jakub

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[William Seurer]

I bootstrap built and tested for powerpc 64 on power 7 and 8 BE and 
power 8, 9, and 10 LE and I saw nothing unexpected.

On 4/1/21 7:35 AM, Richard Biener wrote:
> The first release candidate for GCC 10.3 is available from
>
>   https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>   ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>
> and shortly its mirrors.  It has been generated from git commit
> 892024d4af83b258801ff7484bf28f0cf1a1a999.
>
> I have so far bootstrapped and tested the release candidate on
> x86_64-linux.  Please test it and report any issues to bugzilla.
>
> If all goes well, I'd like to release 10.3 on Thursday, April 8th.

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Matthias Klose]

On 4/1/21 2:35 PM, Richard Biener wrote:
> 
> The first release candidate for GCC 10.3 is available from
> 
>  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> 
> and shortly its mirrors.  It has been generated from git commit
> 892024d4af83b258801ff7484bf28f0cf1a1a999.
> 
> I have so far bootstrapped and tested the release candidate on
> x86_64-linux.  Please test it and report any issues to bugzilla.

with the backport of PR95842, the plugin header install is now broken.

Needs also backporting of 9a83366b62e585cce5577309013a832f895ccdbf
"Fix up plugin header install".

Matthias

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jakub Jelinek]

On Fri, Apr 02, 2021 at 09:37:26AM +0200, Matthias Klose wrote:
> On 4/1/21 2:35 PM, Richard Biener wrote:
> > 
> > The first release candidate for GCC 10.3 is available from
> > 
> >  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> >  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> > 
> > and shortly its mirrors.  It has been generated from git commit
> > 892024d4af83b258801ff7484bf28f0cf1a1a999.
> > 
> > I have so far bootstrapped and tested the release candidate on
> > x86_64-linux.  Please test it and report any issues to bugzilla.
> 
> with the backport of PR95842, the plugin header install is now broken.
> 
> Needs also backporting of 9a83366b62e585cce5577309013a832f895ccdbf
> "Fix up plugin header install".

Cherry-picked now.

	Jakub

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Copley]

On 01/04/2021 13:35, Richard Biener wrote:
> The first release candidate for GCC 10.3 is available from
> 
>   https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>   ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> 
> and shortly its mirrors.  It has been generated from git commit
> 892024d4af83b258801ff7484bf28f0cf1a1a999.
> 
> I have so far bootstrapped and tested the release candidate on
> x86_64-linux.  Please test it and report any issues to bugzilla.
> 
> If all goes well, I'd like to release 10.3 on Thursday, April 8th.
> 

On Windows, linking two C++ translation units that both #include 
<coroutine> results in errors about multiple definition of the weak 
function __dummy_resume_destroy. This can be avoided by cherry-picking 
commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jonathan Wakely]

On Sat, 3 Apr 2021 at 00:53, Richard Copley via Gcc <gcc@gcc.gnu.org> wrote:
>
> On 01/04/2021 13:35, Richard Biener wrote:
> > The first release candidate for GCC 10.3 is available from
> >
> >   https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> >   ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
> >
> > and shortly its mirrors.  It has been generated from git commit
> > 892024d4af83b258801ff7484bf28f0cf1a1a999.
> >
> > I have so far bootstrapped and tested the release candidate on
> > x86_64-linux.  Please test it and report any issues to bugzilla.
> >
> > If all goes well, I'd like to release 10.3 on Thursday, April 8th.
> >
>
> On Windows, linking two C++ translation units that both #include
> <coroutine> results in errors about multiple definition of the weak
> function __dummy_resume_destroy. This can be avoided by cherry-picking
> commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].

That problem is already present in GCC 10.2, right?

I didn't backport that because it's an ABI change, so not appropriate
to change between minor releases (even for an experimental feature
like coroutines). PR 95917 was about suboptimal codegen; nobody
reported that there's a multiple definition error on Windows. I don't
think we should fix this for 10.3, but please report it to bugzilla
and we can look into a fix for 10.4 (maybe with something specific to
Windows).

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Iain Sandoe]

Jonathan Wakely via Gcc <gcc@gcc.gnu.org> wrote:

> On Sat, 3 Apr 2021 at 00:53, Richard Copley via Gcc <gcc@gcc.gnu.org>  
> wrote:
>> On 01/04/2021 13:35, Richard Biener wrote:
>>> The first release candidate for GCC 10.3 is available from
>>>
>>>  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>>  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>>
>>> and shortly its mirrors.  It has been generated from git commit
>>> 892024d4af83b258801ff7484bf28f0cf1a1a999.
>>>
>>> I have so far bootstrapped and tested the release candidate on
>>> x86_64-linux.  Please test it and report any issues to bugzilla.
>>>
>>> If all goes well, I'd like to release 10.3 on Thursday, April 8th.
>>
>> On Windows, linking two C++ translation units that both #include
>> <coroutine> results in errors about multiple definition of the weak
>> function __dummy_resume_destroy. This can be avoided by cherry-picking
>> commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].
>
> That problem is already present in GCC 10.2, right?
>
> I didn't backport that because it's an ABI change, so not appropriate
> to change between minor releases (even for an experimental feature
> like coroutines). PR 95917 was about suboptimal codegen; nobody
> reported that there's a multiple definition error on Windows.

That agrees with my recollection - the entity was marked as ‘weak’ so that
there should only be one instance in a linked exe.  However, that did lead
to a complaint that object files then contained the weak entity any time the
coroutine header was included.

Is there something more needed to support weak definitions for Windows?

> I don’t think we should fix this for 10.3, but please report it to bugzilla
> and we can look into a fix for 10.4 (maybe with something specific to
> Windows).

+1

Iain

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Copley]

On 03/04/2021 13:25, Iain Sandoe wrote:
> Jonathan Wakely via Gcc <gcc@gcc.gnu.org> wrote:
> 
>> On Sat, 3 Apr 2021 at 00:53, Richard Copley via Gcc <gcc@gcc.gnu.org> 
>> wrote:
>>> On 01/04/2021 13:35, Richard Biener wrote:
>>>> The first release candidate for GCC 10.3 is available from
>>>>
>>>>  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>>>  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>>>
>>>> and shortly its mirrors.  It has been generated from git commit
>>>> 892024d4af83b258801ff7484bf28f0cf1a1a999.
>>>>
>>>> I have so far bootstrapped and tested the release candidate on
>>>> x86_64-linux.  Please test it and report any issues to bugzilla.
>>>>
>>>> If all goes well, I'd like to release 10.3 on Thursday, April 8th.
>>>
>>> On Windows, linking two C++ translation units that both #include
>>> <coroutine> results in errors about multiple definition of the weak
>>> function __dummy_resume_destroy. This can be avoided by cherry-picking
>>> commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].
>>
>> That problem is already present in GCC 10.2, right?

Right, yes.

>> I didn't backport that because it's an ABI change, so not appropriate
>> to change between minor releases (even for an experimental feature
>> like coroutines). PR 95917 was about suboptimal codegen; nobody
>> reported that there's a multiple definition error on Windows.

Yeah. This just happens to be the time I first came across the problem. 
I know I should have started with a bug report on bugzilla, but I 
thought I'd chance my arm.

> That agrees with my recollection - the entity was marked as ‘weak’ so that
> there should only be one instance in a linked exe.  However, that did lead
> to a complaint that object files then contained the weak entity any time 
> the
> coroutine header was included.
> 
> Is there something more needed to support weak definitions for Windows?

Maybe! I don't know though -- the description of weak definitions in the 
documentation doesn't seem to imply that multiple weak definitions are 
allowed. Forgive me if I misunderstood.

>> I don’t think we should fix this for 10.3, but please report it to 
>> bugzilla
>> and we can look into a fix for 10.4 (maybe with something specific to
>> Windows).
> 
> +1

Yes, I don't see any big urgency! I will construct a bugzilla report. 
Maybe the downstreams will decide to do something in the meantime (e.g., 
my PR at MINGW-packeges [1]).

[1] https://github.com/msys2/MINGW-packages/pull/8263

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Copley]

On 03/04/2021 22:12, Richard Copley wrote:
>>>> On Windows, linking two C++ translation units that both #include
>>>> <coroutine> results in errors about multiple definition of the weak
>>>> function __dummy_resume_destroy. This can be avoided by cherry-picking
>>>> commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].

> I will construct a bugzilla report.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99907

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Jonathan Wakely]

On Sun, 4 Apr 2021, 12:40 Richard Copley, <rcopley@gmail.com> wrote:

> On 03/04/2021 22:12, Richard Copley wrote:
> >>>> On Windows, linking two C++ translation units that both #include
> >>>> <coroutine> results in errors about multiple definition of the weak
> >>>> function __dummy_resume_destroy. This can be avoided by cherry-picking
> >>>> commit 94fd05f1f76faca9dc9033b55d44c960155d38e9 [PR 95917].
>
> > I will construct a bugzilla report.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99907


Thanks!

>
>

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Christophe Lyon]

On Thu, 1 Apr 2021 at 14:35, Richard Biener <rguenther@suse.de> wrote:
>
>
> The first release candidate for GCC 10.3 is available from
>
>  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>
> and shortly its mirrors.  It has been generated from git commit
> 892024d4af83b258801ff7484bf28f0cf1a1a999.
>
> I have so far bootstrapped and tested the release candidate on
> x86_64-linux.  Please test it and report any issues to bugzilla.
>
> If all goes well, I'd like to release 10.3 on Thursday, April 8th.


Hi,

Last week I committed Richard Earnshaw's fix for PR target/99773),
which affects gcc-10 (sorry I didn't check that when I filed the PR,
I just realized later that 10.3 was so close to release).

I think it would be desirable to backport the patch to gcc-10:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=6f93a7c7fc62b2d6ab47e5d5eb60d41366e1ee9e

Is that too late?

Thanks

Christophe

Re: GCC 10.3 Release Candidate available from gcc.gnu.org

[Richard Biener]

On April 4, 2021 10:26:37 PM GMT+02:00, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>On Thu, 1 Apr 2021 at 14:35, Richard Biener <rguenther@suse.de> wrote:
>>
>>
>> The first release candidate for GCC 10.3 is available from
>>
>>  https://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>  ftp://gcc.gnu.org/pub/gcc/snapshots/10.3.0-RC-20210401/
>>
>> and shortly its mirrors.  It has been generated from git commit
>> 892024d4af83b258801ff7484bf28f0cf1a1a999.
>>
>> I have so far bootstrapped and tested the release candidate on
>> x86_64-linux.  Please test it and report any issues to bugzilla.
>>
>> If all goes well, I'd like to release 10.3 on Thursday, April 8th.
>
>
>Hi,
>
>Last week I committed Richard Earnshaw's fix for PR target/99773),
>which affects gcc-10 (sorry I didn't check that when I filed the PR,
>I just realized later that 10.3 was so close to release).
>
>I think it would be desirable to backport the patch to gcc-10:
>https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=6f93a7c7fc62b2d6ab47e5d5eb60d41366e1ee9e
>
>Is that too late?

Since it doesn't appear to be a regression it should wait until after 10.3. 

Richard. 

>Thanks
>
>Christophe