From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by sourceware.org (Postfix) with ESMTPS id 272B23858C50 for ; Mon, 16 May 2022 07:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 272B23858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=perches.com Received: from omf10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 6D6D21210F5; Mon, 16 May 2022 07:18:35 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 707F040; Mon, 16 May 2022 07:18:29 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3] workqueue: Wrap flush_workqueue() using a macro From: Joe Perches To: Tetsuo Handa , Tejun Heo Cc: LKML , gcc Date: Mon, 16 May 2022 00:18:28 -0700 In-Reply-To: <1c1b272b-239c-e1d1-84de-47d02feb911e@I-love.SAKURA.ne.jp> References: <6e4ed62e-888b-6e7a-c13d-67656f39ca94@I-love.SAKURA.ne.jp> <738afe71-2983-05d5-f0fc-d94efbdf7634@I-love.SAKURA.ne.jp> <7b2fecdb-59ae-2c54-5a5b-774ef7054d1b@I-love.SAKURA.ne.jp> <1c1b272b-239c-e1d1-84de-47d02feb911e@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: ube18spr5b3crk3gobc31nifo7aa5b81 X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: 707F040 X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18jtvK0bs/QQC9DdHFRHLrEMs2Snoe06V0= X-HE-Tag: 1652685509-763519 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 07:18:37 -0000 On Mon, 2022-05-16 at 14:00 +0900, Tetsuo Handa wrote: [] > Changes in v3: > Revert suggested change in v2, for kernel test robot found > > warning: Function parameter or member 'flush_workqueue' not described in 'void' > warning: expecting prototype for flush_workqueue(). Prototype was for void() instead > > when built with W=1 option. Odd, perhaps that not a valid error message and is a defect in gcc's parsing of function definitions. > Changes in v2: > Use "void (flush_workqueue)(struct workqueue_struct *wq)" and remove > "#undef flush_workqueue", suggested by Joe Perches .