From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CCFEA385482F; Mon, 9 Aug 2021 12:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCFEA385482F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBB9821E20; Mon, 9 Aug 2021 12:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628511489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wa6qxA9lSKhtoKeuyVR449x8Hup6nQgBq0bfYsi5uw4=; b=hXGRJ9SbaxsRCYDWnstBixb9qlO0SkAXn1y8suf4OLrnZT8TCqIevgfIhuYuXqUMjBzy/C zZnKUiIonvD15zU45zXNlXDynlM8K9ncT366SEsIpwOAObE7w8/N7uexN0UJq+G+2lndar +bUiykNW6srXDnx39uH1OEN01dPKBis= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628511489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wa6qxA9lSKhtoKeuyVR449x8Hup6nQgBq0bfYsi5uw4=; b=wrDWdwmaH0BxR4q2hs440vP75J+nvJn5tES6A3dzKA+8eU8LaQ/ghfEVDCbs6eJZogm+dB o/7VIxJu5qfGDmBw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9AE1313731; Mon, 9 Aug 2021 12:18:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id KSo6JAEdEWFWXwAAGKfGzw (envelope-from ); Mon, 09 Aug 2021 12:18:09 +0000 Subject: Re: [PATCH] Port GCC documentation to Sphinx To: Martin Sebor , Joseph Myers Cc: GCC Development , gcc-patches@gcc.gnu.org References: <1446990946.2994.192.camel@surprise> <1a22bc37-3d48-132f-a3d5-219471cd443c@suse.cz> <3a2a573b-5185-fff5-f9da-6e5e39953ad6@suse.cz> <8641dc55-5412-fbd7-bafd-13604311f5ad@suse.cz> <5ffe3e32-ece0-a1b4-1fcf-e35177fa80b5@suse.cz> <87489d9a-44e2-411c-3f3a-534d07e78b95@suse.cz> <0866a0ea-c846-ea5e-ac7a-d1c8f106cc45@suse.cz> <5bb9a10d-f3b9-f16a-7430-bbae2d4978e2@suse.cz> <2f60f602-5d88-7674-9620-2172748664c5@suse.cz> <2afb9dc2-68d7-a1c6-49c2-e3d769e37ea0@gmail.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Mon, 9 Aug 2021 14:18:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <2afb9dc2-68d7-a1c6-49c2-e3d769e37ea0@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_EU, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2021 12:18:12 -0000 On 7/12/21 7:18 PM, Martin Sebor wrote: > On 6/29/21 4:09 AM, Martin Liška wrote: >> On 6/28/21 5:33 PM, Joseph Myers wrote: >>> Are formatted manuals (HTML, PDF, man, info) corresponding to this patch >>> version also available for review? >> >> I've just uploaded them here: >> https://splichal.eu/gccsphinx-final/ >> >> Martin >> > > I think listing the -Wfoo and -Wno-foo (and analogously the -fbar > and -fno-bar) options is an improvement over prior revisions but when > the positive form is the default the text reads funny.  For example: Thank you! > >   -fno-inline > >       Do not expand any functions inline apart from those marked >       with the always_inline attribute. This is the default when >       not optimizing. > >       Single functions can be exempted from inlining by marking >       them with the noinline attribute. > >   -finline > >       Default option value for -fno-inline. > > > I.e., -finline is not what I would describe as a default value for > -fno-inline. > > I would suggest to drop the option name from the text describing > the default, and also replace value with setting (it's really not > a value).  It could be as simple as: > >   -finline > >       Default setting. > > Alternatively, to preserve the connection to the alternate setting: > >   -finline > >       Default setting; overrides -fno-inline. I like the improvement suggestion and I've just adjusted the generated output to 'Default setting; overrides -fno-inline'. > > At some point we talked about also making attributes hyperlinks > (like always_inline and noinline above) but I don't remember > the conclusion.  Are you planning to do that?  (Would handling > it as part of the transition be easier than doing it later?) I've provided more links for attributes. However, there are still limitations that needs to be addressed: 1) I used :option: directive which might be a bit abused (one can eventually come up with a custom directive. 2) Attributes like 'alias ("target")' do not correctly work with :option:`alias`, so the option definition needs to changed to 'alias' and we would have to provide syntax description on a next line. It's something I plan working on we merge it. Martin > > Martin