From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pS3b=HC=hazardy.de=gcc@sourceware.org>
Received: from mail.hazardy.de (mail.hazardy.de [78.94.181.132])
	by sourceware.org (Postfix) with ESMTPS id E0F243858D35;
	Tue, 21 Nov 2023 19:35:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0F243858D35
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hazardy.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hazardy.de
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0F243858D35
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=78.94.181.132
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700595328; cv=none;
	b=ZmBoJbYfrh5m0fXzBWZc/JVKF5oRO68/Cb0W+eKNkytdfpT84uxSA6yXj0yoeyO7+zfpdfqbQvg428paTfp/LJZ+lbwz4V9/gH/NJ9t6fsoR899BZo5IeqycRO+eG0R5vu8MkwMLf5jwUfczTt9cHDXazMkApV3JhPZ9RgPc1Fk=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1700595328; c=relaxed/simple;
	bh=42AyBUDi4z+8ZlWL4fZz0Tro0h4F85jPANP0jDk1sWA=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=K3xMBt8/KC76d6m5zZh7IMeCP9dXvG9SJSSH1OjIWqww3wdOw/sk4uCW6bYXtV6p2rhYGc8dCmuDRmGmGL0fLv/Bx/8OE4vM4DiILp0Fp+oqvMGbn3QgO2oufCRxFaVVB4w6VvQ+RENw9BqFylF0xvoACm8BgfQdm11KZ86zIXg=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from [10.0.1.129] (hades.hazardy.de [10.0.1.129])
	by mail.hazardy.de (Postfix) with ESMTPSA id 42448700219;
	Tue, 21 Nov 2023 20:35:25 +0100 (CET)
Message-ID: <f230e75e-e5d0-4c20-d7c4-6e5efc4555ca@hazardy.de>
Date: Tue, 21 Nov 2023 20:35:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 3/4] libbacktrace: work with aslr on windows
To: Eli Zaretskii <eliz@gnu.org>
Cc: gabravier@gmail.com, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org
References: <20230120105409.54949-1-gcc@hazardy.de>
 <20230120105409.54949-3-gcc@hazardy.de> <83zgadmik1.fsf@gnu.org>
 <e1e2342c-27f1-7cec-787e-23b4c6dfee6b@gmail.com> <83k01hm2sm.fsf@gnu.org>
 <64148e01-15a1-0331-ad52-bf131403ed76@gmail.com> <83h6wkmt0t.fsf@gnu.org>
 <b38c3633-33f1-a100-5ecc-216f58741cc0@gmail.com> <83pmb8ktbe.fsf@gnu.org>
 <cf2682f0-6b4c-04b0-a6da-ca4da9388fab@hazardy.de> <83jzqci3yk.fsf@gnu.org>
Content-Language: de-DE, en-US
From: =?UTF-8?Q?Bj=c3=b6rn_Sch=c3=a4pers?= <gcc@hazardy.de>
In-Reply-To: <83jzqci3yk.fsf@gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc.gcc.gnu.org>

I'll guess it is not needed here, but otherwise <windows.h> defines the macros 
max and min, they then conflict e.g. with C++'s std::max/std::min. So I consider 
it best practice to always define it, before including <windows.h>.

Am 20.11.2023 um 21:07 schrieb Eli Zaretskii:
>> Date: Mon, 20 Nov 2023 20:57:38 +0100
>> Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org
>> From: Björn Schäpers <gcc@hazardy.de>
>>
>> +#ifndef NOMINMAX
>> +#define NOMINMAX
>> +#endif
> 
> Why is this part needed?
> 
> Otherwise, LGTM, thanks.  (But I'm don't have the approval rights, so
> please wait for Ian to chime in.)