public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org, GCC Development <gcc@gcc.gnu.org>
Subject: [PATCH, v2] wwwdocs: e-mail subject lines for contributions
Date: Tue, 21 Jan 2020 15:40:00 -0000	[thread overview]
Message-ID: <ff130918-cbbb-2afc-d752-1af2ca9df340@arm.com> (raw)
In-Reply-To: <353faf3e-bf43-eb4d-542d-45a53dce77b2@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

[updated, following some comments from Gerald, main differences are
  slight tweaks to the html markup and changing "email" to "e-mail"]

This patch proposes some new (additional) rules for email subject lines
when contributing to GCC.  The goal is to make sure that, as far as
possible, the subject for a patch will form a good summary when the
message is committed to the repository if applied with 'git am'.  Where
possible, I've tried to align these rules with those already in
use for glibc, so that the differences are minimal and only where
necessary.

Some things that differ from existing practice (at least by some people)
are:

- Use '<topic>:' rather than '[<topic>]'
   - This is more git friendly and works with 'git am'.
- Put bug numbers at the end of the line rather than the beginning.
   - The bug number is useful, but not as useful as the brief summary.
     Also, use the shortened form, as the topic part is more usefully
     conveyed in the proper topic field (see above).



[-- Attachment #2: contrib.patch --]
[-- Type: text/x-patch, Size: 4469 bytes --]

diff --git a/htdocs/contribute.html b/htdocs/contribute.html
index 042ff069..861f7e5e 100644
--- a/htdocs/contribute.html
+++ b/htdocs/contribute.html
@@ -249,13 +249,98 @@ that ChangeLog entries may be included as part of the patch and diffs
 representing new files may be omitted, especially if large, since they
 can be accessed directly from the repository.)</p> 
 
+<h3>E-mail subject lines</h3>
+
+<p>Your contribution e-mail subject line will become the first line of
+the commit message for your patch.</p>
+
+<p>A high-quality e-mail subject line for a contribution contains the
+following elements:</p>
+
+<ul>
+  <li>A classifier</li>
+  <li>Component tags</li>
+  <li>An optional series identifier</li>
+  <li>A brief summary</li>
+  <li>An optional bug number</li>
+</ul>
+
+<h4>Classifier</h4>
+
+<p>The classifier identifies the type of contribution, for example a
+patch, an RFC (request for comments) or a committed patch (where
+approval is not necessary.  The classifier should be written in upper
+case and surrounded with square brackets.  This is the only component
+of the e-mail subject line that will not appear in the commit itself.
+The classifier may optionally contain a version number (v<i>N</i>) and
+a series marker (<i>N/M</i>).  Examples are:</p>
+
+<ul>
+  <li><code>[PATCH]</code> - a single patch</li>
+  <li><code>[PATCH v2]</code> - the second version of a single patch</li>
+  <li><code>[PATCH 3/7]</code> - the third patch in a series of seven
+    patches</li>
+  <li><code>[RFC]</code> - a point of discussion, may contain a patch</li>
+  <li><code>[COMMITTED]</code> - a patch that has already been committed.</li>
+</ul>
+
+<h4>Component tags</h4>
+
+<p>A component tag is a short identifier that identifies the part of
+the compiler being modified.  This highlights to the relevant
+maintainers that the patch may need their attention.  Multiple
+components may be listed if necessary.  Each component tag should be
+followed by a colon.  For example,</p>
+
+<ul>
+  <li><code>libstdc++:</code></li>
+  <li><code>combine:</code></li>
+  <li><code>vax: testsuite:</code></li>
+</ul>
+
+<h4>Series identifier</h4>
+
+<p>The series identifier is optional and is only relevant if a number of
+patches are needed in order to effect an overall change.  It should be
+a <i>short</i> string that identifies the series (it is common to all
+patches) and should be followed by a single dash surrounded by white
+space.</p>
+
+<h4>Brief summary</h4>
+
+<p>The brief summary encapsulates in a few words the intent of the
+change.  For example: <code>cleanup check_field_decls</code>.</p>
+
+<h4>Bug number</h4>
+
+<p>If your patch fixes a bug in the compiler for which there is an
+existing PR number the bug number should be stated.  Use the
+short-form variant (PR<i>nnnnn</i>) without the bugzilla component
+identifier.</p>
+
+<h4>Other messages</h4>
+
+<p>Some large patch sets benefit from an introductory e-mail that
+provides more context for the patch series and describes how the
+patches have been broken up to provide for review.  The convention is
+that such messages should follow the same format as described above,
+but the patch number should be set to zero, for example: <code>[PATCH
+0/7]</code>.  Remember that the introductory message will not be
+committed with the patches themselves, so it should not contain any
+important information that is not also covered in the individual
+patches.  If you send a summary e-mail with a series it is a good idea
+to send the patches as follow-ups (essentially replies) to your
+initial message so that mail software can group the messages
+together.</p>
+
 <h3>Pinging patches, Getting patches applied</h3>
 
 <p>If you do not receive a response to a patch that you have submitted
 within two weeks or so, it may be a good idea to chase it by sending a
-follow-up email to the same list(s).  Patches can occasionally fall through
-the cracks.  Please be sure to include a brief summary of the patch and the
-URL of the entry in the mailing list archive of the original submission.</p>
+follow-up e-mail to the same list(s).  Patches can occasionally fall
+through the cracks.  Please be sure to include a brief summary of the
+patch and the URL of the entry in the mailing list archive of the
+original submission.</p>
 
 <p>If you do not have write access and a patch of yours has been approved,
 but not committed, please advise the approver of that fact.  You may want

       reply	other threads:[~2020-01-21 14:52 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c3928f40-2d71-fb5b-f2e0-3878ac88a2b7@arm.com>
     [not found] ` <alpine.LSU.2.21.2001191425160.739@anthias.pfeifer.com>
     [not found]   ` <353faf3e-bf43-eb4d-542d-45a53dce77b2@arm.com>
2020-01-21 15:40     ` Richard Earnshaw (lists) [this message]
2020-01-21 16:03       ` Jakub Jelinek
2020-01-21 16:14         ` Richard Earnshaw (lists)
2020-01-21 16:38           ` Jakub Jelinek
2020-01-21 16:43             ` Richard Earnshaw (lists)
2020-01-21 19:27               ` Jason Merrill
2020-01-22  3:46                 ` Richard Earnshaw (lists)
2020-01-22 10:00                   ` Jakub Jelinek
2020-01-22 13:50                     ` Richard Earnshaw (lists)
2020-01-22 13:54                       ` Jakub Jelinek
2020-01-22 17:41                   ` Richard Sandiford
2020-01-22 17:45                     ` Marek Polacek
2020-01-22 17:50                       ` Richard Earnshaw (lists)
2020-01-22  9:07       ` Segher Boessenkool
2020-01-22 16:05         ` Richard Earnshaw (lists)
2020-01-22 16:37           ` Segher Boessenkool
2020-01-22 18:49       ` [PATCH, v3] " Richard Earnshaw (lists)
2020-02-03 11:41         ` Richard Earnshaw (lists)
2020-02-03 11:54           ` Alexander Monakov
2020-02-03 11:59             ` Richard Earnshaw (lists)
2020-02-03 12:51               ` Alexander Monakov
2020-02-03 14:11                 ` Jason Merrill
2020-02-03 15:13                   ` Richard Earnshaw (lists)
2020-02-03 15:15                     ` Richard Earnshaw (lists)
2020-02-03 13:54             ` Segher Boessenkool
2020-02-03 14:00               ` Richard Earnshaw (lists)
2020-02-03 14:13                 ` Jonathan Wakely
2020-02-03 15:05                   ` Richard Earnshaw (lists)
2020-02-03 16:12                     ` Andrew Clayton
2020-02-03 17:17                 ` Segher Boessenkool
2020-02-03 17:19                 ` Segher Boessenkool
2020-02-03 17:31                 ` Michael Matz
2020-02-03 17:36                   ` Richard Earnshaw (lists)
2020-02-03 17:49                     ` Michael Matz
2020-02-03 17:54                       ` Jakub Jelinek
2020-02-03 18:09                         ` Michael Matz
2020-02-04 10:41                           ` Andrew Stubbs
2020-02-03 18:57                         ` Segher Boessenkool
2020-02-03 17:54                       ` Richard Earnshaw (lists)
2020-02-03 18:20                         ` Michael Matz
2020-02-03 19:48                           ` Segher Boessenkool
2020-02-03 18:03                       ` Joseph Myers
2020-02-03 17:34                 ` Segher Boessenkool
2020-02-27 13:38           ` Nathan Sidwell
2020-03-02 13:01             ` Richard Earnshaw (lists)
2020-03-02 13:35               ` Segher Boessenkool
2020-03-02 14:31               ` Nathan Sidwell
2020-03-02 14:41                 ` Jonathan Wakely
2020-03-02 15:22                   ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff130918-cbbb-2afc-d752-1af2ca9df340@arm.com \
    --to=richard.earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).