* Getting rid of GET_RTX_CLASS?
@ 2004-02-03 16:55 Paolo Bonzini
2004-02-03 21:14 ` Richard Henderson
2004-02-03 21:15 ` Geoff Keating
0 siblings, 2 replies; 7+ messages in thread
From: Paolo Bonzini @ 2004-02-03 16:55 UTC (permalink / raw)
To: gcc
I'd like to turn rtx classes from characters to enums. Would this be
feasible? Interesting? It may result in slight compile time speedups,
also.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 16:55 Getting rid of GET_RTX_CLASS? Paolo Bonzini
@ 2004-02-03 21:14 ` Richard Henderson
2004-02-03 21:28 ` Zack Weinberg
2004-02-05 13:10 ` Theodore Papadopoulo
2004-02-03 21:15 ` Geoff Keating
1 sibling, 2 replies; 7+ messages in thread
From: Richard Henderson @ 2004-02-03 21:14 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: gcc
On Tue, Feb 03, 2004 at 05:56:59PM +0100, Paolo Bonzini wrote:
> I'd like to turn rtx classes from characters to enums. Would this be
> feasible? Interesting? It may result in slight compile time speedups,
> also.
*shrug* I'm not sure why there would be any particular advantage...
r~
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 21:14 ` Richard Henderson
@ 2004-02-03 21:28 ` Zack Weinberg
2004-02-03 23:16 ` Paolo Bonzini
2004-02-05 13:10 ` Theodore Papadopoulo
1 sibling, 1 reply; 7+ messages in thread
From: Zack Weinberg @ 2004-02-03 21:28 UTC (permalink / raw)
To: Richard Henderson; +Cc: Paolo Bonzini, gcc
Richard Henderson <rth@redhat.com> writes:
> On Tue, Feb 03, 2004 at 05:56:59PM +0100, Paolo Bonzini wrote:
>> I'd like to turn rtx classes from characters to enums. Would this be
>> feasible? Interesting? It may result in slight compile time speedups,
>> also.
>
> *shrug* I'm not sure why there would be any particular advantage...
Compact switch tables, presumably.
zw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 21:28 ` Zack Weinberg
@ 2004-02-03 23:16 ` Paolo Bonzini
2004-02-03 23:26 ` Eric Christopher
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2004-02-03 23:16 UTC (permalink / raw)
To: Zack Weinberg; +Cc: gcc
> >> I'd like to turn rtx classes from characters to enums. Would this be
> >> feasible? Interesting? It may result in slight compile time speedups,
> >> also.
>
> Compact switch tables, presumably.
Yes; lookup tables instead of binary searching. I also hope to learn something
while reading the code -- low priority things are good for beginners (like me).
I'd also like to introduce new predicates (like OBJECT_P I already have a patch
for) that express conditions like
GET_RTX_CLASS (x) == '2'
|| GET_RTX_CLASS (x) == '<'
|| GET_RTX_CLASS (x) == 'c'
that abound in cse and other places that may be put under a diet after tree-ssa
is merged. These could become GET_RTX_CLASS (x) >= BINARY && GET_RTX_CLASS (x)
<= BINARY_COMMUTATIVE (cheaper) as long as this is found only once, in rtl.h.
I suspect that an inordinate amount of time is spent in rtl.h if my very simple
OBJECT_P patch had a 1% gain on bootstrap time.
Paolo
-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 23:16 ` Paolo Bonzini
@ 2004-02-03 23:26 ` Eric Christopher
0 siblings, 0 replies; 7+ messages in thread
From: Eric Christopher @ 2004-02-03 23:26 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Zack Weinberg, gcc
>
> Yes; lookup tables instead of binary searching. I also hope to learn something
> while reading the code -- low priority things are good for beginners (like me).
Actually it'll help readability too. It being so much easier to know
what 'c' is in rtx_class than something like say "COMMUTATIVE_BINARY".
:)
-eric
--
Eric Christopher <echristo@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 21:14 ` Richard Henderson
2004-02-03 21:28 ` Zack Weinberg
@ 2004-02-05 13:10 ` Theodore Papadopoulo
1 sibling, 0 replies; 7+ messages in thread
From: Theodore Papadopoulo @ 2004-02-05 13:10 UTC (permalink / raw)
To: Richard Henderson, Paolo Bonzini, gcc
rth@redhat.com said:
>> I'd like to turn rtx classes from characters to enums. Would this be
>> feasible? Interesting? It may result in slight compile time
>> speedups,
>> also.
> *shrug* I'm not sure why there would be any particular advantage...
Better names under gdb....
--------------------------------------------------------------------
Theodore Papadopoulo
Email: Theodore.Papadopoulo@sophia.inria.fr Tel: (33) 04 92 38 76 01
--------------------------------------------------------------------
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of GET_RTX_CLASS?
2004-02-03 16:55 Getting rid of GET_RTX_CLASS? Paolo Bonzini
2004-02-03 21:14 ` Richard Henderson
@ 2004-02-03 21:15 ` Geoff Keating
1 sibling, 0 replies; 7+ messages in thread
From: Geoff Keating @ 2004-02-03 21:15 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: gcc
"Paolo Bonzini" <paolo.bonzini@polimi.it> writes:
> I'd like to turn rtx classes from characters to enums. Would this be
> feasible? Interesting? It may result in slight compile time speedups,
> also.
I don't see any particular reason why this would be impossible (or
even difficult; just tedious). I also think it's probably a good
idea, although not a very high-priority one.
--
- Geoffrey Keating <geoffk@geoffk.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2004-02-05 13:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-03 16:55 Getting rid of GET_RTX_CLASS? Paolo Bonzini
2004-02-03 21:14 ` Richard Henderson
2004-02-03 21:28 ` Zack Weinberg
2004-02-03 23:16 ` Paolo Bonzini
2004-02-03 23:26 ` Eric Christopher
2004-02-05 13:10 ` Theodore Papadopoulo
2004-02-03 21:15 ` Geoff Keating
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).