From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1963 invoked by alias); 8 Oct 2003 21:32:56 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 1938 invoked from network); 8 Oct 2003 21:32:55 -0000 Received: from unknown (HELO desire.geoffk.org) (12.235.88.42) by sources.redhat.com with SMTP; 8 Oct 2003 21:32:55 -0000 Received: (from geoffk@localhost) by desire.geoffk.org (8.11.6/8.11.6) id h98LWon18925; Wed, 8 Oct 2003 14:32:50 -0700 X-Authentication-Warning: desire.geoffk.org: geoffk set sender to geoffk@geoffk.org using -f To: Zdenek Dvorak Cc: "gcc@gcc.gnu.org" Subject: Re: [tree-ssa] Garbage collector x bb annotations References: <20031006223141.GA2094@atrey.karlin.mff.cuni.cz> <1065619632.7057.44.camel@frodo.toronto.redhat.com> <20031008135344.GB18809@atrey.karlin.mff.cuni.cz> From: Geoff Keating Date: Wed, 08 Oct 2003 21:32:00 -0000 In-Reply-To: <20031008135344.GB18809@atrey.karlin.mff.cuni.cz> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00295.txt.bz2 Zdenek Dvorak writes: > Hello, > > > > I have just run into the following problem: dom_children get released by > > > ggc_collect call in tree-ssa-pre. Allocating them by ggc seems wrong to > > > me, since basic block annotations are allocated from obstack and > > > invisible to garbage collector. > > > > > Yeah. But there's more than that, unfortunately. All the fields in > > struct bb_ann_d are ggc allocated. The real solution would be to > > finally convert basic blocks to ggc. Volunteers? > > I may try (I need it anyway for tree-ssa-cfg branch). The whole issue > is however quite ugly as this combines basically all allocation > mechanisms that are available in gcc (basic blocks themselves are pool > allocated). It's not that ugly to make the fix, you simply have to throw out all those other allocation mechanisms and use ggc. -- - Geoffrey Keating